s3: Fix a winbind crash

nss_get_info_cached might have invalidated "ads" deep inside.

diff --git a/source3/winbindd/winbindd_ads.c b/source3/winbindd/winbindd_ads.c
index 227c967c931c84112238318983b2d7ac17c0c0a9..96dabaa81a26dc60b560533e721ba9ff77122cf0 100644 (file)
--- a/source3/winbindd/winbindd_ads.c
+++ b/source3/winbindd/winbindd_ads.c
@@ -547,9 +547,14 @@ static NTSTATUS query_user(struct winbindd_domain *domain,
 
        info->acct_name = ads_pull_username(ads, mem_ctx, msg);
 
-       nss_get_info_cached( domain, sid, mem_ctx, ads, msg, 
+       status = nss_get_info_cached( domain, sid, mem_ctx, ads, msg,
                      &info->homedir, &info->shell, &info->full_name, 
                      &info->primary_gid );     
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(1, ("nss_get_info_cached failed: %s\n",
+                         nt_errstr(status)));
+               goto done;
+       }
 
        if (info->full_name == NULL) {
                info->full_name = ads_pull_string(ads, mem_ctx, msg, "name");