s3:registry: don't leak to talloc_stack in regdb_store_keys_internal2()

and catch one potential talloc failure.

Michael

diff --git a/source3/registry/reg_backend_db.c b/source3/registry/reg_backend_db.c
index 542f6dc7d0dd5e4420464706cceac7127240d583..6bf98d4c7564004c702e921e5459a8c09141f004 100644 (file)
--- a/source3/registry/reg_backend_db.c
+++ b/source3/registry/reg_backend_db.c
@@ -623,14 +623,21 @@ static WERROR regdb_store_keys_internal2(struct db_context *db,
        WERROR werr;
 
        if (!key) {
-               return WERR_INVALID_PARAM;
+               werr = WERR_INVALID_PARAM;
+               goto done;
        }
 
        keyname = talloc_strdup(ctx, key);
        if (!keyname) {
-               return WERR_NOMEM;
+               werr = WERR_NOMEM;
+               goto done;
        }
+
        keyname = normalize_reg_path(ctx, keyname);
+       if (!keyname) {
+               werr = WERR_NOMEM;
+               goto done;
+       }
 
        /* allocate some initial memory */