s4/scripting/bin: py2/py3 compatability always decode result of b64encode
authorNoel Power <noel.power@suse.com>
Fri, 4 May 2018 14:25:22 +0000 (15:25 +0100)
committerAndrew Bartlett <abartlet@samba.org>
Sat, 12 May 2018 19:38:17 +0000 (21:38 +0200)
Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source4/scripting/bin/fullschema
source4/scripting/bin/get-descriptors
source4/scripting/bin/minschema
source4/scripting/bin/samba_upgradedns
source4/scripting/bin/samba_upgradeprovision

index 2987136a40df99e16c21a3e09e1ec5771e20472a..ab0e4e320bd07dc130d7e5d4b468494a3438d3e8 100755 (executable)
@@ -147,7 +147,7 @@ def write_ldif_one(o, attrs):
             value = fix_dn(j)
             if a != "cn":
                 if a == "oMObjectClass":
-                    print "%s:: %s" % (a, base64.b64encode(value))
+                    print "%s:: %s" % (a, base64.b64encode(value)).decode('utf8')
                 elif a.endswith("GUID"):
                     print "%s: %s" % (a, ldb.schema_format_value(a, value))
                 else:
index 73295b0c3834e869d5e2db95f0e07cfe3ce0ea22..f1a919c37480c3b70c6b0f15b5541fcc61208fdf 100755 (executable)
@@ -85,7 +85,7 @@ class DescrGetter:
         ldif_entry = ["dn: " + dn,
                       "changetype: modify",
                       "replace: nTSecurityDescriptor",
-                      "nTSecurityDescriptor::  " + base64.b64encode(ndr_pack(descr))]
+                      "nTSecurityDescriptor::  " + base64.b64encode(ndr_pack(descr)).decode('utf8')]
 
         for line in ldif_entry:
             length = 79
index 8ec559a458476f10ab8a1fba13b5ffbc0ad0308f..176ad5c93b9fcd5c8567830fa75c2453d6aae69b 100755 (executable)
@@ -200,7 +200,7 @@ def write_ldif_one(o, attrs):
         for j in v:
                        value = fix_dn(j)
                        if a == "oMObjectClass":
-                               print "%s:: %s" % (a, base64.b64encode(value))
+                               print "%s:: %s" % (a, base64.b64encode(value).decode('utf8'))
                        elif a.endswith("GUID"):
                                print "%s: %s" % (a, ldb.schema_format_value(a, value))
                        else:
index db15b65e1dc981e2465f3e8e224ad9336963c328..e29ba7092b57bc5a49684dba9bb4716e65bf9d34 100755 (executable)
@@ -469,7 +469,7 @@ if __name__ == '__main__':
             setup_add_ldif(ldbs.sam, setup_path("provision_dns_add_samba.ldif"), {
                     "DNSDOMAIN": dnsdomain,
                     "DOMAINDN": domaindn,
-                    "DNSPASS_B64": b64encode(dnspass.encode('utf-16-le')),
+                    "DNSPASS_B64": b64encode(dnspass.encode('utf-16-le')).decode('utf8'),
                     "HOSTNAME" : hostname,
                     "DNSNAME" : dnsname }
                            )
index 62b7001f56528ca190bcdeec92af1dda8c08e373..9d3e73604a2e6ca27a5fbf9efb6bed96177905d3 100755 (executable)
@@ -1067,7 +1067,7 @@ def reload_full_schema(samdb, names):
         schema_ldif += samdb.write_ldif(ent, ldb.CHANGETYPE_NONE)
 
     prefixmap_data = open(setup_path("prefixMap.txt"), 'r').read()
-    prefixmap_data = b64encode(prefixmap_data)
+    prefixmap_data = b64encode(prefixmap_data).decode('utf8')
 
     # We don't actually add this ldif, just parse it
     prefixmap_ldif = "dn: %s\nprefixMap:: %s\n\n" % (schemadn, prefixmap_data)