Revert "try to fix"

This reverts commit a55f0f776d77a5b9d7c4c4b84aba01622ff79b94.

Revert "HACK ldb_transaction_active"

This reverts commit 556beaf22b4e6488d2de979ee4bd67046769b3ea.

Revert "debug samldb_lockout_time"

This reverts commit e1c3dc94af6e6c09692919ec3a6149e0c8739fe5.

Revert "ldb_transaction_active after commit assert in authsam_logon_success_accounting"

This reverts commit a689ba364932a48737e8398aab6c4b50aa3faed8.

Revert "authsam_logon_success_accounting debug modify object"

This reverts commit 71fe81b36e73f1a92c94b0b0bea265904a4f4c64.

Revert "authsam_logon_success_accounting search debug changed object"

This reverts commit 62693093dad4913ddaf127ee32d393090d641693.

Revert "sq authsam_logon_success_accounting search debug changed object"

This reverts commit e5a761cdc1d3d50e39f2e7733bc9b94cea2f036a.

Revert "source4/dsdb/tests/python/rodc_rwdc.py reproduce ntlm"

This reverts commit 79e32b39957dfedea66d87af7c71ee6328e5951b.

Revert "DEBUG netr_SendToSamBase problem"

This reverts commit e5b07f2278b9101dfdf5c4a8158463fe381958d8.

DEBUG netr_SendToSamBase problem

source4/dsdb/tests/python/rodc_rwdc.py reproduce ntlm

sq authsam_logon_success_accounting search debug changed object

authsam_logon_success_accounting search debug changed object

authsam_logon_success_accounting debug modify object

ldb_transaction_active after commit assert in authsam_logon_success_accounting

debug samldb_lockout_time

HACK ldb_transaction_active

Revert "lib/util/debug.c force timestamps"

This reverts commit c7d98dc9a7cd4b664a0597347a91014cbfb263f5.

lib/util/debug.c force timestamps

try to fix

Revert "source4/libcli/raw/clitree.c The smbcli_[tree]_full_connection forces SMB1"

This reverts commit d10336c254684dc5d9ce76c4141674ac3e4e5b16.

Revert "source3/selftest/tests.py or t.startswith("rpc.spoolss.") smb1"

This reverts commit 183d7ab79ce9ff1cede67d1517d9b5aa77b81701.

source3/selftest/tests.py or t.startswith("rpc.spoolss.") smb1

source4/libcli/raw/clitree.c The smbcli_[tree]_full_connection forces SMB1

Revert "TODO LATER generate_request_auth(drep...)"

This reverts commit a1fc888eb55e38b9e9e372f81c1bc298af1ea90f.

TODO LATER generate_request_auth(drep...)

Revert "ntlmssp_server_preauth highest_ofs"

This reverts commit 2bee300fe2d0f4b7484c5e10a37bfa6a923e9734.

ntlmssp_server_preauth highest_ofs

Revert "msrpc_parse more strict + H => highest_ofs"

This reverts commit 3fb130186ddfe807bc0827cbc37131955da1ab47.

msrpc_parse more strict + H => highest_ofs

Revert "HACK ntlmssp_client_initial 2888 "d""

This reverts commit 2b1a260350a1e91b5634f72ff03ce7962d886b84.

HACK ntlmssp_client_initial 2888 "d"

Revert "HACK SPNEGO_CLIENT_TARG gensec_spnego_create_negTokenInit_finish padding"

This reverts commit d519367a1f9a733a6cd6d93d64f10eb5dc0c650f.

HACK SPNEGO_CLIENT_TARG gensec_spnego_create_negTokenInit_finish padding

Revert "LATER? pycredentials: add {get,set}_netlogon_creds()"

This reverts commit f854703f019b1fe4936ce2847dab22b3b25dd5b8.

LATER? pycredentials: add {get,set}_netlogon_creds()

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>

Revert "debug mutex third_party/socket_wrapper/socket_wrapper.c"

This reverts commit e010a8f71403e8c5f41f033e4819e2ec608f9eec.

Revert "swrap_warn_stale reproduce deadlock  third_party/socket_wrapper/socket_wrapper.c"

This reverts commit 3a73b1a7982d62fb54c5152613ef8c1550bcc0c3.

swrap_warn_stale reproduce deadlock  third_party/socket_wrapper/socket_wrapper.c

debug mutex third_party/socket_wrapper/socket_wrapper.c

Revert "NOT NEEDED self.max_bind_auth_offset = 5812"

This reverts commit 790ef54d0fe0a2d3ab980fac43af9dcaa2b1524e.

NOT NEEDED self.max_bind_auth_offset = 5812

Revert "TODO source4/auth/gensec/pygensec.c seal"

This reverts commit 7a8ff01940ac97313f775ef57fab3bb7f8ab8b83.

TODO source4/auth/gensec/pygensec.c seal

exec SMB_CONF_PATH=/dev/null SERVER=172.31.9.188 TARGET_HOSTNAME=w2012r2-188.w2012r2-l6.base USERNAME=administrator PASSWORD=A1b2C3d4 python/samba/tests/dcerpc/raw_protocol.py -v -f TestDCERPC_BIND
exec TDB_NO_FSYNC=1 make -j test _FAIL_IMMEDIATELY=1 SOCKET_WRAPPER_KEEP_PCAP=1 TESTS='raw_protocol'

rm selftest/knownfail.d/dcerpc-auth-pad

FIX8 if (a->auth_type != auth_type) => auth_invalid

FIX8 sq dcesrv_auth_prepare_auth3

FIX8 auth3 fault codes

FIX8 SQ auth3 with 4 legs results in DCERPC_NCA_S_PROTO_ERROR => no
fault, just a delayed one

FIX8 auth3 with 4 legs results in DCERPC_NCA_S_PROTO_ERROR

FIX8 auth3 check against call->conn->transport_max_recv_frag

FIX8 librpc/rpc/dcesrv better fault codes dcesrv_auth_prepare_auth3

FIX7 sq2 fix default_auth_level_connect auth_invalid => FAULT_ACCESS_DENIED

FIX7 fix default_auth_level_connect auth_invalid => FAULT_ACCESS_DENIED

TEST5 test_no_auth_ctx_request

TEST3 LATER python/samba/tests/dcerpc/raw_testcase.py get_invalid_creds

TEST7 fix comment in test_spnego_change_auth_type1

gensec:spnego: ignore trailing bytes in SPNEGO_SERVER_START state - selftest/knownfail.d/dcerpc-auth-pad

gensec:spnego: ignore trailing bytes in SPNEGO_SERVER_START state

This matches Windows (at least Server 2012_R2).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>

gensec:ntlmssp: only allow messages up to 2888 bytes - selftest/knownfail.d/dcerpc-auth-pad

gensec:ntlmssp: only allow messages up to 2888 bytes

This matches Windows (at least Server 2012_R2).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>

dcesrv_core: alter_context logon failures should result in DCERPC_FAULT_ACCESS_DENIED test_spnego_change_auth_type1 selftest/knownfail.d/dcerpc-auth-pad

dcesrv_core: alter_context logon failures should result in DCERPC_FAULT_ACCESS_DENIED

We should use DCERPC_FAULT_ACCESS_DENIED as default for
gensec status results of e.g. NT_STATUS_LOGON_FAILURE or
NT_STATUS_INVALID_PARAMTER.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>

dcesrv_core: a failure from gensec_update results in NAK_REASON_INVALID_CHECKSUM selftest/knownfail.d/dcerpc-auth-pad

dcesrv_core: a failure from gensec_update results in NAK_REASON_INVALID_CHECKSUM

We already report that for gensec_start_mech_by_authtype() failures,
but we also need to do that for any invalid authentication.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>

dcerpc_util: let dcerpc_pull_auth_trailer() ignore data_and_pad for bind, alter, auth3 selftest/knownfail.d/dcerpc-auth-pad

dcerpc_util: let dcerpc_pull_auth_trailer() ignore data_and_pad for bind, alter, auth3

Sometimes Windows sends 3 presentation contexts (NDR32, NDR64,
BindTimeFeatureNegotiation) in the first BIND of an association.

Binding an additional connection to the association seems to
reuse the BIND buffer and just changes the num_contexts field from
3 to 2 and leaves the BindTimeFeatureNegotiation context as padding
in places.

Note, the auth_pad_length field is send as 0 in that case,
which means we need to ignore it completely, as well as any
padding before the auth header.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>

dcerpc_util: let dcerpc_pull_auth_trailer() expose the reject reason selftest/knownfail.d/dcerpc-auth-pad

dcerpc_util: let dcerpc_pull_auth_trailer() expose the reject reason

If dcerpc_pull_auth_trailer() returns NT_STATUS_RPC_PROTOCOL_ERROR
it will return the BIND reject code in auth->auth_context_id.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>

dcerpc_util: let dcerpc_pull_auth_trailer() check that auth_offset is 4 bytes aligned selftest/knownfail.d/dcerpc-auth-pad

dcerpc_util: let dcerpc_pull_auth_trailer() check that auth_offset is 4 bytes aligned

That what Windows (at least 2012_R2) also asserts.

It also makes sure that ndr_pull_dcerpc_auth() will
start with ndr->offset = 0 and don't tries to eat
possible padding.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>

TEST2 TODO test_schannel_invalid_bind selftest/knownfail.d/dcerpc-auth-pad

TEST2 TODO test_schannel_invalid_bind

TEST1b test_spnego_connect_bind_auth_align[4|2] selftest/knownfail.d/dcerpc-auth-pad

TEST1b test_spnego_connect_bind_auth_align[4|2]

TEST1 python/samba/tests/dcerpc/raw_protocol.py selftest/knownfail.d/dcerpc-auth-pad

TEST1 python/samba/tests/dcerpc/raw_protocol.py

dcesrv_core: introduce dcesrv_connection->transport_max_recv_frag

The max fragment size depends on the transport.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>

tests/dcerpc/raw_protocol: run test_neg_xmit_ffff_ffff over tcp and smb

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>

dcesrv_core: add more verbose debugging for missing association groups

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>

RawDCERPCTest: add some more auth_length related asserts

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>

RawDCERPCTest: split prepare_pdu() and send_pdu_blob() out of send_pdu()

This will make it possible to alter pdus before sending them to the
server.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>

s4:librpc: provide py_schannel bindings

This will be used in the dcerpc.raw_protocol test.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14356

Signed-off-by: Stefan Metzmacher <metze@samba.org>

debug fault

Revert "debug fault"

This reverts commit b9cc9004f5d95ac29504b1e4dafe01c6be7c56ee.

debug fault

Revert "Revert "s3:rpc_client: implement DCERPC_BIND_TIME_PROTECT_ALL_PDUS""

This reverts commit 679fd3c8e2f26cf961e01ca56a39a373b6cf9b30.

Revert "Revert "s4:librpc/rpc: implement DCERPC_BIND_TIME_PROTECT_ALL_PDUS""

This reverts commit 71b7c6a941c978a6aafe2e52da0d2258788a77c2.

Revert "Revert "s3:rpc_client: implement preauth hashing support""

This reverts commit 75fd726e66ebbd1f73992ecd89d5f976374b3c96.

Revert "Revert "s4:librpc/rpc: implement preauth hashing support""

This reverts commit 84e4745174378259d9778a113e1ca81ff01db346.

Revert "Revert "Revert "s4:librpc/rpc: implement preauth hashing support"""

This reverts commit 97516adf4b0d5b68c00a53895e8c304cbca66f8b.

Revert "Revert "Revert "s3:rpc_client: implement preauth hashing support"""

This reverts commit dc82612774508354d0b51b239c161840dbba61ef.

Revert "Revert "Revert "s4:librpc/rpc: implement DCERPC_BIND_TIME_PROTECT_ALL_PDUS"""

This reverts commit 721a318edd39838c6f2318df15ce6f24c57fb69b.

Revert "Revert "Revert "s3:rpc_client: implement DCERPC_BIND_TIME_PROTECT_ALL_PDUS"""

This reverts commit 6c0eb5463c735a6d99e3f33b36d7f1069480889c.

Revert "Revert "dcesrv_core: add support for DCERPC_BIND_TIME_PROTECT_ALL_PDUS""

This reverts commit f174934098422e5d04b3b5e47ee9384e51405f11.

Revert "Revert "dcesrv_core: implement preauth hashing support""

This reverts commit 1d112459c0cfdc2d8343954be023fcce46dbc3ee.

Revert "dcesrv_core: implement preauth hashing support"

This reverts commit a1982c8c10591e05374eed06388054baa20bc331.

Revert "dcesrv_core: add support for DCERPC_BIND_TIME_PROTECT_ALL_PDUS"

This reverts commit 075b12cf688df215ca212dd5251d4fa61ea57eb3.

Revert "Revert "s3:rpc_client: implement DCERPC_BIND_TIME_PROTECT_ALL_PDUS""

This reverts commit 679fd3c8e2f26cf961e01ca56a39a373b6cf9b30.