s3:smbd: Fix really ugly bool vs. int bug!!!
authorStefan Metzmacher <metze@samba.org>
Tue, 9 Feb 2010 17:54:41 +0000 (18:54 +0100)
committerKarolin Seeger <kseeger@samba.org>
Thu, 11 Feb 2010 10:28:53 +0000 (11:28 +0100)
A comparison function for qsort needs to return an 'int'!
Otherwise you'll get random results depending on the compiler
and the architecture...

metze
(cherry picked from commit 1686a5e7e7eb1b411b003cbbde5c0d28741c6d02)

source3/smbd/lanman.c

index 98c9d75420370b38779c5acb7a3b919990abcf13..5e0123509138c31ed0018a55130dd4cb444f0a87 100644 (file)
@@ -1353,7 +1353,7 @@ static int fill_srv_info(struct srv_info_struct *service,
 }
 
 
-static bool srv_comp(struct srv_info_struct *s1,struct srv_info_struct *s2)
+static int srv_comp(struct srv_info_struct *s1,struct srv_info_struct *s2)
 {
 #undef strcasecmp
        return strcasecmp(s1->name,s2->name);
@@ -1517,7 +1517,7 @@ static bool api_RNetServerEnum2(connection_struct *conn, uint16 vuid,
        return True;
 }
 
-static bool srv_name_match(const char *n1, const char *n2)
+static int srv_name_match(const char *n1, const char *n2)
 {
        /*
         * [MS-RAP] footnote <88> for Section 3.2.5.15 says: