s3:lib change default share security access mask
authorChristian Ambach <ambi@samba.org>
Tue, 26 Jul 2011 11:43:14 +0000 (13:43 +0200)
committerMichael Adam <obnox@samba.org>
Tue, 11 Oct 2011 13:21:01 +0000 (15:21 +0200)
when there is no share SD set, the default share SD that
is used e.g. for the output of sharesec -v defaults to a
value that is not equivalent to the desired FULL access.

This is a more or less a cosmetical follow-up for the patches
in Bug #8201 that makes them more consumeable by printing
FULL (that is what the user expects) instead of a bitmask
in hexadecimal form.

previous output:
REVISION:1
OWNER:(NULL SID)
GROUP:(NULL SID)
ACL:S-1-1-0:ALLOWED/0/0x101f01ff

with patch:
REVISION:1
OWNER:(NULL SID)
GROUP:(NULL SID)
ACL:S-1-1-0:ALLOWED/0/FULL

Autobuild-User: Christian Ambach <ambi@samba.org>
Autobuild-Date: Tue Jul 26 15:57:55 CEST 2011 on sn-devel-104

source3/lib/sharesec.c

index 410fc1336b0f76553660db567a7cd34c2d21c7e7..0cc9dedcf80cda3002b24a35abc7dade54a07da3 100644 (file)
@@ -293,7 +293,7 @@ struct security_descriptor *get_share_security( TALLOC_CTX *ctx, const char *ser
 
        if (data.dptr == NULL) {
                return get_share_security_default(ctx, psize,
-                                                 GENERIC_ALL_ACCESS);
+                                                 SEC_RIGHTS_DIR_ALL);
        }
 
        status = unmarshall_sec_desc(ctx, data.dptr, data.dsize, &psd);
@@ -304,14 +304,14 @@ struct security_descriptor *get_share_security( TALLOC_CTX *ctx, const char *ser
                DEBUG(0, ("unmarshall_sec_desc failed: %s\n",
                          nt_errstr(status)));
                return get_share_security_default(ctx, psize,
-                                                 GENERIC_ALL_ACCESS);
+                                                 SEC_RIGHTS_DIR_ALL);
        }
 
        if (psd) {
                *psize = ndr_size_security_descriptor(psd, 0);
        } else {
                return get_share_security_default(ctx, psize,
-                                                 GENERIC_ALL_ACCESS);
+                                                 SEC_RIGHTS_DIR_ALL);
        }
 
        return psd;