libwbclient: Re-Fix a bug that was fixed with e5741e27c4c

> r21878: Fix a bug with smbd serving a windows terminal server: If winbind
> decides smbd to be idle it might happen that smbd needs to do a winbind
> operation (for example sid2name) as non-root. This then fails to get the
> privileged pipe. When later on on the same connection another authentication
> request comes in, we try to do the CRAP auth via the non-privileged pipe.
>
> This adds a winbindd_priv_request_response() request that kills the existing
> winbind pipe connection if it's not privileged.

The fix for this was lost during the conversion to libwbclient.

Thanks to Ira Cooper <samba@ira.wakeful.net> for pointing this out!

Volker

diff --git a/source/nsswitch/libwbclient/wbc_idmap.c b/source/nsswitch/libwbclient/wbc_idmap.c
index e32d66cd7136b329358769645c6820c80f129c31..8a6abad819864875a7bd14aab7515bbc75a41047 100644 (file)
--- a/source/nsswitch/libwbclient/wbc_idmap.c
+++ b/source/nsswitch/libwbclient/wbc_idmap.c
@@ -223,8 +223,8 @@ wbcErr wbcAllocateUid(uid_t *puid)
 
        /* Make request */
 
-       wbc_status = wbcRequestResponse(WINBINDD_ALLOCATE_UID,
-                                          &request, &response);
+       wbc_status = wbcRequestResponsePriv(WINBINDD_ALLOCATE_UID,
+                                           &request, &response);
        BAIL_ON_WBC_ERROR(wbc_status);
 
        /* Copy out result */
@@ -259,8 +259,8 @@ wbcErr wbcAllocateGid(gid_t *pgid)
 
        /* Make request */
 
-       wbc_status = wbcRequestResponse(WINBINDD_ALLOCATE_GID,
-                                          &request, &response);
+       wbc_status = wbcRequestResponsePriv(WINBINDD_ALLOCATE_GID,
+                                           &request, &response);
        BAIL_ON_WBC_ERROR(wbc_status);
 
        /* Copy out result */
@@ -311,8 +311,8 @@ wbcErr wbcSetUidMapping(uid_t uid, const struct wbcDomainSid *sid)
                sizeof(request.data.dual_idmapset.sid)-1);
        wbcFreeMemory(sid_string);
 
-       wbc_status = wbcRequestResponse(WINBINDD_SET_MAPPING,
-                                       &request, &response);
+       wbc_status = wbcRequestResponsePriv(WINBINDD_SET_MAPPING,
+                                           &request, &response);
        BAIL_ON_WBC_ERROR(wbc_status);
 
  done:
@@ -354,8 +354,8 @@ wbcErr wbcSetGidMapping(gid_t gid, const struct wbcDomainSid *sid)
                sizeof(request.data.dual_idmapset.sid)-1);
        wbcFreeMemory(sid_string);
 
-       wbc_status = wbcRequestResponse(WINBINDD_SET_MAPPING,
-                                       &request, &response);
+       wbc_status = wbcRequestResponsePriv(WINBINDD_SET_MAPPING,
+                                           &request, &response);
        BAIL_ON_WBC_ERROR(wbc_status);
 
  done:
@@ -384,8 +384,8 @@ wbcErr wbcSetUidHwm(uid_t uid_hwm)
        request.data.dual_idmapset.id = uid_hwm;
        request.data.dual_idmapset.type = _ID_TYPE_UID;
 
-       wbc_status = wbcRequestResponse(WINBINDD_SET_HWM,
-                                       &request, &response);
+       wbc_status = wbcRequestResponsePriv(WINBINDD_SET_HWM,
+                                           &request, &response);
        BAIL_ON_WBC_ERROR(wbc_status);
 
  done:
@@ -414,8 +414,8 @@ wbcErr wbcSetGidHwm(gid_t gid_hwm)
        request.data.dual_idmapset.id = gid_hwm;
        request.data.dual_idmapset.type = _ID_TYPE_GID;
 
-       wbc_status = wbcRequestResponse(WINBINDD_SET_HWM,
-                                       &request, &response);
+       wbc_status = wbcRequestResponsePriv(WINBINDD_SET_HWM,
+                                           &request, &response);
        BAIL_ON_WBC_ERROR(wbc_status);
 
  done:

diff --git a/source/nsswitch/libwbclient/wbc_pam.c b/source/nsswitch/libwbclient/wbc_pam.c
index 8f1df165dedc97cac33bb689b4569959bd7abc18..03931b6c19e1d3711ec4564d02855d76404535c6 100644 (file)
--- a/source/nsswitch/libwbclient/wbc_pam.c
+++ b/source/nsswitch/libwbclient/wbc_pam.c
@@ -401,9 +401,12 @@ wbcErr wbcAuthenticateUserEx(const struct wbcAuthUserParams *params,
                BAIL_ON_WBC_ERROR(wbc_status);
        }
 
-       wbc_status = wbcRequestResponse(cmd,
-                                       &request,
-                                       &response);
+       if (cmd == WINBINDD_PAM_AUTH_CRAP) {
+               wbc_status = wbcRequestResponsePriv(cmd, &request, &response);
+       } else {
+               wbc_status = wbcRequestResponse(cmd, &request, &response);
+       }
+
        if (response.data.auth.nt_status != 0) {
                if (error) {
                        wbc_status = wbc_create_error_info(NULL,
@@ -464,9 +467,8 @@ wbcErr wbcCheckTrustCredentials(const char *domain,
 
        /* Send request */
 
-       wbc_status = wbcRequestResponse(WINBINDD_CHECK_MACHACC,
-                                       &request,
-                                       &response);
+       wbc_status = wbcRequestResponsePriv(WINBINDD_CHECK_MACHACC,
+                                           &request, &response);
        if (response.data.auth.nt_status != 0) {
                if (error) {
                        wbc_status = wbc_create_error_info(NULL,

diff --git a/source/nsswitch/libwbclient/wbclient.c b/source/nsswitch/libwbclient/wbclient.c
index 215b61e960a2092b41dc0e2c474a5162237ef92d..0d174d75402e5a2dab5826eaa433be4c428d0d5b 100644 (file)
--- a/source/nsswitch/libwbclient/wbclient.c
+++ b/source/nsswitch/libwbclient/wbclient.c
@@ -29,6 +29,9 @@
 NSS_STATUS winbindd_request_response(int req_type,
                                     struct winbindd_request *request,
                                     struct winbindd_response *response);
+NSS_STATUS winbindd_priv_request_response(int req_type,
+                                         struct winbindd_request *request,
+                                         struct winbindd_response *response);
 
 /** @brief Wrapper around Winbind's send/receive API call
  *
@@ -52,16 +55,20 @@ NSS_STATUS winbindd_request_response(int req_type,
  --Volker
 **********************************************************************/
 
-wbcErr wbcRequestResponse(int cmd,
-                         struct winbindd_request *request,
-                         struct winbindd_response *response)
+static wbcErr wbcRequestResponseInt(
+       int cmd,
+       struct winbindd_request *request,
+       struct winbindd_response *response,
+       NSS_STATUS (*fn)(int req_type,
+                        struct winbindd_request *request,
+                        struct winbindd_response *response))
 {
        wbcErr wbc_status = WBC_ERR_UNKNOWN_FAILURE;
        NSS_STATUS nss_status;
 
        /* for some calls the request and/or response cna be NULL */
 
-       nss_status = winbindd_request_response(cmd, request, response);
+       nss_status = fn(cmd, request, response);
 
        switch (nss_status) {
        case NSS_STATUS_SUCCESS:
@@ -81,6 +88,22 @@ wbcErr wbcRequestResponse(int cmd,
        return wbc_status;
 }
 
+wbcErr wbcRequestResponse(int cmd,
+                         struct winbindd_request *request,
+                         struct winbindd_response *response)
+{
+       return wbcRequestResponseInt(cmd, request, response,
+                                    winbindd_request_response);
+}
+
+wbcErr wbcRequestResponsePriv(int cmd,
+                             struct winbindd_request *request,
+                             struct winbindd_response *response)
+{
+       return wbcRequestResponseInt(cmd, request, response,
+                                    winbindd_priv_request_response);
+}
+
 /** @brief Translate an error value into a string
  *
  * @param error

diff --git a/source/nsswitch/libwbclient/wbclient_internal.h b/source/nsswitch/libwbclient/wbclient_internal.h
index fc03c5409b41ff51ef0a5b4529b877ae66b14a01..a8967baaaccf294f9491b5767366019812cd2783 100644 (file)
--- a/source/nsswitch/libwbclient/wbclient_internal.h
+++ b/source/nsswitch/libwbclient/wbclient_internal.h
@@ -27,6 +27,9 @@
 wbcErr wbcRequestResponse(int cmd,
                          struct winbindd_request *request,
                          struct winbindd_response *response);
+wbcErr wbcRequestResponsePriv(int cmd,
+                             struct winbindd_request *request,
+                             struct winbindd_response *response);
 
 
 #endif      /* _WBCLIENT_INTERNAL_H */