Stefan Metzmacher [Tue, 30 Jun 2009 14:03:11 +0000 (16:03 +0200)]
s3:util: let parent_dirname() correctly return toplevel filenames
metze
Volker Lendecke [Thu, 30 Apr 2009 10:24:51 +0000 (12:24 +0200)]
Fix notify_onelevel: notify is not necessarily enabled
Thanks to Günther Deschner!
Volker
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Tue, 14 Apr 2009 18:39:14 +0000 (20:39 +0200)]
Add notify_onelevel.tdb
This optimizes non-recursive notifys. For non-recursive notifies we can use a
per-directory file-id indexed notify record. This matters for the Windows
Explorer and IIS cases which do not use recursive notifies. In these cases, we
do not have to shuffle around the whole notify record on every change.
For the cluster case, this improves correctness of the notifies, ctdb only
distributes the tdb seqnum once a second, so we can lose notifies.
Volker Lendecke [Tue, 14 Apr 2009 12:56:35 +0000 (14:56 +0200)]
Rename notify_context->db to db_recursive
Steven Danneman [Fri, 20 Feb 2009 21:23:53 +0000 (13:23 -0800)]
s3: Modifications to generic notify structures to allow implementation of OneFS notify.
The OneFS kernel based change notify system takes an fd of the directory
to watch in it's initialization syscall. Since we already have this
directory open, this commit plumbs that fd down to the VFS layer via the
notify_entry struct.
We also need to know if the watch is taken out on a snapshot directory.
The full file_id struct is also passed down to make this determination.
The file_id marshalling wrappers are hand written here, but should
eventually be auto-generated by moving the struct file_id into the idl.
Volker Lendecke [Mon, 4 May 2009 12:39:56 +0000 (14:39 +0200)]
Do not crash in ctdbd_traverse if ctdbd is not around
Signed-off-by: Michael Adam <obnox@samba.org>
Christian Ambach [Thu, 9 Jul 2009 12:45:23 +0000 (14:45 +0200)]
reject ACLs with DESC_DACL_PROTECTED on GPFS
as GPFS does not support the ACE4_FLAG_NO_PROPAGATE NFSv4 flag (which would be the mapping for the DESC_DACL_PROTECTED flag), the status of this flag is currently silently ignored by Samba. That means that if you deselect the "Allow inheritable permissions..." checkbox in Windows' ACL dialog and then apply the ACL, the flag will be back immediately.
To make sure that automatic migration with e.g. robocopy does not lead to ACLs silently (and unintentionally) changed, this patch adds an explicit check for this flag and if set, it will return NT_STATUS_NOT_SUPPORTED so errors are shown up on the Windows side and the Administrator is aware of the ACLs not being settable like intended
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Volker Lendecke [Tue, 30 Jun 2009 12:26:32 +0000 (14:26 +0200)]
shadow_copy2: The system getrealfilename() can't deal with a 0-length fname
This fixes viewing the content of snapshots in the share root directory. We
have to treat the filename that *just* consists of "@GMT-YYYY.MM.DD-HH.MM.SS"
like the share root, which is the current working directory.
Christian Ambach [Tue, 21 Jul 2009 11:56:17 +0000 (13:56 +0200)]
do not log chdir with level 0 if reason is access denied
this changes the level of logs caused by users trying to access shares
or subdirectories for which they do not have access to in the ACL
this can fill up the samba log even with log level 0 and is more an
expected kind of logs that IMHO should not be logged with such a high
level.
All other errors while chdir() will still be logged with level 0
Signed-off-by: Christian Ambach <christian.ambach@de.ibm.com>
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 27 May 2009 17:25:44 +0000 (19:25 +0200)]
s3:idmap_ldap: filter out of range mappings in default idmap config
This fixes bug #6417
Michael
(cherry picked from commit
e381c13b023f2b512b3f6aec133db9f323bc8132)
Michael Adam [Wed, 27 May 2009 17:24:03 +0000 (19:24 +0200)]
s3:idmap_tdb2: filter out of range mappings in default idmap config
This fixes bug #6416
Michael
(cherry picked from commit
e12670a1053edf57af137026bd3fdb9fc7dfb0b2)
Michael Adam [Wed, 27 May 2009 17:12:28 +0000 (19:12 +0200)]
s3:idmap_tdb: filter out of range mappings in default idmap config
This fixes bug #6415
Michael
(cherry picked from commit
3d3f39838261ddc401053dadcc5bd8e6317a3a8e)
Kai Blin [Mon, 12 May 2008 12:39:03 +0000 (14:39 +0200)]
configure: Kill linker warnings about 32bit libs on 64bit Linux.
(cherry picked from commit
4f01af6efd6a483b85638141b7f726835e9835ea)
Michael Adam [Wed, 20 May 2009 23:40:06 +0000 (01:40 +0200)]
v3-2-ctdb: Bump the ctdb vendor patch to 62 for the next release
Michael
Volker Lendecke [Mon, 18 May 2009 04:18:57 +0000 (06:18 +0200)]
Use SMB_VFS_NEXT_CLOSE. This VFS stuff is really opaque to me...
Volker Lendecke [Mon, 18 May 2009 04:02:07 +0000 (06:02 +0200)]
Fix bug disclosed by lock8 torture test
We have to drop the gpfs level share modes, regardless of whether we put
the file into the pending close queue.
Volker Lendecke [Wed, 8 Apr 2009 06:29:23 +0000 (08:29 +0200)]
We have to deny a level 2 oplock if kernel oplocks are enabled
The second r/o opener of a file is supposed to get a level2 oplock. The first
opener due to the protection in process_oplock_break_message() has been forced
to break to no oplock. The second opener according to locking.tdb gets a level2
oplock. Further down in open_file_ntcreate we try to set this level2 oplock in
the kernel, and the non-clustered Linux kernel disallows this. The rules for
the kernel leases are a bit baroque, but the attempt to do the SETLEASE
correctly fails and we end up with no oplock for any client.
In the clustered case however the linux kernel on the second opening node has
not seen the open fd of the first node, it is only the cluster fs that has this
information. If the cluster fs does not have the very same notion of leases as
the local kernel has, we can end up with a WRLCK style kernel lease for the
second opener where locking.tdb only indicates a level2 oplock. Getting a
kernel oplock break signal with just a level2 oplock in locking.tdb is
something smbd is not prepared for. For example after sending out the break in
response to the kernel signal we set a timeout, waiting for a reply.
More work needs to be done to make level2 kernel oplocks real for us. This
patch addresses a real problem we have right now without them.
Volker Lendecke [Mon, 18 May 2009 11:30:16 +0000 (13:30 +0200)]
Move down the become_root()/unbecome_root() calls into the VFS modules
The aio_fork module does not need this, as it does not communicate via signals
but with pipes. Watching a strace log with those become_root() calls in aio.c
is absolutely awful, and it does affect performance.
Volker Lendecke [Mon, 18 May 2009 07:49:23 +0000 (09:49 +0200)]
In aio_fork, we have to close all fd's, we might hold a gpfs share mode
Keeping such an fd open prohibits another open of that same file.
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Mon, 18 May 2009 07:46:05 +0000 (09:46 +0200)]
Add "file_walk_table" to do stuff with all open files
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Mon, 18 May 2009 07:36:16 +0000 (09:36 +0200)]
Fix a race condition in vfs_aio_fork with gpfs share modes
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Thu, 14 May 2009 23:48:55 +0000 (01:48 +0200)]
s3:first cut at dbwrap_tool - a tdb tool that is CTDB-aware.
This tool (in contrast to tdbtool) reads Samba's configuration
and if clustering = yes, it talks to CTDB instead of accessing
the TDB data bases directly. This is done by simply using
the dbwrap mechanim, just like the Samba daemons.
This first version can read and write int32 and uint32 values
and delete records from a (c)tdb database.
More operations will follow.
This tool can already be useful in CTDB environments, e.g. when
"net idmap restore" fails to set the USER and GROUP HWM keys,
because the methods are deliberately not implemented in
idmap_tdb2.c. You can manually set the high water marks
with
"dbwrap_tool store idmap_tdb2.tdb 'USER HWM' int32 12345"
and
"dbwrap_tool store idmap_tdb2.tdb 'GROUP HWM' int32 67890"
Michael
Michael Adam [Sun, 17 May 2009 20:15:02 +0000 (22:15 +0200)]
s3:fix bug #6371, unsuccessful net conf setparm leaves empty share
Wrap creation of share and setting of parameter into a transaction.
Michael
Michael Adam [Mon, 18 May 2009 08:56:51 +0000 (10:56 +0200)]
Michael Adam v3-2-ctdb: Bump the ctdb vendor patch to 61 for the next release
Michael
Michael Adam [Fri, 8 May 2009 13:14:33 +0000 (15:14 +0200)]
s3:smbd: fix the fix for mapped IPv4 address handling in release_ip().
It was too late... Thanks Metze for noticing.
Michael
Michael Adam [Fri, 8 May 2009 09:22:59 +0000 (11:22 +0200)]
net groupfilter: fix an unused variable warning.
Michael
Jeremy Allison [Thu, 19 Feb 2009 21:11:36 +0000 (13:11 -0800)]
Fix printf type warning. Jeremy.
Michael Adam [Thu, 7 May 2009 23:11:43 +0000 (01:11 +0200)]
s3: make release_ip() call (ctdb) cope with IPv4 mapped addresses
Michael
Volker Lendecke [Wed, 15 Apr 2009 11:01:09 +0000 (13:01 +0200)]
Do not use the file system GET_REAL_FILENAME for mangled names
Volker Lendecke [Mon, 27 Apr 2009 14:59:01 +0000 (16:59 +0200)]
Revert "Do not use the file system GET_REAL_FILENAME for mangled names"
This reverts commit
5589d41d4ca1ad7db0227a1e7777e59c965b6c7c.
Michael Adam [Wed, 6 May 2009 00:08:33 +0000 (02:08 +0200)]
s3:loadparm: handle registry config source in file_list - fixes bug #6320
I.e. does not require smbd restart after changing share default options
in the global registry section with "include = registry".
Michael
Michael Adam [Tue, 28 Apr 2009 23:49:53 +0000 (01:49 +0200)]
s3:smbd/service: switch load_registry_service/shares to use loadparm routines
instead of reading the registry directly with tdb and activating the
configure options by hand.
This eliminates the need for repeating checks done in loadparm.
For instance it disables registry shares without path in the server
as is the case with text based shares.
Michael
(cherry picked from commit
077bcc11257697b243916fbb02cd72b3a122b9ba)
Michael Adam [Tue, 28 Apr 2009 23:31:03 +0000 (01:31 +0200)]
s3:loadparm: refactor process_registry_service out or process_registry_globals
Michael
(cherry picked from commit
fb3b6576127ce837ac711e87c293d1f4cf97473c)
Michael Adam [Wed, 24 Sep 2008 18:31:39 +0000 (20:31 +0200)]
loadparm: rename process_registry_service() to process_smbconf_service().
There is nothing registry-specific in that function.
Michael
Michael Adam [Tue, 28 Apr 2009 13:52:44 +0000 (15:52 +0200)]
pm_process():raise level of debug message
Michael
Michael Adam [Mon, 27 Apr 2009 16:10:14 +0000 (18:10 +0200)]
s3:loadparm: prevent infinite include nesting.
This introduces a hard coded MAX_INCLUDE_DEPTH of 100.
When this is exceeded, handle_include (and hence lp_load) fails.
One could of course implement a more intelligent loop detection
in the include-tree, but this would require some restructuring
of the internal loadparm housekeeping. Maybe as a second improvement
step.
Michael
Michael Adam [Mon, 27 Apr 2009 23:24:27 +0000 (01:24 +0200)]
s3:mark registry shares without path unavailable just as with text config
This prevents users from getting access to "/" in misconfigured setups.
Michael
Signed-off-by: Michael Adam <obnox@samba.org>
Volker Lendecke [Tue, 28 Apr 2009 09:16:19 +0000 (11:16 +0200)]
Fix annoying debug messages when no snapshots are used
Not being able to open the shadow copy directory is the same as having no
shadow copy support at all. The VFS module should in this case not log with
debug level 0 and set ENOSYS to indicate "no shadow copies used" to the higher
levels.
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Wed, 22 Apr 2009 21:42:14 +0000 (23:42 +0200)]
v3-2-ctdb: bump ctdb vendor patch level to 60
Michael
Karolin Seeger [Fri, 17 Apr 2009 09:57:41 +0000 (11:57 +0200)]
WHATSNEW: Rewording.
Karolin
Karolin Seeger [Fri, 17 Apr 2009 09:52:02 +0000 (11:52 +0200)]
VERSION: Raise version number upt to 3.2.11.
Karolin
Karolin Seeger [Fri, 17 Apr 2009 08:42:31 +0000 (10:42 +0200)]
WHATSNEW: Update changes since 3.2.10.
Karolin
Jeremy Allison [Thu, 16 Apr 2009 22:14:37 +0000 (15:14 -0700)]
When doing a cli_ulogoff don't invalidate the cnum, invalidate the vuid.
Jeremy.
Jim McDonough [Thu, 16 Apr 2009 14:42:59 +0000 (16:42 +0200)]
Don't look up local user for remote changes, even when root.
Günther Deschner [Wed, 15 Apr 2009 23:42:35 +0000 (01:42 +0200)]
s3-lsa: Fix Bug #6263. Unexpected LookupSids reply crashes XP pre-SP3.
LookupSids needs to bounce back string sids in case of NT_STATUS_NONE_MAPPED.
Guenther
(cherry picked from commit
597be402e40ff880b595ae49a8600b932365cbcb)
Jeremy Allison [Wed, 15 Apr 2009 21:09:32 +0000 (14:09 -0700)]
Fix bug #6089 - Winbind samr_OpenDomain not possible with Samba 3.2.6+
What a difference a name makes... :-). Just because something is missnamed
SA_RIGHT_SAM_OPEN_DOMAIN, when it should actually be SA_RIGHT_SAM_LOOKUP_DOMAIN,
don't automatically use it for a security check in _samr_OpenDomain().
Jeremy.
Guenther Deschner [Mon, 13 Apr 2009 16:44:54 +0000 (09:44 -0700)]
s3-loadparm: Fix resume command typo for "printing = vlp".
Volker Lendecke [Sat, 11 Apr 2009 20:54:06 +0000 (13:54 -0700)]
Fix a memleak in an unlikely error path in change_notify_create()
Jeremy Allison [Fri, 10 Apr 2009 05:46:31 +0000 (22:46 -0700)]
Fix bug #6254 - PUT/GET produces an error in IPv6 to a smb-server(3.3)
has parameter "msdfs root = yes"
This was broken by the refactoring around create_file().
MSDFS pathname processing must be done FIRST.
MSDFS pathnames containing IPv6 addresses can
be confused with NTFS stream names (they contain
":" characters.
Jeremy.
Karolin Seeger [Tue, 7 Apr 2009 18:01:27 +0000 (20:01 +0200)]
s3/popt.h: Fix typo.
This used to be commit
8da2fa36 in master.
Karolin
(cherry picked from commit
3df28fce45ce552df2c0815597fc1808ea08b363)
Karolin Seeger [Tue, 7 Apr 2009 18:00:47 +0000 (20:00 +0200)]
s3/loadparm: Fiy typos.
This used to be commit
44588095 in master.
Karolin
(cherry picked from commit
7648c51afaf844e576935dadc0d66a94e2cad28b)
Karolin Seeger [Tue, 7 Apr 2009 17:58:47 +0000 (19:58 +0200)]
s3/gpo_ldap: Fix typo.
This used to be commit
a103222e in master.
Karolin
(cherry picked from commit
a33677c8a80925965a4023785fc3a221d2ed9585)
Karolin Seeger [Tue, 7 Apr 2009 17:58:14 +0000 (19:58 +0200)]
s3/smbconf_reg: Fix typo.
This used to be commit
6343cab3 in master.
Karolin
(cherry picked from commit
56e877662dd6da64b348803c24e85f60ee6b3d85)
Günther Deschner [Mon, 6 Apr 2009 10:45:46 +0000 (12:45 +0200)]
s3-examples: Fix Bug #6205. Correct sample smb.conf share configuration.
Thanks to Jeffrey Riaboy <dakusan@castledragmire.com>.
Guenther
(cherry picked from commit
2b1fe2c98f4e0013dee4cbae62dc36cdd4085c7d)
Volker Lendecke [Sat, 28 Mar 2009 18:58:45 +0000 (19:58 +0100)]
Fix smbd crash for close_on_completion
handle_trans() can talloc_free "conn" if the client requests
close_on_completion. "state" is a talloc_child of conn, so it will be gone when
we later free state->data et al.
Jeremy Allison [Thu, 2 Apr 2009 03:14:35 +0000 (20:14 -0700)]
Allow pdbedit to change a user rid/sid. Based on a fix from Alexander
Zagrebin <alexz@visp.ru>.
Jeremy.
Volker Lendecke [Wed, 15 Apr 2009 11:01:09 +0000 (13:01 +0200)]
Do not use the file system GET_REAL_FILENAME for mangled names
Michael Adam [Fri, 17 Apr 2009 09:40:17 +0000 (11:40 +0200)]
s3:registry: Prevent creation of keys containing the '/' character.
This creates a broken registry that can only be fixed with
tdbtool, since the '/' sign is used as a key separator after
normalization at a lower level.
This makes e.g. "net conf setparm abc/def comment xyz" fail with
WERR_INVALID_PARAM, which is much more desirable than a broken
registry.tdb.
Michael
Martin Schwenke [Thu, 16 Apr 2009 00:25:29 +0000 (10:25 +1000)]
In net_conf_import, start a transaction when importing a single share.
Commit
d69c3db9d44ad5d9fd1f5d7a9499f3bd79ecfb47 caused the transaction
start to be conditional but the commit is still unconditional, so an
error occurs when importing a single share.
An alternate fix would be to return the transaction start to be
unconditional but then it would occur before other error checking.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Signed-off-by: Michael Adam <obnox@samba.org>
Michael Adam [Thu, 2 Apr 2009 22:17:34 +0000 (00:17 +0200)]
v3-2-ctdb: Bump the ctdb vendor patch to 59 for the next release
Michael
Michael Adam [Wed, 1 Apr 2009 22:23:31 +0000 (00:23 +0200)]
s3:net conf: don't store share names as lower case, but as given.
Michael
Michael Adam [Wed, 1 Apr 2009 22:26:14 +0000 (00:26 +0200)]
fix the build: v3-2-ctdb uses db_open(), not db_open_trans().
Michael
Karolin Seeger [Wed, 1 Apr 2009 11:42:32 +0000 (13:42 +0200)]
WHATSNEW: Rewording.
Karolin
Karolin Seeger [Wed, 1 Apr 2009 11:32:07 +0000 (13:32 +0200)]
VERSION: Raise version number up to 3.2.10.
Karolin
Karolin Seeger [Wed, 1 Apr 2009 11:31:23 +0000 (13:31 +0200)]
WHATSNEW: Prepare WHATSNEW for 3.2.10.
A release a day... ;-)
Karolin
Michael Adam [Wed, 1 Apr 2009 10:23:07 +0000 (12:23 +0200)]
s3: fix the fix for bug #6195 - dont let smbd child processes panic
This patch makes sure the original and temporary TDBs are closed
_before_ the rename. Originally, the open TDB was renamed, and so
the name passdb.tdb.tmp stayed around in the db context. Hence
upon client connect, the smbd children died because reinit_after_fork()
calling tdb_reopen_all() would try to reopen passdb.tdb.tmp which
existed no longer...
Michael
Jeremy Allison [Wed, 1 Apr 2009 01:29:30 +0000 (18:29 -0700)]
Tidy up some convert_string_internal error cases, found by Andrew Bartlett.
Jeremy.
Karolin Seeger [Tue, 31 Mar 2009 14:12:30 +0000 (16:12 +0200)]
WHATSNEW: Fix announcement.
Karolin
Karolin Seeger [Tue, 31 Mar 2009 08:44:20 +0000 (10:44 +0200)]
VERSION: Raise version number up to 3.2.9.
Karolin
(cherry picked from commit
d999a7e99804bf71f62c905452a720c20016f8e9)
Karolin Seeger [Tue, 31 Mar 2009 08:43:47 +0000 (10:43 +0200)]
WHATSNEW: Update changes.
Karolin
(cherry picked from commit
bee6e86c71278563d52f9bde19ffb4bda2a35d1b)
Michael Adam [Tue, 31 Mar 2009 12:10:19 +0000 (14:10 +0200)]
v3-2-ctdb: bump ctdb vendor patch level for next release
Michael
Jeremy Allison [Sat, 28 Mar 2009 04:26:56 +0000 (21:26 -0700)]
Fix the problem of 3.0.x passdb databases being version
3 but using a different hash calculation than 3.2.x passwd
databases (also version 3). Introduces a minor version
number.
Jeremy.
(cherry picked from commit
10b518592e616ecfaadd829ecd0674a04510b422)
Jeremy Allison [Fri, 27 Mar 2009 19:11:24 +0000 (12:11 -0700)]
Fix bug #6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly. For the clustering case.
Clustered setups should have only ever used
the unsigned version of TDB_DATA in the
first place so they can't be in this mess :-).
Just do the normal upgrade in the clustered case.
Jeremy.
(cherry picked from commit
58d3ec1cb81d6086d65cd12acd16cd591cf0c71f)
Jeremy Allison [Wed, 18 Mar 2009 21:31:01 +0000 (14:31 -0700)]
Fix bug 6195 - Migrating from 3.0.x to 3.3.x can fail to update passdb.tdb correctly.
This is a really nasty one to fix as in order to successfully update the
passdb.tdb we must do the equivalent of a tdbbackup to move to the new hash
values before we do the upgrade.
Jeremy.
Jeremy Allison [Mon, 30 Mar 2009 22:09:10 +0000 (15:09 -0700)]
Ensure files starting with multiple dots are hidden
if "hide dot files" is set. Thanks to Barry Kelly <bkelly.ie@gmail.com>
for pointing this one out.
Jeremy.
(cherry picked from commit
5bdc16a867b9c14682b327c79f79834edcd6842d)
Karolin Seeger [Mon, 30 Mar 2009 10:43:17 +0000 (12:43 +0200)]
WHATSNEW: Update changes.
Karolin
(cherry picked from commit
e7634cd0c17d0fa4dcca5952313b6af750477dec)
Derrell Lipman [Fri, 27 Mar 2009 21:10:04 +0000 (17:10 -0400)]
[Bug 6228] SMBC_open_ctx failure due to path resolve failure doesn't set errno
Fixed.
It turns out there were a number of places where cli_resolve_path() was called
and the error path upon that function failing did not set errno. There were a
couple of places the failure handling code did set errno to ENOENT, so I made
them all consistent, although I think better errno choices for this condition
exist, e.g. EHOSTUNREACH.
Derrell
(cherry picked from commit
f4e68b09a6ba30d968bccfad8bf6b67b4456b111)
Karolin Seeger [Fri, 27 Mar 2009 13:04:38 +0000 (14:04 +0100)]
WHATSNEW: Update changes since 3.2.8.
Karolin
(cherry picked from commit
7fa853e490be446a6da2086e1749b59a8f741e09)
Jeremy Allison [Thu, 26 Mar 2009 22:33:39 +0000 (15:33 -0700)]
Try and fix the build farm RAW-STREAMS errors. Ordering of
modules shouldn't matter, so as vfs_streams_depot doesn't
implement get/setxattrs then call into the full VFS stack
at the top.
Jeremy
(cherry picked from commit
a1d9b31a0c8a38dbfa94f578830d5d35695aff3b)
Jeremy Allison [Thu, 26 Mar 2009 19:13:28 +0000 (12:13 -0700)]
Fix bug #6224 - nmbd waits 5 minutes at startup before checking if it needs to run elections
Fix logic bug that causes nmbd to wait 5 minutes before
looking for a master browser. This one is *old* :-). Thanks
for Simo for bugging me on this.
Jeremy.
(cherry picked from commit
857c2e4407a0f4fcee721372ffed5366bc3051f9)
Tim Prouty [Thu, 26 Mar 2009 18:28:37 +0000 (11:28 -0700)]
s3: parse_packet can return NULL which is then dereferenced in match_mailslot_name
(cherry picked from commit
d097e3f918853cf642c4a51f6ed3a4d8c85d283e)
Volker Lendecke [Thu, 26 Mar 2009 11:24:50 +0000 (12:24 +0100)]
Fix a scary "fill_share_mode_lock failed" message
To me "fill_share_mode_lock failed" is a "can't happen" alert. There is
however a perfectly valid case in get_file_infos() when the file is not open.
Change the corresponding debug message to level 10 and explain more.
(cherry picked from commit
f73d4cf1fcfd8f9e2543a222faed133472fd890c)
Günther Deschner [Thu, 26 Mar 2009 09:41:11 +0000 (10:41 +0100)]
s3-net: Fix Bug #6102. NetQueryDisplayInformation could return wrong information.
Guenther
(cherry picked from commit
490ed838f2626893bb623ea6ad8d79595c8c44c4)
Günther Deschner [Wed, 25 Mar 2009 16:06:57 +0000 (17:06 +0100)]
s3-net: Fix Bug #6193: avoid messing with sync_context in fetch_database_to_ldif().
We absolutely need to avoid messing with the sync_context as that breaks the
stream of replication data coming from the DC (only replicates ~350 instead of
~4000 groups).
Guenther
(cherry picked from commit
1a1823c357fb8e01ac0e8c8749e6f5004bf3cf3e)
Volker Lendecke [Tue, 24 Mar 2009 22:34:13 +0000 (15:34 -0700)]
winbind_pam: fix gcc 4.4 compile warning
(cherry picked from commit
4a99f2f006e6324cf38b68f0f390daf52f24b1b3)
Volker Lendecke [Tue, 24 Mar 2009 22:29:35 +0000 (15:29 -0700)]
Fix two memleaks in the encryption code
ntlmssp_seal_packet creates its own signature data blob, which we then
have to free.
Jeremy, please check and merge appropriately (Yes, I'm asking you to do the
janitor work, I want you to *look* at this :-))
Volker
(cherry picked from commit
525af716cd52500a4e3dccf9eeb9ea85f86be7ca)
Stefan Metzmacher [Tue, 24 Mar 2009 18:50:49 +0000 (11:50 -0700)]
s3:smbd: if we allow trans2 on the IPC$ share, then we have to allow transs2 too.
Otherwise we'll confuse the client signing engine, when we reply an error to each transs2.
metze
(cherry picked from commit
e217138a36b1ba1eff164aecfa52ba6fe8864747)
Volker Lendecke [Tue, 24 Mar 2009 10:07:16 +0000 (11:07 +0100)]
Fix bug 6097
A client sent a SID with authority 0 and 0 sub-authorities. W2k3 replies with
NT_STATUS_INVALID_SID, even if other SIDs in the list are valid.
Thanks to Pavel <wylda@volny.cz> for the bug report!
(cherry picked from commit
bb76066e8797599e5ca75821a686e32dd0c97a74)
Björn Jacke [Mon, 23 Mar 2009 11:26:03 +0000 (12:26 +0100)]
s3:dsgetdcname: use parentheses in if condition to make negation clear
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit
87b428e424e2e3cca975ecd0efed327e72950a1d)
(cherry picked from commit
ca58d12b6513beb40c14fcab2758cf21af0179f3)
Günther Deschner [Fri, 20 Mar 2009 10:11:04 +0000 (11:11 +0100)]
s3-krb5: Fix Coverity #762 (REVERSE_INULL).
Guenther
(cherry picked from commit
97190ae184dff6450b1390c854f7426e2ee3f980)
(cherry picked from commit
0f7757e94bfa35d22a7349d78578685c0dba22d7)
(cherry picked from commit
66faa809847ad60b8027ae86068f8d62c0d181ed)
Günther Deschner [Thu, 19 Mar 2009 15:42:54 +0000 (16:42 +0100)]
s3-krb5: Fix Coverity #722 (RESOURCE_LEAK).
Guenther
(cherry picked from commit
1524abd8bf12d82e1fb0063585fc9a465fc7bf9c)
(cherry picked from commit
3517388b5d5439ffe3f9629aaf826fa1dfbb4ba7)
(cherry picked from commit
5ce5a9bea994d7db3d352d0800333d0fd0b833df)
Stefan Metzmacher [Wed, 18 Mar 2009 06:56:51 +0000 (07:56 +0100)]
s3:libsmb: fix smb signing for fragmented trans/trans2/nttrans requests
Before we send the secondary requests we need to remove the
old mid=>seqnum mapping and reset cli->mid and make the new
mid=>seqnum mapping "persistent".
The bug we had in cli_send_trans was this:
The first cli_send_smb() incremented cli->mid
and the secondary requests used the incremented mid,
but as cli->outbuf still had the correct mid,
we send the correct mid to the server. The real problem
was that the cli_send_smb() function stored the seqnum
under the wrong mid.
cli_send_nttrans() was totally broken and now follows the
same logic as cli_send_trans().
The good thing is that in practice the problem is unlikely to happen,
because max_xmit is large enough to avoid secondary requests.
metze
(cherry picked from commit
880fbc4e8cd67de73c4bcda94489eb1e1422a04b)
(cherry picked from commit
70466990b4b7c68ae95dbbcf741cd3f41f2dd0b3)
(cherry picked from commit
d01cca5e3ddb925696d49a1ea728013ec1032372)
(cherry picked from commit
6c13360e195189f7afc70c5fda6ef27f46145b0b)
Björn Jacke [Mon, 16 Mar 2009 00:51:09 +0000 (01:51 +0100)]
fix build on old Heimdal based systems
Signed-off-by: Günther Deschner <gd@samba.org>
(cherry picked from commit
011ad7245d53a716c4c766f5ef8d317bb3a53d0f)
(cherry picked from commit
5eaa2541f19277bc00c47b944739c6732f90809b)
Jeremy Allison [Thu, 19 Mar 2009 03:54:13 +0000 (20:54 -0700)]
Allow DFS client paths to work when POSIX pathnames have been
selected (we need to path in pathname /that/look/like/this).
Jeremy.
(cherry picked from commit
0c11c2deee7ab9d281df6df91b793b7f1c1764a4)
Jeremy Allison [Thu, 19 Mar 2009 02:58:01 +0000 (19:58 -0700)]
Fix bug #6196 - Unable to serve files with colons to Linux CIFS/VFS client
Looks like the pathname parsing for POSIX paths got
broken when the code for doing Windows streams parsing got added.
Jeremy.
(cherry picked from commit
985ba585207e840caa17c3d87d93ef1ba5f15cbb)
Volker Lendecke [Tue, 17 Mar 2009 10:22:41 +0000 (11:22 +0100)]
Fix a valgrind error
Found in "make test" -- if we can't connect at all, "cli" is uninitialized
(cherry picked from commit
8ffe7b07df753568d960155c27d57de2bd99993f)
Volker Lendecke [Mon, 16 Mar 2009 12:17:04 +0000 (13:17 +0100)]
Fix #6130: Don't crash in winbindd_rpc lookup_groupmem() on unmapped members
Thanks to François Legal <devel@thom.fr.eu.org> for reporting this bug
(cherry picked from commit
e6a23d498bfd4bbe19cecf24ba3f94af83c9bf8b)
Volker Lendecke [Sun, 15 Mar 2009 10:58:07 +0000 (11:58 +0100)]
Fix a malloc/talloc mismatch when cli_initialise() fails
(cherry picked from commit
20d378eebfcaca53f456f0fbae39d46031729de7)
Volker Lendecke [Sat, 14 Feb 2009 12:18:28 +0000 (13:18 +0100)]
Don't log NDR_PRINT_DEBUG at level 0, this always ends up in syslog
I think we eventually need to pass down the debuglevel here.
(cherry picked from commit
b2f6110d3ac5d60054a7e5a1d365f0a1f67a2f42)
Volker Lendecke [Tue, 10 Mar 2009 15:08:38 +0000 (16:08 +0100)]
Revert "Revert "Fix a valgrind error / segfault in dns_register_smbd()""
This reverts commit
96c57d26ed790b3e94c935cc4faf5661ea43a80c.
(cherry picked from commit
045933cf5bf27fbb704e446cf8686f2f761a1ced)