Fix bug 8314] - smbd crash with unknown user.
authorJeremy Allison <jra@samba.org>
Fri, 22 Jul 2011 23:40:54 +0000 (16:40 -0700)
committerJeremy Allison <jra@samba.org>
Sat, 23 Jul 2011 00:55:01 +0000 (02:55 +0200)
All other auth modules code with being called with
auth_method->private_data being NULL, make the auth_server
module cope with this too.

Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Sat Jul 23 02:55:01 CEST 2011 on sn-devel-104

source3/auth/auth_server.c

index 3d775c2fc94340dbbf9a9b7366bcb7003c7d299d..f29859945c2ba02004fc5af85767be2376fd67ce 100644 (file)
@@ -272,16 +272,23 @@ static NTSTATUS check_smbserver_security(const struct auth_context *auth_context
                                         const struct auth_usersupplied_info *user_info,
                                         struct auth_serversupplied_info **server_info)
 {
-       struct server_security_state *state = talloc_get_type_abort(
-               my_private_data, struct server_security_state);
-       struct cli_state *cli;
+       struct server_security_state *state = NULL;
+       struct cli_state *cli = NULL;
        static bool tested_password_server = False;
        static bool bad_password_server = False;
        NTSTATUS nt_status = NT_STATUS_NOT_IMPLEMENTED;
        bool locally_made_cli = False;
 
-       DEBUG(10, ("Check auth for: [%s]\n", user_info->mapped.account_name));
+       DEBUG(10, ("check_smbserver_security: Check auth for: [%s]\n",
+               user_info->mapped.account_name));
+
+       if (my_private_data == NULL) {
+               DEBUG(10,("check_smbserver_security: "
+                       "password server is not connected\n"));
+               return NT_STATUS_LOGON_FAILURE;
+       }
 
+       state = talloc_get_type_abort(my_private_data, struct server_security_state);
        cli = state->cli;
 
        if (cli) {