uwrap: Move the EINVAL check down in seteuid()

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/lib/uid_wrapper/uid_wrapper.c b/lib/uid_wrapper/uid_wrapper.c
index e0d84beb7ea7769c611deee085a560d00f61b41b..dd999ffc11453fae59e39b47b320059ad822545b 100644 (file)
--- a/lib/uid_wrapper/uid_wrapper.c
+++ b/lib/uid_wrapper/uid_wrapper.c
@@ -1293,15 +1293,16 @@ int setuid(uid_t uid)
 #ifdef HAVE_SETEUID
 int seteuid(uid_t euid)
 {
+       if (!uid_wrapper_enabled()) {
+               return libc_seteuid(euid);
+       }
+
+       /* On FreeBSD the uid_t -1 is set and doesn't produce and error */
        if (euid == (uid_t)-1) {
                errno = EINVAL;
                return -1;
        }
 
-       if (!uid_wrapper_enabled()) {
-               return libc_seteuid(euid);
-       }
-
        uwrap_init();
        return uwrap_setresuid(-1, euid, -1);
 }