git.samba.org
/
obnox
/
samba
/
samba-obnox.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
eddf0d0
)
s4:libcli/finddcs_nbt.c - free "req" consistently with "finddcs_cldap.c"
author
Matthias Dieter Wallnöfer
<mdw@samba.org>
Thu, 22 Dec 2011 15:49:48 +0000
(16:49 +0100)
committer
Stefan Metzmacher
<metze@samba.org>
Fri, 23 Dec 2011 09:36:19 +0000
(10:36 +0100)
It is more obvious to free where the context for the first time appears.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
source4/libcli/finddcs_nbt.c
patch
|
blob
|
history
diff --git
a/source4/libcli/finddcs_nbt.c
b/source4/libcli/finddcs_nbt.c
index 9579a9e449f4747846fa7d8784a731f2301de1a5..6a5d1fd8563e1e14faf69aefff9451c83b668cc8 100644
(file)
--- a/
source4/libcli/finddcs_nbt.c
+++ b/
source4/libcli/finddcs_nbt.c
@@
-284,7
+284,6
@@
NTSTATUS finddcs_nbt_recv(struct tevent_req *req, TALLOC_CTX *mem_ctx,
*num_dcs = state->num_dcs;
*dcs = talloc_steal(mem_ctx, state->dcs);
}
- talloc_free(req);
return status;
}
@@
-298,6
+297,7
@@
NTSTATUS finddcs_nbt(TALLOC_CTX *mem_ctx,
struct imessaging_context *msg_ctx,
int *num_dcs, struct nbt_dc_name **dcs)
{
+ NTSTATUS status;
struct tevent_req *req = finddcs_nbt_send(mem_ctx,
my_netbios_name,
nbt_port,
@@
-305,5
+305,7
@@
NTSTATUS finddcs_nbt(TALLOC_CTX *mem_ctx,
domain_sid,
resolve_ctx,
event_ctx, msg_ctx);
- return finddcs_nbt_recv(req, mem_ctx, num_dcs, dcs);
+ status = finddcs_nbt_recv(req, mem_ctx, num_dcs, dcs);
+ talloc_free(req);
+ return status;
}