winbind: Properly error check init_lsa_ref_domain_list

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Uri Simchoni <uri@samba.org>

diff --git a/source3/winbindd/wb_sids2xids.c b/source3/winbindd/wb_sids2xids.c
index e3962de269b5079f55ff01ebb71859d185785ee3..940a06bd1c0cd4c329554b2e6020a382a272a758 100644 (file)
--- a/source3/winbindd/wb_sids2xids.c
+++ b/source3/winbindd/wb_sids2xids.c
@@ -184,16 +184,22 @@ static void wb_sids2xids_lookupsids_done(struct tevent_req *subreq)
                struct lsa_DomainInfo *info;
                struct lsa_TranslatedName *n = &names->names[i];
                struct wbint_TransID *t = &state->ids.ids[i];
+               int domain_index;
 
                sid_copy(&dom_sid, &state->non_cached[i]);
                sid_split_rid(&dom_sid, &t->rid);
 
                info = &domains->domains[n->sid_index];
                t->type = lsa_SidType_to_id_type(n->sid_type);
-               t->domain_index = init_lsa_ref_domain_list(state,
-                                                          state->idmap_doms,
-                                                          info->name.string,
-                                                          &dom_sid);
+
+               domain_index = init_lsa_ref_domain_list(
+                       state, state->idmap_doms, info->name.string, &dom_sid);
+               if (domain_index == -1) {
+                       tevent_req_oom(req);
+                       return;
+               }
+               t->domain_index = domain_index;
+
                t->xid.id = UINT32_MAX;
                t->xid.type = t->type;
        }