tdb/test: TDB_CLEAR_IF_FIRST | TDB_MUTEX_LOCKING, O_RDONLY is a valid combination

This used to be invalid in the early developement code, but now we're
able to open a tdb with mutex area and TDB_NOLOCK without problems.
O_RDONLY implies TDB_NOLOCK...

This should have been part of commit c8d05e934ea03fffbc34944d2d51a016b89a7eca.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=10781

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>

diff --git a/lib/tdb/test/run-mutex-openflags2.c b/lib/tdb/test/run-mutex-openflags2.c
index 57ac7e37993de8311f00e2fd9012dd9af391db2f..6522ae42faa33c06af5a925590a3581d95f5b9ef 100644 (file)
--- a/lib/tdb/test/run-mutex-openflags2.c
+++ b/lib/tdb/test/run-mutex-openflags2.c
@@ -75,8 +75,9 @@ static int do_child(int fd)
                          TDB_CLEAR_IF_FIRST |
                          TDB_MUTEX_LOCKING,
                          O_RDONLY, 0755, &nolog_ctx, NULL);
-       ok((tdb == NULL) && (errno == EINVAL), "TDB_MUTEX_LOCKING with "
-          "O_RDONLY should fail with EINVAL - %d", errno);
+       ok((tdb != NULL), "TDB_MUTEX_LOCKING with "
+          "O_RDONLY should work - %d", errno);
+       tdb_close(tdb);
 
        tdb = tdb_open_ex("mutex-openflags2.tdb", 0,
                          TDB_CLEAR_IF_FIRST |