ctdb-server: fix a possible fd leak in ctdb_tcp_listen_automatic()

sockets are created in a loop until an unused address is found.
But the unused socket fds were not closed.

Signed-off-by: Michael Adam <obnox@samba.org>
Reviewed-by: Martin Schwenke <martin@meltin.net>

diff --git a/ctdb/tcp/tcp_connect.c b/ctdb/tcp/tcp_connect.c
index b106f22c86fa51dae72428e03696f3a8881fd29c..277eb375ba9c61df586915ace9e7c926a7680b64 100644 (file)
--- a/ctdb/tcp/tcp_connect.c
+++ b/ctdb/tcp/tcp_connect.c
@@ -338,6 +338,8 @@ static int ctdb_tcp_listen_automatic(struct ctdb_context *ctdb)
                        DEBUG(DEBUG_ERR,(__location__ " Failed to bind() to socket. %s(%d)\n",
                                        strerror(errno), errno));
                }
+
+               close(ctcp->listen_fd);
        }
 
        if (i == ctdb->num_nodes) {