s4-torture: make sure to always seal the clusapi connection in witness test.

clusapi only works via DCE/RPC sealed connections in Windows 2012R2.

Guenther

Signed-off-by: Günther Deschner <gd@samba.org>
Reviewed-by: Jose A. Rivera <jarrpa@samba.org>

diff --git a/source4/torture/rpc/witness.c b/source4/torture/rpc/witness.c
index 9e56b18866bb8b4910d01934c83066398fbfe527..6f50a637543efd6cbc41d673620a7e7634e0e755 100644 (file)
--- a/source4/torture/rpc/witness.c
+++ b/source4/torture/rpc/witness.c
@@ -26,6 +26,7 @@
 #include "librpc/gen_ndr/ndr_clusapi_c.h"
 #include "param/param.h"
 #include <tevent.h>
+#include "lib/cmdline/popt_common.h"
 
 struct torture_test_clusapi_state {
        struct dcerpc_pipe *p;
@@ -516,17 +517,30 @@ static bool test_witness_RegisterEx(struct torture_context *tctx,
 static bool setup_clusapi_connection(struct torture_context *tctx,
                                     struct torture_test_witness_state *s)
 {
-       NTSTATUS status;
+       struct dcerpc_binding *binding;
 
        if (s->clusapi.p) {
                return true;
        }
 
-       status = torture_rpc_connection_transport(tctx, &s->clusapi.p, &ndr_table_clusapi, NCACN_IP_TCP, 0);
-       if (!NT_STATUS_IS_OK(status)) {
-               torture_comment(tctx, "clusapi interface not available\n");
-               return true;
-       }
+       torture_assert_ntstatus_ok(tctx,
+               torture_rpc_binding(tctx, &binding),
+               "failed to retrieve torture binding");
+
+       torture_assert_ntstatus_ok(tctx,
+               dcerpc_binding_set_transport(binding, NCACN_IP_TCP),
+               "failed to set transport");
+
+       torture_assert_ntstatus_ok(tctx,
+               dcerpc_binding_set_flags(binding, DCERPC_SEAL, 0),
+               "failed to set dcerpc flags");
+
+       torture_assert_ntstatus_ok(tctx,
+               dcerpc_pipe_connect_b(tctx, &s->clusapi.p, binding,
+                                     &ndr_table_clusapi,
+                                     cmdline_credentials,
+                                     tctx->ev, tctx->lp_ctx),
+               "failed to connect dcerpc pipe");
 
        return true;
 }