Fix uninitialized memory problem in group_sids_to_info3 (fixes bug #8455).
authorWilco Baan Hofman <wilco@baanhofman.nl>
Mon, 17 Oct 2011 19:24:41 +0000 (21:24 +0200)
committerJeremy Allison <jra@samba.org>
Mon, 17 Oct 2011 21:32:58 +0000 (23:32 +0200)
Autobuild-User: Jeremy Allison <jra@samba.org>
Autobuild-Date: Mon Oct 17 23:32:58 CEST 2011 on sn-devel-104

source3/auth/server_info.c

index fd2101024fffd019f8f908fd7baaf723c35c9550..5b2706a28a2e4d15b8ad4e5ef490f2accff5334f 100644 (file)
@@ -269,8 +269,8 @@ static NTSTATUS group_sids_to_info3(struct netr_SamInfo3 *info3,
                        if (info3->base.primary_gid == rid) continue;
 
                        /* store domain group rid */
-                       groups->rids[i].rid = rid;
-                       groups->rids[i].attributes = attributes;
+                       groups->rids[groups->count].rid = rid;
+                       groups->rids[groups->count].attributes = attributes;
                        groups->count++;
                        continue;
                }