build: Remove configure checks for ctdb headers
authorAmitay Isaacs <amitay@gmail.com>
Fri, 10 Oct 2014 03:25:34 +0000 (14:25 +1100)
committerAmitay Isaacs <amitay@samba.org>
Tue, 28 Oct 2014 04:42:04 +0000 (05:42 +0100)
Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Reviewed-by: Michael Adam <obnox@samba.org>
source3/lib/cluster_support.c
source3/lib/ctdb_conn.c
source3/torture/test_ctdbconn.c
source3/wscript

index afe22609170cfd1dd625b201e954f8759ab7462a..6a5f91d1d379bafb2969c0450c31835631d63139 100644 (file)
 #include <tdb.h>
 #include "cluster_support.h"
 
-#ifdef HAVE_CTDB_H
+#ifdef CLUSTER_SUPPORT
 #include <ctdb.h>
-#define CLUSTER_SUPPORT 1
-#endif
-
-#ifdef HAVE_CTDB_PROTOCOL_H
 #include <ctdb_protocol.h>
-#else
-#ifdef HAVE_CTDB_PRIVATE_H
 #include <ctdb_private.h>
 #endif
-#endif
 
 bool cluster_support_available(void)
 {
@@ -53,15 +46,6 @@ const char *cluster_support_features(void)
 #else
        "   NONE\n"
 #endif
-#ifdef HAVE_CTDB_H
-       _LINE_DEF(HAVE_CTDB_H)
-#endif
-#ifdef HAVE_CTDB_PRIVATE_H
-       _LINE_DEF(HAVE_CTDB_PRIVATE_H)
-#endif
-#ifdef HAVE_CTDB_PROTOCOL_H
-       _LINE_DEF(HAVE_CTDB_PROTOCOL_H)
-#endif
 #ifdef CTDB_SOCKET
        _LINE_STR(CTDB_SOCKET)
 #endif
index 09965118d5dbab46ebfcc57c816832fba7839c17..1bba8e7e82d44ee80d863c8334ed26ac4a67baf7 100644 (file)
 
 #include <tdb.h>
 
-#ifdef HAVE_CTDB_PROTOCOL_H
 #include <ctdb_protocol.h>
-#else
-#include <ctdb_private.h>
-#endif
 
 #include "lib/async_req/async_sock.h"
 
index ff45a022d3334b1c0e033b40f79bea064203ca2a..1f80cff5fdfaec2f74797d5b18a6f5a5924fa633 100644 (file)
 #include "lib/util/tevent_unix.h"
 #include "tdb.h"
 
-#ifdef HAVE_CTDB_PROTOCOL_H
 #include "ctdb_protocol.h"
-#else
-#include "ctdb_private.h"
-#endif
 
 #include "messages.h"
 
index bac488cf1ae34124bb9f6b13cb2034a62bca250b..01c9c351421e708c4c93a277914c8d84a207f7d5 100644 (file)
@@ -1488,89 +1488,9 @@ main() {
         if not conf.env.USING_SYSTEM_TALLOC:
             includes = includes + ' ' + srcdir + '/lib/talloc'
 
-        ok = conf.CHECK_CODE('''
-            #define NO_CONFIG_H
-            #include "replace.h"
-            #include "system/wait.h"
-            #include "system/network.h"
-            #define private #error __USED_RESERVED_WORD_private__
-            #include <talloc.h>
-            #include <tdb.h>
-            #include <ctdb.h>
-
-            int main(void)
-            {
-                return 0;
-            }
-            ''',
-            'HAVE_CTDB_CHECK_CODE',
-            addmain=False,
-            includes=includes,
-            msg='Checking for header ctdb.h')
-        if ok:
-            CTDB_CFLAGS += ' -DHAVE_CTDB_H=1'
-        else:
-            have_cluster_support = False
-            ctdb_broken = "ctdb.h is required for cluster support"
-
-        conf.CONFIG_RESET('HAVE_CTDB_CHECK_CODE')
-        if have_cluster_support:
-            ok = conf.CHECK_CODE('''
-                #define NO_CONFIG_H
-                #include "replace.h"
-                #include "system/wait.h"
-                #include "system/network.h"
-                #define private #error __USED_RESERVED_WORD_private__
-                #include <talloc.h>
-                #include <tdb.h>
-                #include <ctdb.h>
-                #include <ctdb_private.h>
-
-                int main(void)
-                {
-                    return 0;
-                }
-                ''',
-                'HAVE_CTDB_CHECK_CODE',
-                addmain=False,
-                includes=includes,
-                msg='Checking for header ctdb_private.h')
-            if ok:
-                CTDB_CFLAGS += ' -DHAVE_CTDB_PRIVATE_H=1'
-            else:
-                have_cluster_support = False
-                ctdb_broken = "ctdb_private.h is required for cluster support"
-
-        conf.CONFIG_RESET('HAVE_CTDB_CHECK_CODE')
-        if have_cluster_support:
-            ok = conf.CHECK_CODE('''
-                #define NO_CONFIG_H
-                #include "replace.h"
-                #include "system/wait.h"
-                #include "system/network.h"
-                #define private #error __USED_RESERVED_WORD_private__
-                #include <talloc.h>
-                #include <tdb.h>
-                #include <ctdb.h>
-                #include <ctdb_protocol.h>
-
-                int main(void)
-                {
-                    return 0;
-                }
-                ''',
-                'HAVE_CTDB_CHECK_CODE',
-                addmain=False,
-                includes=includes,
-                msg='Checking for header ctdb_protocol.h')
-            if ok:
-                CTDB_CFLAGS += ' -DHAVE_CTDB_PROTOCOL_H=1'
-
-    conf.CONFIG_RESET('HAVE_CTDB_CHECK_CODE')
-    conf.undefine('HAVE_CTDB_CHECK_CODE')
     if have_cluster_support:
         Logs.info("building with cluster support")
-        conf.env['CTDB_CFLAGS'] = CTDB_CFLAGS
+        conf.env['CTDB_CFLAGS'] = '-DCLUSTER_SUPPORT=1'
         conf.env['CTDB_INCLUDE'] = CTDB_INCLUDE
     else:
         if Options.options.with_cluster_support == False: