Sachin Prabhu [Thu, 13 Sep 2018 12:14:07 +0000 (13:14 +0100)]
s4-testing: remove tcp port blocking from multichannel testing
Remove dependencies on iptables for multichannel break handler testing.
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Thu, 13 Sep 2018 11:39:03 +0000 (12:39 +0100)]
s4-torture: Add handlers to ignore incoming oplock/lease break requests
For use in multichannel oplock break tests. These handers ignore
incoming oplock and lease break requests so that we can test the
oplock/lease break retries on the server.
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Tue, 17 Jul 2018 23:11:59 +0000 (00:11 +0100)]
Fix debug comments for torture/smb2/multichannel
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Tue, 17 Jul 2018 21:28:46 +0000 (22:28 +0100)]
Do not disconnect channel when test is running
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Sat, 24 Mar 2018 00:22:50 +0000 (00:22 +0000)]
Set correct timeouts for oplock break requests
In case of more than one channel configured, set timeout to
OPLOCK_BREAK_TIMEOUT - 5 seconds for main oplock break and if
that fails, 5 seconds for the retry.
For a single channel, stick to OPLOCK_BREAK_TIMEOUT.
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Thu, 22 Mar 2018 17:29:51 +0000 (17:29 +0000)]
Add oplock retry code
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Fri, 23 Mar 2018 14:00:51 +0000 (14:00 +0000)]
Split out creation of state vector from smbd_smb2_send_break()
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Thu, 22 Mar 2018 17:31:58 +0000 (17:31 +0000)]
Allow using smbd_smb2_flush_send_queue() for oplock break requests
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Thu, 15 Mar 2018 16:15:00 +0000 (16:15 +0000)]
Pass oplock timeout value as argument to add_oplock_timeout_handler()
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Tue, 6 Mar 2018 19:17:06 +0000 (19:17 +0000)]
Pass smbXsrv_connection instead of smbXsrv_client
when performing lease or oplock break.
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Thu, 14 Jun 2018 22:45:35 +0000 (23:45 +0100)]
Fix oplock break test 2
The current expected behaviour matches Windows server behaviour which
appears to be incorrect. The behaviour now matches the behaviour of
the latest samba server.
The test has been modified to test both windows and samba servers
which use different channels when sending oplock breaks.
We also add new helper CHECK_VAL_GREATER_THAN()
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Wed, 30 May 2018 05:48:59 +0000 (11:18 +0530)]
Clean up and fix smb2.multichannel.leases.test4
Now works for both Windows and Samba servers. Works around bug in Samba
where handle lease is not revoked when file is unlinked.
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Mon, 28 May 2018 11:54:54 +0000 (17:24 +0530)]
s4-torture: Increase timeout in lease_break_handler()
0.1 seconds is not enough and are causing timing related bugs.
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Günther Deschner [Tue, 20 Feb 2018 14:34:17 +0000 (15:34 +0100)]
Create more torture suites
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Signed-off-by: Guenther Deschner <gd@samba.org>
Sachin Prabhu [Tue, 20 Feb 2018 14:10:39 +0000 (14:10 +0000)]
Disable check for channel on which oplock break is received
The behaviour for Windows and Samba file servers here differ with
Windows using the last created channel and Samba using the first created
channel. Since the requirement is not specified, we do not need this
check which causes tests on Samba to fail.
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Fri, 16 Feb 2018 07:31:34 +0000 (13:01 +0530)]
Clean up and fix oplock break test 2
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Fri, 16 Feb 2018 06:47:07 +0000 (12:17 +0530)]
Split test 1 off test_multichannel_oplock_break()
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Fri, 16 Feb 2018 06:16:29 +0000 (11:46 +0530)]
Remove unnessary checks from oplock break test
Checks for timeouts and durable file handles not needed for
multichannel.
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Thu, 15 Feb 2018 11:38:47 +0000 (17:08 +0530)]
Remove unnecessary checks in multichannel lease break testing
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Wed, 14 Feb 2018 12:50:46 +0000 (18:20 +0530)]
Add lease break Test 4
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Wed, 14 Feb 2018 11:50:32 +0000 (17:20 +0530)]
Split test_multichannel_lease_break()
into
test_multichannel_lease_break_test2() and
test_multichannel_lease_break_test3()
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Wed, 14 Feb 2018 11:16:39 +0000 (16:46 +0530)]
Remove test 2 off test_multichannel_lease_break()
Test 1 covers this scenario
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Wed, 14 Feb 2018 11:02:57 +0000 (16:32 +0530)]
Split test1 off test_multichannel_lease_break()
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Wed, 14 Feb 2018 10:17:43 +0000 (15:47 +0530)]
Disable debug print of network interfaces
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Wed, 14 Feb 2018 09:51:36 +0000 (15:21 +0530)]
Move code to initialise struct smb2_create into own functions
Avoid code duplication
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Wed, 14 Feb 2018 09:44:55 +0000 (15:14 +0530)]
Split common initial tests into own function
Prevent code duplication
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Tue, 13 Feb 2018 15:56:10 +0000 (21:26 +0530)]
Move channel creation code into separate functions
Avoid code duplication.
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Fri, 2 Feb 2018 08:39:39 +0000 (14:09 +0530)]
Clean up tests for lease breaks over multichannel
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Günther Deschner [Mon, 25 Jun 2018 14:09:37 +0000 (16:09 +0200)]
fixup smbd_smb2_send_break after event context changes
Günther Deschner [Wed, 28 Feb 2018 15:57:00 +0000 (16:57 +0100)]
add ode to smb multichannel
Günther Deschner [Wed, 21 Feb 2018 10:29:20 +0000 (11:29 +0100)]
comments
Günther Deschner [Tue, 20 Feb 2018 15:24:45 +0000 (16:24 +0100)]
use smb_get_latest_intact_client_connection
Günther Deschner [Tue, 20 Feb 2018 15:24:36 +0000 (16:24 +0100)]
add new smb_get_latest_intact_client_connection
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Sachin Prabhu [Tue, 10 Jul 2018 12:56:17 +0000 (13:56 +0100)]
smbXsrv_connection: Add new struct timeval last_failure
To track transient channel link failures.
Signed-off-by: Sachin Prabhu <sprabhu@redhat.com>
Günther Deschner [Sat, 3 Feb 2018 14:23:20 +0000 (15:23 +0100)]
wip
Günther Deschner [Sat, 3 Feb 2018 14:23:07 +0000 (15:23 +0100)]
smbd: add smb_get_latest_client_connection()
Günther Deschner [Wed, 24 Jan 2018 16:14:59 +0000 (17:14 +0100)]
s3-smbd: update inline comment for max channels
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Wed, 24 Jan 2018 16:05:41 +0000 (17:05 +0100)]
Revert "STEP07 - DEBUG - smb2:session bind"
This reverts commit
df8647e3dbb45ef52f4b52b4aaab17a5f73f78de.
Günther Deschner [Wed, 24 Jan 2018 16:05:39 +0000 (17:05 +0100)]
Revert "STEP07 - TMP/DEBUG debug binding"
This reverts commit
977dd9926aa83f37c5af95e10c22820d21ad41f3.
Günther Deschner [Wed, 24 Jan 2018 16:05:36 +0000 (17:05 +0100)]
Revert "STEP07 - TMP/DEBUG security >= user"
This reverts commit
455dd3d25cf30999861885d2ae35c971eec9fa29.
Günther Deschner [Wed, 24 Jan 2018 14:00:19 +0000 (15:00 +0100)]
s3-smbd: give oplock/lease break call 30 seconds to reply.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Mon, 27 Nov 2017 15:51:48 +0000 (16:51 +0100)]
Revert "TMP: smbd. more debug multichannel"
This reverts commit
10ee059810008aab88434c3d540d9c3b04cd4108.
Günther Deschner [Mon, 27 Nov 2017 13:18:05 +0000 (14:18 +0100)]
Revert "DEBUG smbXsrc_session"
This reverts commit
fd2c2a54a9ac259d84fd0f7acebd6e1abc870049.
Günther Deschner [Mon, 27 Nov 2017 12:19:44 +0000 (13:19 +0100)]
Revert "STEP05b debug session lookup"
This reverts commit
c6870c097af53a37673f97871c9b8911487ea70e.
Günther Deschner [Mon, 27 Nov 2017 10:59:49 +0000 (11:59 +0100)]
Revert "TMP/DEBUG: debugging in smb2 dispatcher"
This reverts commit
89e6bd421217bd4d071162c01e5c2400b1104bbb.
Günther Deschner [Sun, 29 Oct 2017 09:01:22 +0000 (10:01 +0100)]
more docs
Sachin Prabhu [Tue, 30 Jan 2018 08:28:57 +0000 (13:58 +0530)]
Call correct function for torture_unblock_tcp_transport()
Günther Deschner [Thu, 19 Oct 2017 15:08:39 +0000 (17:08 +0200)]
s4-torture: add test to check for max. number of channels per session.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Thu, 19 Oct 2017 16:09:07 +0000 (18:09 +0200)]
wscript: use git ls-files for ctags file list generation
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Sun, 24 Sep 2017 15:57:19 +0000 (17:57 +0200)]
block. not sure...
Günther Deschner [Fri, 22 Sep 2017 20:19:52 +0000 (22:19 +0200)]
fixup torture_sleep
Günther Deschner [Fri, 22 Sep 2017 00:31:32 +0000 (02:31 +0200)]
DOC: retries
Günther Deschner [Fri, 10 Nov 2017 18:41:56 +0000 (19:41 +0100)]
Revert "s3-smbd: use the same TCP keepalive settings as Windows 2012 and 2016"
This reverts commit
c6a6171ab2c7ee887e0860598a126a5424c982b7.
Günther Deschner [Wed, 20 Sep 2017 05:50:08 +0000 (07:50 +0200)]
s3-smbd: use the same TCP keepalive settings as Windows 2012 and 2016
Windows sends 10 keepalives every second after 10 seconds of inactivity
for continously available (CA) shares.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Wed, 20 Sep 2017 05:50:08 +0000 (07:50 +0200)]
lib/util: allow to set specific TCP keepalive settings per socket.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Wed, 20 Sep 2017 18:21:49 +0000 (20:21 +0200)]
lib/util: allow to set TCP_USER_TIMEOUT socket option
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Wed, 20 Sep 2017 19:19:03 +0000 (21:19 +0200)]
libcli/smb: add smbXcli_conn_print_sockopt()
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Thu, 21 Sep 2017 23:57:49 +0000 (01:57 +0200)]
Günther Deschner [Thu, 21 Sep 2017 23:57:23 +0000 (01:57 +0200)]
leasev2
Günther Deschner [Wed, 20 Sep 2017 17:19:50 +0000 (19:19 +0200)]
document more tcp keepalive findings
Günther Deschner [Wed, 20 Sep 2017 00:05:40 +0000 (02:05 +0200)]
test working lease break block
Günther Deschner [Tue, 19 Sep 2017 18:00:59 +0000 (20:00 +0200)]
wip lease block
Günther Deschner [Tue, 19 Sep 2017 18:01:10 +0000 (20:01 +0200)]
s4-torture: this is the real difference between oplock and lease break
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Tue, 19 Sep 2017 18:00:42 +0000 (20:00 +0200)]
server wip
Günther Deschner [Thu, 14 Sep 2017 23:30:31 +0000 (01:30 +0200)]
s3-selftest: make sure multichannel tests run against the "durable" share
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Tue, 19 Sep 2017 19:52:02 +0000 (21:52 +0200)]
rest
Günther Deschner [Fri, 30 Sep 2016 02:48:39 +0000 (04:48 +0200)]
s4-torture: make sure we always require batch oplocks
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Pair-Programmed-With: Jose A. Rivera <jarrpa@samba.org>
Günther Deschner [Fri, 30 Sep 2016 02:47:14 +0000 (04:47 +0200)]
s4-torture: remove SO share code from multichannel oplock test.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Pair-Programmed-With: Jose A. Rivera <jarrpa@samba.org>
Günther Deschner [Fri, 30 Sep 2016 02:44:35 +0000 (04:44 +0200)]
s4-torture: add additional write test during broken channel for oplock test
This test makes sure to verify we can still use the filehandles of client2 for
writing.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Pair-Programmed-With: Jose A. Rivera <jarrpa@samba.org>
Günther Deschner [Thu, 29 Sep 2016 05:52:32 +0000 (07:52 +0200)]
s4-torture: add lease break test for multichannel
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Pair-Programmed-With: Jose A. Rivera <jarrpa@samba.org>
Günther Deschner [Mon, 18 Sep 2017 22:14:08 +0000 (00:14 +0200)]
Revert "s4-torture: add torture_comment in lease_break_handler."
This reverts commit
2a158ca114528e66dadf0c5880b11682e4968382.
Günther Deschner [Thu, 29 Sep 2016 08:38:29 +0000 (10:38 +0200)]
s4-torture: add torture_comment in lease_break_handler.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Pair-Programmed-With: Jose A. Rivera <jarrpa@samba.org>
Jose A. Rivera [Thu, 29 Sep 2016 05:33:46 +0000 (07:33 +0200)]
s4-torture: add additional oplock break test
This test verifies that Windows will use an alternate channel to process the
oplock break when the original channel's tcp connection has been reset.
Signed-off-by: Jose A. Rivera <jarrpa@samba.org>
Pair-Programmed-With: Guenther Deschner <gd@samba.org>
Günther Deschner [Thu, 21 Sep 2017 16:24:26 +0000 (18:24 +0200)]
s4-torture: add iptables filtering for multichannel oplock break test.
This test demonstrates that Windows (2012R2) will *NOT* retry oplock break
requests over other channels in one multichannel session.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Pair-Programmed-With: Jose A. Rivera <jarrpa@samba.org>
Günther Deschner [Thu, 29 Sep 2016 04:49:50 +0000 (06:49 +0200)]
s4-torture: add torture_block/torture_unblock smb2 transport functions
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Tue, 27 Sep 2016 02:50:39 +0000 (04:50 +0200)]
s4-torture: add new smb2 multichannel oplock break test
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Pair-Programmed-With: Jose A. Rivera <jarrpa@samba.org>
Günther Deschner [Mon, 18 Sep 2017 23:17:33 +0000 (01:17 +0200)]
s4-torture: move torture_wait_for_oplock_break() to central oplock handler.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Wed, 28 Sep 2016 19:23:20 +0000 (21:23 +0200)]
s4-torture: move oplock break handler out of the replay testsuite.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Tue, 19 Sep 2017 01:07:17 +0000 (03:07 +0200)]
TODO: document what new multichannel test needs to do§
Günther Deschner [Thu, 21 Jan 2016 16:07:46 +0000 (17:07 +0100)]
WIP s4-torture: add new test for multichannel on multiple nics.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Tue, 19 Jan 2016 14:39:34 +0000 (15:39 +0100)]
s4-torture: add test for interface information retrieval for multichannel.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Tue, 19 Jan 2016 13:55:03 +0000 (14:55 +0100)]
s4-torture: add new smb2 multichannel suite skeleton.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Wed, 20 Sep 2017 17:19:37 +0000 (19:19 +0200)]
s4-torture: include torture/util.h in lease break handler
Günther Deschner [Fri, 22 Sep 2017 00:31:32 +0000 (02:31 +0200)]
s4-torture: add torture_sleep()
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Tue, 19 Jan 2016 13:53:20 +0000 (14:53 +0100)]
s4-torture: simplify smb2_util_oplock_level(), it's always called with only one option.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Günther Deschner [Fri, 30 Sep 2016 03:03:17 +0000 (05:03 +0200)]
s4-torture: remove an CHECK_STATUS macro in the util code.
Guenther
Signed-off-by: Guenther Deschner <gd@samba.org>
Pair-Programmed-With: Jose A. Rivera <jarrpa@samba.org>
Günther Deschner [Tue, 19 Sep 2017 01:24:24 +0000 (03:24 +0200)]
s4-torture: use torture_assert_ntstatus_equal_goto in replay test
Günther Deschner [Mon, 18 Sep 2017 22:06:30 +0000 (00:06 +0200)]
testing session reauth5
Günther Deschner [Fri, 9 Sep 2016 15:47:36 +0000 (17:47 +0200)]
more explanations
Günther Deschner [Tue, 6 Sep 2016 16:09:15 +0000 (18:09 +0200)]
pass down smbXsrv_client
Günther Deschner [Tue, 6 Sep 2016 11:57:31 +0000 (13:57 +0200)]
metze dixit
Günther Deschner [Mon, 5 Sep 2016 17:00:19 +0000 (19:00 +0200)]
Multi-Channel: break resend -- big todo / q comment
Günther Deschner [Fri, 2 Sep 2016 15:53:06 +0000 (17:53 +0200)]
print SIOCOUTQ counter before and after the writev
debug 0/10
SQ: moving SIOCOUTQ printout ...
Michael Adam [Fri, 26 Aug 2016 17:07:26 +0000 (19:07 +0200)]
TODO.multi-channel: some ideas for oplock break retry
Michael Adam [Fri, 26 Aug 2016 11:55:13 +0000 (13:55 +0200)]
smbXsrv: remove an old comment - multi-channel support is now available
Signed-off-by: Michael Adam <obnox@samba.org>
Günther Deschner [Fri, 15 Jan 2016 17:09:40 +0000 (18:09 +0100)]
wip
Stefan Metzmacher [Thu, 12 Jun 2014 14:35:38 +0000 (16:35 +0200)]
Revert "HACK ctdb/ib"
This reverts commit
e78fe68ecd623fd14e3047c89cdf2a69625a3702.
Stefan Metzmacher [Tue, 20 May 2014 07:00:17 +0000 (09:00 +0200)]
HACK ctdb/ib
Michael Adam [Thu, 14 Jan 2016 00:36:57 +0000 (01:36 +0100)]
-- 00-STEPS-multi-channel: STEPZZ - test changes ---
Michael Adam [Fri, 8 May 2015 08:54:56 +0000 (10:54 +0200)]
TMP:DEBUG: s3:torture:smb2 add DEBUG
git.samba.org / obnox / samba / samba-obnox.git / log