rwrap: Do an early return if log level doesn't match

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

diff --git a/src/resolv_wrapper.c b/src/resolv_wrapper.c
index 1c714475642c2c44585e9b66b6df0339da9d8bf3..0b05ea550fc8edcecea67f4a4dc16a00366ec1a9 100644 (file)
--- a/src/resolv_wrapper.c
+++ b/src/resolv_wrapper.c
@@ -100,33 +100,35 @@ static void rwrap_log(enum rwrap_dbglvl_e dbglvl,
                lvl = atoi(d);
        }
 
+       if (lvl < dbglvl) {
+               return;
+       }
+
        va_start(va, format);
        vsnprintf(buffer, sizeof(buffer), format, va);
        va_end(va);
 
-       if (lvl >= dbglvl) {
-               switch (dbglvl) {
-                       case RWRAP_LOG_ERROR:
-                               fprintf(stderr,
-                                       "RWRAP_ERROR(%d) - %s: %s\n",
-                                       pid, func, buffer);
-                               break;
-                       case RWRAP_LOG_WARN:
-                               fprintf(stderr,
-                                       "RWRAP_WARN(%d) - %s: %s\n",
-                                       pid, func, buffer);
-                               break;
-                       case RWRAP_LOG_DEBUG:
-                               fprintf(stderr,
-                                       "RWRAP_DEBUG(%d) - %s: %s\n",
-                                       pid, func, buffer);
-                               break;
-                       case RWRAP_LOG_TRACE:
-                               fprintf(stderr,
-                                       "RWRAP_TRACE(%d) - %s: %s\n",
-                                       pid, func, buffer);
-                               break;
-               }
+       switch (dbglvl) {
+               case RWRAP_LOG_ERROR:
+                       fprintf(stderr,
+                               "RWRAP_ERROR(%d) - %s: %s\n",
+                               pid, func, buffer);
+                       break;
+               case RWRAP_LOG_WARN:
+                       fprintf(stderr,
+                               "RWRAP_WARN(%d) - %s: %s\n",
+                               pid, func, buffer);
+                       break;
+               case RWRAP_LOG_DEBUG:
+                       fprintf(stderr,
+                               "RWRAP_DEBUG(%d) - %s: %s\n",
+                               pid, func, buffer);
+                       break;
+               case RWRAP_LOG_TRACE:
+                       fprintf(stderr,
+                               "RWRAP_TRACE(%d) - %s: %s\n",
+                               pid, func, buffer);
+                       break;
        }
 }