tests: Fix pointer type for assert_string_equal()
authorAndreas Schneider <asn@samba.org>
Fri, 17 Feb 2023 17:01:57 +0000 (18:01 +0100)
committerAndreas Schneider <asn@samba.org>
Fri, 17 Feb 2023 17:02:50 +0000 (18:02 +0100)
error: pointer targets in passing argument 1 of ‘_assert_string_equal’
differ in signedness [-Werror=pointer-sign]

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Pavel Filipenský <pfilipensky@samba.org>
tests/test_dns_fake.c

index c057ebeecfd71c69f9589ce8e4ade04b85dd9570..4f19f125798617b13d9959015ac6783a94e30d40 100644 (file)
@@ -392,7 +392,7 @@ static void test_res_fake_uri_query(void **state)
 
        assert_int_equal(prio, 2);
        assert_int_equal(weight, 5);
-       assert_string_equal(rrdata, "https://vpn.cwrap.org/VPN");
+       assert_string_equal((const char *)rrdata, "https://vpn.cwrap.org/VPN");
 
        assert_int_equal(ns_parserr(&handle, ns_s_an, 1, &rr), 0);
        assert_int_equal(ns_rr_type(rr), ns_t_uri);
@@ -402,7 +402,7 @@ static void test_res_fake_uri_query(void **state)
 
        assert_int_equal(prio, 2);
        assert_int_equal(weight, 10);
-       assert_string_equal(rrdata, "https://vpn2.cwrap.org/VPN");
+       assert_string_equal((const char *)rrdata, "https://vpn2.cwrap.org/VPN");
 
        assert_int_equal(ns_parserr(&handle, ns_s_an, 2, &rr), 0);
        assert_int_equal(ns_rr_type(rr), ns_t_uri);
@@ -412,7 +412,7 @@ static void test_res_fake_uri_query(void **state)
 
        assert_int_equal(prio, 2);
        assert_int_equal(weight, 20);
-       assert_string_equal(rrdata, "https://vpn3.cwrap.org/VPN");
+       assert_string_equal((const char *)rrdata, "https://vpn3.cwrap.org/VPN");
 
 }
 
@@ -461,7 +461,7 @@ static void test_res_fake_uri_query_minimal(void **state)
 
        assert_int_equal(prio, 1);
        assert_int_equal(weight, 100);
-       assert_string_equal(rrdata, "ftp://ftp.cwrap.org/public");
+       assert_string_equal((const char *)rrdata, "ftp://ftp.cwrap.org/public");
 }
 
 static void test_res_fake_soa_query(void **state)
@@ -746,7 +746,7 @@ static void test_res_fake_txt_query(void **state)
        assert_int_equal(ns_rr_type(rr), ns_t_txt);
 
        rrdata = ns_rr_rdata(rr);
-       assert_string_equal(rrdata, "v=spf1 mx");
+       assert_string_equal((const char *)rrdata, "v=spf1 mx");
 }
 
 static void test_res_fake_uri_nsearch(void **state)
@@ -787,7 +787,7 @@ static void test_res_fake_uri_nsearch(void **state)
        NS_GET16(weight, rrdata);
        assert_int_equal(prio, 2);
        assert_int_equal(weight, 5);
-       assert_string_equal(rrdata, "https://vpn.cwrap.org/VPN");
+       assert_string_equal((const char *)rrdata, "https://vpn.cwrap.org/VPN");
 
        assert_int_equal(ns_parserr(&handle, ns_s_an, 1, &rr), 0);
        assert_int_equal(ns_rr_type(rr), ns_t_uri);
@@ -796,7 +796,7 @@ static void test_res_fake_uri_nsearch(void **state)
        NS_GET16(weight, rrdata);
        assert_int_equal(prio, 2);
        assert_int_equal(weight, 10);
-       assert_string_equal(rrdata, "https://vpn2.cwrap.org/VPN");
+       assert_string_equal((const char *)rrdata, "https://vpn2.cwrap.org/VPN");
 
        assert_int_equal(ns_parserr(&handle, ns_s_an, 2, &rr), 0);
        assert_int_equal(ns_rr_type(rr), ns_t_uri);
@@ -805,7 +805,7 @@ static void test_res_fake_uri_nsearch(void **state)
        NS_GET16(weight, rrdata);
        assert_int_equal(prio, 2);
        assert_int_equal(weight, 20);
-       assert_string_equal(rrdata, "https://vpn3.cwrap.org/VPN");
+       assert_string_equal((const char *)rrdata, "https://vpn3.cwrap.org/VPN");
 }
 
 int main(void)