Make sure that the configure.sh script is up-to-date in a release.
authorWayne Davison <wayne@opencoder.net>
Fri, 19 Aug 2022 15:57:47 +0000 (08:57 -0700)
committerWayne Davison <wayne@opencoder.net>
Fri, 19 Aug 2022 16:49:52 +0000 (09:49 -0700)
packaging/pkglib.py
packaging/release-rsync

index 52f3d892b430163d890337a9e203d59c025f1a40..6f5557aaef983fb3446451ebc34af3852b7f717c 100644 (file)
@@ -32,7 +32,7 @@ def _tweak_opts(cmd, opts, **maybe_set_args):
     opts = opts.copy()
     _maybe_set(opts, **maybe_set_args)
 
-    if type(cmd) == str:
+    if isinstance(cmd, str):
         _maybe_set(opts, shell=True)
 
     want_raw = opts.pop('raw', False)
index 5e54d06e0416bb3a04a5c0bd13ead19d2f479d5a..f37bd18422e25fe60a8375d9bff9e4682bb23c95 100755 (executable)
@@ -232,7 +232,7 @@ About to:
     cmd_chk(['packaging/year-tweak'])
 
     print(dash_line)
-    cmd_run("git diff")
+    cmd_run("git diff".split())
 
     srctar_name = f"{rsync_ver}.tar.gz"
     pattar_name = f"rsync-patches-{version}.tar.gz"
@@ -247,7 +247,7 @@ About to:
 
 About to:
     - git commit all changes
-    - generate the manpages
+    - run a full build, ensuring that the manpages & configure.sh are up-to-date
     - merge the {args.master_branch} branch into the patch/{args.master_branch}/* branches
     - update the files in the "patches" dir and OPTIONALLY (if you type 'y') to
       run patch-update with the --make option (which opens a shell on error)
@@ -258,9 +258,9 @@ About to:
     if s.returncode:
         die('Aborting')
 
-    cmd_chk('make gen')
+    cmd_chk('touch configure.ac && packaging/smart-make && make gen')
 
-    print(f'Creating any missing patch branches.')
+    print('Creating any missing patch branches.')
     s = cmd_run(f'packaging/branch-from-patch --branch={args.master_branch} --add-missing')
     if s.returncode:
         die('Aborting')