s3-printing: fix printer_list_traverse()
authorDavid Disseldorp <ddiss@suse.de>
Mon, 20 Dec 2010 15:08:02 +0000 (16:08 +0100)
committerAndreas Schneider <asn@samba.org>
Mon, 20 Dec 2010 17:44:41 +0000 (18:44 +0100)
The tdb traverse function returns the number of elements traversed, or
less than zero on error, printer_list_traverse() is incorrectly checking
for non-zero return.

Autobuild-User: Andreas Schneider <asn@samba.org>
Autobuild-Date: Mon Dec 20 18:44:41 CET 2010 on sn-devel-104

source3/printing/printer_list.c

index edc398ba771d68be3fffc9814b8165b2ed62e47a..f3f00f0c0f55b9b5dcc9a4e47b3329e5446889f4 100644 (file)
@@ -293,7 +293,7 @@ static NTSTATUS printer_list_traverse(printer_list_trv_fn_t *fn,
        }
 
        ret = db->traverse(db, fn, private_data);
-       if (ret != 0) {
+       if (ret < 0) {
                return NT_STATUS_UNSUCCESSFUL;
        }