ReadOnly: revokechild_active is a list, not a context.
authorRonnie Sahlberg <ronniesahlberg@gmail.com>
Tue, 13 Sep 2011 08:47:18 +0000 (18:47 +1000)
committerRonnie Sahlberg <ronniesahlberg@gmail.com>
Tue, 13 Sep 2011 08:47:18 +0000 (18:47 +1000)
Dont reset the pointer to NULL after deleting the first entry, loop deleting one entry
at a time until they are all gone or we will leak some memory and possibly a process.

server/ctdb_recover.c

index 5d98c4480b9f9cc8257a2d0ef8c121fb47d7307b..3d56f77d6c28bc36e49e0d2048ba80bdf33007d5 100644 (file)
@@ -506,7 +506,6 @@ int32_t ctdb_control_push_db(struct ctdb_context *ctdb, TDB_DATA indata)
                }
                while (ctdb_db->revokechild_active != NULL) {
                        talloc_free(ctdb_db->revokechild_active);
-                       ctdb_db->revokechild_active = NULL;
                }
        }