gd [Mon, 10 Sep 2007 23:29:16 +0000 (23:29 +0000)]
Merge to 3_0_25 as well.
Guenther
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@25069
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
idra [Mon, 10 Sep 2007 19:19:59 +0000 (19:19 +0000)]
We use BOOL/True/False not bool/true/false
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@25064
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
idra [Mon, 10 Sep 2007 19:14:22 +0000 (19:14 +0000)]
Fix segfault in smbldp_set_creds when we want to use anonymous, the
code was not passing in the "anon" flag correctly and was passing
NULL pointers.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@25063
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
idra [Mon, 10 Sep 2007 19:04:57 +0000 (19:04 +0000)]
Reformat, remove trailing spaces and fit lines into 80 columns
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@25062
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
idra [Mon, 10 Sep 2007 16:56:51 +0000 (16:56 +0000)]
Fix formatting, remove trailing spaces and cut lines longer than 80 chars
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@25060
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
idra [Mon, 10 Sep 2007 16:20:41 +0000 (16:20 +0000)]
Fix #4772 the idmap ldap suffix was evaluated in the wrong order resulting
in the code giving precedence to the old global prameter instead of the one
specified for the specific idmap domain configuration.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@25058
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
lmuelle [Sat, 8 Sep 2007 14:56:11 +0000 (14:56 +0000)]
Contact an off site DC if non is available on site.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@25032
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
lmuelle [Sat, 8 Sep 2007 13:53:08 +0000 (13:53 +0000)]
ip_srv_nonsite and count_nonsite are initialized in get_kdc_list() in any
case.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@25030
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
lmuelle [Sat, 8 Sep 2007 13:35:56 +0000 (13:35 +0000)]
Merge revision 24836 from 3_2*. This is required by an outstanding patch.
Initialize some uninitialized variables.
This prevents a segfault when get_kdc_ip_string() is called
with sitename == NULL.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@25029
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Sat, 8 Sep 2007 09:15:08 +0000 (09:15 +0000)]
Fix a whole bunch of Coverity bugs
The callers of get_domain_group_from_sid() with some justification
expected map->gid to be initialized when get_domain_group_from_sid
returned True.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@25024
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
derrell [Thu, 6 Sep 2007 13:23:24 +0000 (13:23 +0000)]
- Use the formal syntax for calling functions through pointers. I've wanted
to make this change for ages, but now with the issue of "open" requiring it,
this is the time to just do all of them.
Derrell
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24982
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
idra [Wed, 5 Sep 2007 12:53:04 +0000 (12:53 +0000)]
Add note about Debian packaging
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24967
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
idra [Wed, 5 Sep 2007 12:52:40 +0000 (12:52 +0000)]
Revert, wrong branch
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24966
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
idra [Wed, 5 Sep 2007 12:43:39 +0000 (12:43 +0000)]
"open" is a macro in newest glibc in rawhide
this patch let samba compile again
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24965
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
idra [Wed, 5 Sep 2007 12:41:13 +0000 (12:41 +0000)]
ports cant be greater then 65535, ignore anything above
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24964
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
idra [Wed, 5 Sep 2007 12:40:15 +0000 (12:40 +0000)]
Older patch that I forgot to commit
Actually prevent machine from changing the password if we are configured so
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24963
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
idra [Mon, 3 Sep 2007 16:09:30 +0000 (16:09 +0000)]
Patches to build 3.0.25c
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24938
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
derrell [Sat, 1 Sep 2007 18:31:34 +0000 (18:31 +0000)]
- Correct failure of libsmbclient against a version of Windows found on a NAS
device. The device resets a NBT connection on port 139 when it receives a
NetBIOS keepalive request. That request should be supported when NetBIOS is
in use; Windows is behaving badly.
libsmbclient needs a way to determine if a connection is still alive, and
was using a NetBIOS keepalive request if port 139 was in use (on the
assumption that it was probably NBT), and getpeername() when port 139 was
not being used (assuming naked transport).
This patch simplifies the code by exclusively using getpeername() to check
whether a connection is still alive. The NetBIOS keepalive request is
optional anyway (with preference being given to using TCP mechanisms for the
same purpose), so this should be both simpler and more reliable.
Derrell
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24863
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Fri, 31 Aug 2007 09:39:11 +0000 (09:39 +0000)]
Fix two memleaks in idmap_cache.c, bug 4917
Thanks again to Patrick Rynhart for persisting :-)
Simo, please check!
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24826
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 29 Aug 2007 20:36:42 +0000 (20:36 +0000)]
Fix logic error in timeout of blocking lock processing found by
Volker. If a lock timeout expires, we must check we can get the
lock before responding with failure. I'll port this to 3.2.x
next. Volker is writing a torture test.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24790
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
obnox [Tue, 28 Aug 2007 14:25:46 +0000 (14:25 +0000)]
Fix one more use of pwrite in tdb code in the spirit of r23972 and r23977.
Michael
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24738
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Mon, 27 Aug 2007 19:02:53 +0000 (19:02 +0000)]
Janitor for Guenther.
"Fix confusing indent."
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24719
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Mon, 27 Aug 2007 18:33:08 +0000 (18:33 +0000)]
Janitor for Guenther :-).
"Fix obvious error in enum_dom_groups. We were returning NT_STATUS_OK when the realloc failed."
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24716
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Fri, 24 Aug 2007 11:25:38 +0000 (11:25 +0000)]
Attempt to fix bug 4917. Simo, please check!
Thanks Patrick Rynhart for reporting this.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24649
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 23 Aug 2007 21:53:00 +0000 (21:53 +0000)]
Add parameter "directory name cache size" - parameterize
use of directory name cache, 100 by default. Will be needed
to turn this off for *BSD systems.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24639
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Thu, 23 Aug 2007 13:17:19 +0000 (13:17 +0000)]
Fix the python build
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24635
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Thu, 23 Aug 2007 12:23:19 +0000 (12:23 +0000)]
Fix the Tru64 build -- 3_2[_0] is already fixed
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24634
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
obnox [Wed, 22 Aug 2007 13:51:44 +0000 (13:51 +0000)]
Make read_sock return the total number of bytes read instead
of the number of bytes read in the last of possibly several
read calls.
This was noted by Metze.
Michael
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24629
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Wed, 22 Aug 2007 11:23:24 +0000 (11:23 +0000)]
Revert -r24035. No idea what this was. Sorry for breaking the build of
the aixacl2 module.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24617
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Mon, 20 Aug 2007 07:59:22 +0000 (07:59 +0000)]
Only look at errno if the close call actually failed
Patch from Ofir Azoulay <Ofir.Azoulay@expand.com> -- thanks
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24571
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Sun, 19 Aug 2007 19:52:18 +0000 (19:52 +0000)]
Fix #4897, patch from David S. Collier-Brown <davecb@spamcop.net> -- Thanks!
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24547
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
derrell [Sat, 18 Aug 2007 18:09:25 +0000 (18:09 +0000)]
Apply patches made recently made to the 3.2 and 3.2.0 branches but not to the
3.0.25 branch:
- Sort ACEs according to http://support.microsoft.com/kb/269175 so that
Windows Explorer doesn't complain about the order (and so that they get
interpreted properly).
- Removing all ACEs was causing removal of the DACL entirely. Win2000 ignored
the request, presumably due to the PROTECTED flag not being set. Setting
that flag (in make_sec_desc()) has much wider implications than just to
libsmbclient, so instead of modifying that, we'll remove security
descriptors by setting the number of ACEs to zero. At some point, we might
want to look into whether we should actually be setting the PROTECTED flag
in the DACL.
Reference http://www.microsoft.com/technet/prodtechnol/windows2000serv/reskit/distrib/dsce_ctl_qxju.mspx?mfr=true
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24545
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Fri, 17 Aug 2007 22:08:49 +0000 (22:08 +0000)]
and this becomes 3.0.25d-SVN
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24531
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 16 Aug 2007 22:50:57 +0000 (22:50 +0000)]
Move the checks for DOS error codes on open to a function.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24499
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 16 Aug 2007 00:37:07 +0000 (00:37 +0000)]
Fix the mappings in reply_opeXXX calls. Now to test renames.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24476
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 16 Aug 2007 00:22:35 +0000 (00:22 +0000)]
Fix the error mapping for SMB_POSIX_PATH_OPEN.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24475
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 15 Aug 2007 23:56:08 +0000 (23:56 +0000)]
Map error value NT_STATUS_OBJECT_NAME_COLLISION
to ERRDOS, ERRfilexists for NTCreateX and NTTransCreate.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24474
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 15 Aug 2007 23:05:49 +0000 (23:05 +0000)]
Start fixing up the mapping of OBJECT_NAME_COLLISION
to DOS error ERRDOS, ERRfilexists on open calls.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24470
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Wed, 15 Aug 2007 13:44:34 +0000 (13:44 +0000)]
Fix Bug 4852, thank to anto <sistemac@prosoft.ba> for reporting it.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24461
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
derrell [Mon, 13 Aug 2007 18:07:48 +0000 (18:07 +0000)]
- Apply patch from SATOH Fumiyasu to fix bug 4750. smbc_telldir_ctx() was not
returning a value useful to smbc_lseekdir_ctx().
Derrell
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24380
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
derrell [Mon, 13 Aug 2007 17:46:11 +0000 (17:46 +0000)]
- ACL retrieval provided incomplete information because the buffer pointer was
incremented too far in some circumstances. In these cases, only the first
of multiple concatenated strings would be seen.
- Working on bug 4649 pertaining to delete an ACL, this fixes the reported
crash. It appears to have been an incomplete switchover from malloc to
talloc, as the memory was still being freed with SAFE_FREE.
Deleting ACLs still doesn't work. Although a valid request is sent to the
server and a SUCCESS response is returned, the method that's used in
libsmbclient for deleting ACLs seems to be incorrect. In looking at the
samba4 torture tests, it appears that we should be turning on the INHERIT flag
if we want to delete the ACL. (I could use some assistance on the proper
flags to send, from anyone familiar with this stuff.)
Derrell
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24378
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Sat, 11 Aug 2007 17:20:57 +0000 (17:20 +0000)]
Janitor for Volker :-). This one is in 3.0.x also.
Fix an error where gid_t != 32 bit
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24334
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Fri, 10 Aug 2007 20:47:47 +0000 (20:47 +0000)]
From Bjoern JAcke <bj@SerNet.DE>:
attached patches add EA support for Solaris. If no one disagrees, can
someone check this in please?
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24317
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Fri, 10 Aug 2007 20:03:31 +0000 (20:03 +0000)]
Fix an uninitialized read
Jerry, please check this!
Thanks,
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24316
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Fri, 10 Aug 2007 14:01:14 +0000 (14:01 +0000)]
Attempt to fix bug 4868
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24314
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
herb [Thu, 9 Aug 2007 19:01:19 +0000 (19:01 +0000)]
fix debug statments to match function name
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24289
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 8 Aug 2007 23:56:55 +0000 (23:56 +0000)]
Fix bug found by Herb. The vuid entry in the cli_state structure gets
left as nonzero as returned by the failed cli_session_setup_spnego. When we then try
to authenticate as the user in cli_session_setup this returns an
error "Bad userid" (as seen in wireshark).
"We should only leave cli->vuid != 0 on success. Looks like it's
getting set in the cli_session_setup_blob_receive() call and not
cleared again on error."
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24281
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
herb [Mon, 6 Aug 2007 22:24:12 +0000 (22:24 +0000)]
remove biconv detection
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24257
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
herb [Mon, 6 Aug 2007 21:43:34 +0000 (21:43 +0000)]
fix crash when username not specified in net rpc info command
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24255
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Mon, 6 Aug 2007 18:54:26 +0000 (18:54 +0000)]
From Jan Martin <Jan.Martin@rwedea.com>.
----------------------------------------------------------
In rare cases, Samba 3.0.25b shows directory contents at the wrong
position in the file tree when displaying a subdirectory of a DFS link.
The problem occurs whenever Windows XP asks for a DFS referral for a
subdirectory of a DFS link with a trailing backslash.
Windows does not do this very often, but we saw it several times per day
on our central DFS server.
smbd/msdfs.c, dfs_path_lookup() does the following with the requested
path:
- in line 390, the local copy 'localpath' is 'unix_convert'ed; the
trailing backslash is removed inside unix_convert
- in lines 417-20, 'dfspath' (another copy of the requested path) is
mangled another way without removing trailing backslashes
That's why the following loop (lines 435-461) that is meant to
synchronously cut off the last path component from both strings until it
comes to a DFS link, does not handle both strings the same. When the
original path ended with a backslash, 'canon_dfspath' has always one
component more than 'localpath', so that *consumedcntp gets too big in
line 446. This value is reported to the client.
----------------------------------------------------------
Bug #4860.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24253
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Sat, 4 Aug 2007 10:25:27 +0000 (10:25 +0000)]
Fix Coverity ID 391
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24166
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Fri, 3 Aug 2007 16:51:43 +0000 (16:51 +0000)]
Fix for write cache corruption bug reported by Jean-Francois Panisset <panisset@A52.com>.
Awaiting confirmation from reporter.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24164
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Tue, 31 Jul 2007 19:15:27 +0000 (19:15 +0000)]
Fix bug 4849. Thanks to Matthijs Kooijman <matthijs@stdin.nl>
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24107
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Tue, 31 Jul 2007 05:11:40 +0000 (05:11 +0000)]
Fix bug 4836, patch by Matthijs Kooijman <matthijs@stdin.nl>. Thanks!
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24087
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Mon, 30 Jul 2007 07:50:24 +0000 (07:50 +0000)]
Fix a missing END_PROFILE call
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24071
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Fri, 27 Jul 2007 08:24:14 +0000 (08:24 +0000)]
Fix memleaks found by Atsushi Nakabayashi <nakabayashi@miraclelinux.com>
Thanks!
Volker
P.S.: I really wonder --- do you inspect our code at that level
manually, or do you have an automated tool?
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24064
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Thu, 26 Jul 2007 12:08:13 +0000 (12:08 +0000)]
Remove a reference to the outdated samba-docs mailing list. This entire
README really needs to be overhauled at some point.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24055
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Tue, 24 Jul 2007 22:28:19 +0000 (22:28 +0000)]
Fix dfs rename bug in smbclient reported by Thomas Bork <tombork@web.de>.
Couldn't rename file as we weren't DFS enabling the target path.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24036
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Tue, 24 Jul 2007 11:52:38 +0000 (11:52 +0000)]
merge from samba.org/~tridge/samba_3_2_ctdb/:
fixed prototype
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24035
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Mon, 23 Jul 2007 19:09:19 +0000 (19:09 +0000)]
Fix Bug 4792. Thanks to David Gajewski <dgajews@math.utoledo.edu> and to
Timur I. Bakeyev for bugging me :-)
Volker
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@24008
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
obnox [Sat, 21 Jul 2007 20:04:41 +0000 (20:04 +0000)]
Merge r23979:
Fix another occurence of (written != requested) as an
error condition to write. This is in tdb_new_database.
Fix one call to tdb_new_database in tdb_open_ex to not
overwrite the newly propagated errno (typically ENOSPC).
Michael
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23985
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
obnox [Sat, 21 Jul 2007 20:01:53 +0000 (20:01 +0000)]
Merge r23980:
Fix one more use of pwrite in expand_file.
Michael
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23984
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
obnox [Sat, 21 Jul 2007 19:56:28 +0000 (19:56 +0000)]
Merge r23972 and r23977:
Fix a bug in pwrite error detection in tdb_expand_file():
The proper error condition is (ret == -1) instead of
(ret != number_of_byte_told_to_write).
* prevent infinite loops due to 0 bytes written:
try once more. if we still get 0 as return,
set errno to ENOSPC and return -1 (error)
* replace int by correct types (ssize_t and size_t).
* print a warning log message in case "written < requested to write"
usually this means, that the next call to pwrite will fail
with return value -1 and set errno accordingly.
Note that the former error condition "written != requested to write"
is not a correct error condition of write/pwrite. If this is due
to an error, a subsequent call to (p)write will reveal the cause
(typically "no space left on device" - ENOSPC).
Michael
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23983
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 18 Jul 2007 18:57:23 +0000 (18:57 +0000)]
Merge from 3_2-ctdb-tridge as requested by Metze.
/* cope with dead entries from the process not
existing. These should not be considered valid,
otherwise we end up doing zero timeout sharing
violation */
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23958
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 18 Jul 2007 01:27:03 +0000 (01:27 +0000)]
Fix issue found by Shlomi Yaakobovich <Shlomi@exanet.com> where
invalid names sent as a resume name were incorrectly mapped into
. and .. Ensure they really *are . and ..
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23942
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 18 Jul 2007 00:18:57 +0000 (00:18 +0000)]
Don't use "False" when you mean "MARSHALL".
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23941
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Tue, 17 Jul 2007 23:57:13 +0000 (23:57 +0000)]
Added missing line that was deleted accidently.
Should fix the build.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23940
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Tue, 17 Jul 2007 23:01:02 +0000 (23:01 +0000)]
Fixes for notify returns. Returned param value must fix inside
max_param or return NT_STATUS_OK.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23939
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Tue, 17 Jul 2007 20:05:15 +0000 (20:05 +0000)]
Fix the build...
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23936
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Tue, 17 Jul 2007 18:48:39 +0000 (18:48 +0000)]
We were lying to the client in the case of POSIX_UNLINK
if a Windows client had the file open. We were setting
delete on close and returning "ok". The POSIX client then
believed the file was gone (and it wasn't). Fix this to
return SHARING_VIOLATION if there is an existing NTcreateX
open on the file and someone calls POSIX_UNLINK. Still one
more Cthon test to fix but getting closer now. Should
be in 3.0.25c also.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23935
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Tue, 17 Jul 2007 00:50:48 +0000 (00:50 +0000)]
Fix bug with interaction of optimization with
POSIX locking. We can't do lock counts with POSIX,
so stop counting if we get a POSIX lock request.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23908
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Tue, 17 Jul 2007 00:09:56 +0000 (00:09 +0000)]
Fix POSIX unlink bug found by Steve. If we
used lstat during the open (which we always
do for POSIX) then use lstat for the unlink.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23906
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
herb [Fri, 13 Jul 2007 22:05:05 +0000 (22:05 +0000)]
missing quotes
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23868
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Fri, 13 Jul 2007 16:27:16 +0000 (16:27 +0000)]
Add in the i -> j fix I'd missed. Noticed by carwyn@carwyn.com (thanks!).
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23867
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 12 Jul 2007 21:53:15 +0000 (21:53 +0000)]
Fix bug #4308 (Excel ACL bug). Now we're doing a 3.0.25c we need this.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23857
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 12 Jul 2007 18:11:41 +0000 (18:11 +0000)]
Setting the allocation size updates the modified time
as a write does. Fix bug #4779.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23855
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 12 Jul 2007 18:02:04 +0000 (18:02 +0000)]
Keep consistent with 3.2 (at least for now). Remove unneeded pstring.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23854
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
obnox [Thu, 12 Jul 2007 13:41:34 +0000 (13:41 +0000)]
Fix a very misleading error message in tdbbackup.
Michael
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23853
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 11 Jul 2007 23:54:01 +0000 (23:54 +0000)]
Belt-and-braces on the msdfs bug. Ensure ELOOP maps
correctly.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23846
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 11 Jul 2007 23:40:14 +0000 (23:40 +0000)]
Second part of the fix for #4777. Looks like on AIX opendir
returns an errno of ELOOP for a symlink of msdfs:server\path\to\link.
Cope with this by mapping to a known error NT_STATUS_OBJECT_PATH_NOT_FOUND
that we know dfs_path_lookup should ignore.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23845
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Wed, 11 Jul 2007 21:01:06 +0000 (21:01 +0000)]
Fix bug #4777, reported by Bill Marshall <bmarsh@us.ibm.com>.
Doing a DFS traverse through a deep link could fail (not using
explorer).
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23843
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
ab [Wed, 11 Jul 2007 12:04:27 +0000 (12:04 +0000)]
Fix vfs_readahead: transparent modules should always pass through
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23830
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Fri, 6 Jul 2007 21:46:43 +0000 (21:46 +0000)]
Second part of the bugfix for #4763
This should coalesce identical adjacent notify records - making the "too large"
bug very rare indeed. Please test.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23735
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
herb [Fri, 6 Jul 2007 17:48:19 +0000 (17:48 +0000)]
removed reference to non-existent structure
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23732
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 5 Jul 2007 18:28:18 +0000 (18:28 +0000)]
First part of bugfix for #4763. Limit notify responses
to client max buf size.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23728
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Tue, 3 Jul 2007 18:00:54 +0000 (18:00 +0000)]
Fix bug #4759 reported by Raul <ismell@ismell.org>.
"N" is not a valid format entry for ber_printf, should be "n"
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23688
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
gd [Fri, 29 Jun 2007 11:54:29 +0000 (11:54 +0000)]
Remove misleading inline comment.
Guenther
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23654
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Thu, 28 Jun 2007 19:27:30 +0000 (19:27 +0000)]
add examples and try to answer some common questions in the coding style guide
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23645
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
gd [Thu, 28 Jun 2007 18:09:37 +0000 (18:09 +0000)]
Remove from 3_0_25 as well.
Guenther
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23644
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Wed, 27 Jun 2007 18:28:18 +0000 (18:28 +0000)]
Adding coding style guide for Samba 3.0 branches (no differences from Tridge's prog_guide.txt so we should have a similar style throughout the project)
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23636
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jmcd [Tue, 26 Jun 2007 20:09:41 +0000 (20:09 +0000)]
Fix bugzilla #4719: must change password is not set from usrmgr.exe.
This was only affecting the newer versions of usrmgr.exe, because they
use a user_info_25 struct. The password is getting set separately
inside that code, so the password last set time was getting set from the
password change logic.
We also were not parsing a number of fields (like logon hours) from the
user_info_25. That should also be fixed.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23616
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Tue, 26 Jun 2007 19:15:26 +0000 (19:15 +0000)]
Revert 'net idmap dump' to the 3.0.24 behaviour.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23612
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jerry [Tue, 26 Jun 2007 00:52:19 +0000 (00:52 +0000)]
BUG 4579: Don't mark the SAM domain on a Samba DC as an internal domain or else all network connections from the local winbindd will fail
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23601
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
vlendec [Mon, 25 Jun 2007 11:45:54 +0000 (11:45 +0000)]
Add notes about smbfs/cifs to usage() in smb[u]mount
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23596
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Fri, 22 Jun 2007 19:33:46 +0000 (19:33 +0000)]
Fix bug #4725. Don't crash when no eventlogs specified. Needs
merging for 3.0.25b.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23591
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Fri, 22 Jun 2007 17:36:10 +0000 (17:36 +0000)]
Fix realloc leak on failure case from Jim Meyering <jim@meyering.net>.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23590
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Fri, 22 Jun 2007 17:19:08 +0000 (17:19 +0000)]
Ensure we will always release any timeout handler
on fsp close or removal of oplock. Mulitple removals
are safe.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23589
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
gd [Fri, 22 Jun 2007 14:43:42 +0000 (14:43 +0000)]
Fix heimdal path in the krb5 renew routine when we need to compose the tgt
string ourselves.
Guenther
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23586
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
gd [Fri, 22 Jun 2007 11:20:37 +0000 (11:20 +0000)]
Fix event based krb5 ticket refreshing in winbindd.
We were incorrectly using the renew_till timestamp instead of the renewed
ticket's endtime to calculate the next refreshing date.
Guenther
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23582
0c0555d6-39d7-0310-84fc-
f1cc0bd64818
jra [Thu, 21 Jun 2007 22:10:41 +0000 (22:10 +0000)]
Fix winbindd (sorry). Ensure I set the new child_pid
variable at the correct point just before the write
call is scheduled.
Jeremy.
git-svn-id: svn+ssh://svn.samba.org/data/svn/samba/branches/SAMBA_3_0_25@23577
0c0555d6-39d7-0310-84fc-
f1cc0bd64818