s3:libads: Remove extra new line in keytab list output
[samba.git] / source3 / libads / kerberos_keytab.c
1 /*
2    Unix SMB/CIFS implementation.
3    kerberos keytab utility library
4    Copyright (C) Andrew Tridgell 2001
5    Copyright (C) Remus Koos 2001
6    Copyright (C) Luke Howard 2003
7    Copyright (C) Jim McDonough (jmcd@us.ibm.com) 2003
8    Copyright (C) Guenther Deschner 2003
9    Copyright (C) Rakesh Patel 2004
10    Copyright (C) Dan Perry 2004
11    Copyright (C) Jeremy Allison 2004
12    Copyright (C) Gerald Carter 2006
13
14    This program is free software; you can redistribute it and/or modify
15    it under the terms of the GNU General Public License as published by
16    the Free Software Foundation; either version 3 of the License, or
17    (at your option) any later version.
18
19    This program is distributed in the hope that it will be useful,
20    but WITHOUT ANY WARRANTY; without even the implied warranty of
21    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
22    GNU General Public License for more details.
23
24    You should have received a copy of the GNU General Public License
25    along with this program.  If not, see <http://www.gnu.org/licenses/>.
26 */
27
28 #include "includes.h"
29 #include "smb_krb5.h"
30 #include "ads.h"
31 #include "secrets.h"
32
33 #ifdef HAVE_KRB5
34
35 #ifdef HAVE_ADS
36
37 /* This MAX_NAME_LEN is a constant defined in krb5.h */
38 #ifndef MAX_KEYTAB_NAME_LEN
39 #define MAX_KEYTAB_NAME_LEN 1100
40 #endif
41
42 static krb5_error_code ads_keytab_open(krb5_context context,
43                                        krb5_keytab *keytab)
44 {
45         char keytab_str[MAX_KEYTAB_NAME_LEN] = {0};
46         const char *keytab_name = NULL;
47         krb5_error_code ret = 0;
48
49         switch (lp_kerberos_method()) {
50         case KERBEROS_VERIFY_SYSTEM_KEYTAB:
51         case KERBEROS_VERIFY_SECRETS_AND_KEYTAB:
52                 ret = krb5_kt_default_name(context,
53                                            keytab_str,
54                                            sizeof(keytab_str) - 2);
55                 if (ret != 0) {
56                         DBG_WARNING("Failed to get default keytab name");
57                         goto out;
58                 }
59                 keytab_name = keytab_str;
60                 break;
61         case KERBEROS_VERIFY_DEDICATED_KEYTAB:
62                 keytab_name = lp_dedicated_keytab_file();
63                 break;
64         default:
65                 DBG_ERR("Invalid kerberos method set (%d)\n",
66                         lp_kerberos_method());
67                 ret = KRB5_KT_BADNAME;
68                 goto out;
69         }
70
71         if (keytab_name == NULL || keytab_name[0] == '\0') {
72                 DBG_ERR("Invalid keytab name\n");
73                 ret = KRB5_KT_BADNAME;
74                 goto out;
75         }
76
77         ret = smb_krb5_kt_open(context, keytab_name, true, keytab);
78         if (ret != 0) {
79                 DBG_WARNING("smb_krb5_kt_open failed (%s)\n",
80                             error_message(ret));
81                 goto out;
82         }
83
84 out:
85         return ret;
86 }
87
88 static bool fill_default_spns(TALLOC_CTX *ctx, const char *machine_name,
89                                           const char *my_fqdn, const char *spn,
90                                           const char ***spns)
91 {
92         char *psp1, *psp2;
93
94         if (*spns == NULL) {
95                 *spns = talloc_zero_array(ctx, const char*, 3);
96                 if (*spns == NULL) {
97                         return false;
98                 }
99         }
100
101         psp1 = talloc_asprintf(ctx,
102                                "%s/%s",
103                                spn,
104                                machine_name);
105         if (psp1 == NULL) {
106                 return false;
107         }
108
109         if (!strlower_m(&psp1[strlen(spn) + 1])) {
110                 return false;
111         }
112         (*spns)[0] = psp1;
113
114         psp2 = talloc_asprintf(ctx,
115                                "%s/%s",
116                                spn,
117                                my_fqdn);
118         if (psp2 == NULL) {
119                 return false;
120         }
121
122         if (!strlower_m(&psp2[strlen(spn) + 1])) {
123                 return false;
124         }
125
126         (*spns)[1] = psp2;
127
128         return true;
129 }
130
131 static bool ads_set_machine_account_spns(TALLOC_CTX *ctx,
132                                          ADS_STRUCT *ads,
133                                          const char *service_or_spn,
134                                          const char *my_fqdn)
135 {
136         const char **spn_names = NULL;
137         ADS_STATUS aderr;
138         struct spn_struct* spn_struct = NULL;
139         char *tmp = NULL;
140
141         /* SPN should have '/' */
142         tmp = strchr_m(service_or_spn, '/');
143         if (tmp != NULL) {
144                 spn_struct = parse_spn(ctx, service_or_spn);
145                 if (spn_struct == NULL) {
146                         return false;
147                 }
148         }
149
150         DBG_INFO("Attempting to add/update '%s'\n", service_or_spn);
151
152         if (spn_struct != NULL) {
153                 spn_names = talloc_zero_array(ctx, const char*, 2);
154                 spn_names[0] = service_or_spn;
155         } else {
156                 bool ok;
157
158                 ok = fill_default_spns(ctx,
159                                        lp_netbios_name(),
160                                        my_fqdn,
161                                        service_or_spn,
162                                        &spn_names);
163                 if (!ok) {
164                         return false;
165                 }
166         }
167         aderr = ads_add_service_principal_names(ads,
168                                                 lp_netbios_name(),
169                                                 spn_names);
170         if (!ADS_ERR_OK(aderr)) {
171                 DBG_WARNING("Failed to add service principal name.\n");
172                 return false;
173         }
174
175         return true;
176 }
177
178 /*
179  * Create kerberos principal(s) from SPN or service name.
180  */
181 static bool service_or_spn_to_kerberos_princ(TALLOC_CTX *ctx,
182                                              const char *service_or_spn,
183                                              const char *my_fqdn,
184                                              char **p_princ_s,
185                                              char **p_short_princ_s)
186 {
187         char *princ_s = NULL;
188         char *short_princ_s = NULL;
189         const char *service = service_or_spn;
190         const char *host = my_fqdn;
191         struct spn_struct* spn_struct = NULL;
192         char *tmp = NULL;
193         bool ok = true;
194
195         /* SPN should have '/' */
196         tmp = strchr_m(service_or_spn, '/');
197         if (tmp != NULL) {
198                 spn_struct = parse_spn(ctx, service_or_spn);
199                 if (spn_struct == NULL) {
200                         ok = false;
201                         goto out;
202                 }
203         }
204         if (spn_struct != NULL) {
205                 service = spn_struct->serviceclass;
206                 host = spn_struct->host;
207         }
208         princ_s = talloc_asprintf(ctx, "%s/%s@%s",
209                                   service,
210                                   host, lp_realm());
211         if (princ_s == NULL) {
212                 ok = false;
213                 goto out;
214         }
215
216         if (spn_struct == NULL) {
217                 short_princ_s = talloc_asprintf(ctx, "%s/%s@%s",
218                                         service, lp_netbios_name(),
219                                         lp_realm());
220                 if (short_princ_s == NULL) {
221                         ok = false;
222                         goto out;
223                 }
224         }
225         *p_princ_s = princ_s;
226         *p_short_princ_s = short_princ_s;
227 out:
228         return ok;
229 }
230
231 static int add_kt_entry_etypes(krb5_context context, TALLOC_CTX *tmpctx,
232                                ADS_STRUCT *ads, const char *salt_princ_s,
233                                krb5_keytab keytab, krb5_kvno kvno,
234                                const char *srvPrinc, const char *my_fqdn,
235                                krb5_data *password, bool update_ads)
236 {
237         krb5_error_code ret = 0;
238         char *princ_s = NULL;
239         char *short_princ_s = NULL;
240         krb5_enctype enctypes[4] = {
241 #ifdef HAVE_ENCTYPE_AES256_CTS_HMAC_SHA1_96
242                 ENCTYPE_AES256_CTS_HMAC_SHA1_96,
243 #endif
244 #ifdef HAVE_ENCTYPE_AES128_CTS_HMAC_SHA1_96
245                 ENCTYPE_AES128_CTS_HMAC_SHA1_96,
246 #endif
247                 ENCTYPE_ARCFOUR_HMAC,
248                 0
249         };
250         size_t i;
251
252         /* Construct our principal */
253         if (strchr_m(srvPrinc, '@')) {
254                 /* It's a fully-named principal. */
255                 princ_s = talloc_asprintf(tmpctx, "%s", srvPrinc);
256                 if (!princ_s) {
257                         ret = -1;
258                         goto out;
259                 }
260         } else if (srvPrinc[strlen(srvPrinc)-1] == '$') {
261                 /* It's the machine account, as used by smbclient clients. */
262                 princ_s = talloc_asprintf(tmpctx, "%s@%s",
263                                           srvPrinc, lp_realm());
264                 if (!princ_s) {
265                         ret = -1;
266                         goto out;
267                 }
268         } else {
269                 /* It's a normal service principal.  Add the SPN now so that we
270                  * can obtain credentials for it and double-check the salt value
271                  * used to generate the service's keys. */
272
273                 if (!service_or_spn_to_kerberos_princ(tmpctx,
274                                                       srvPrinc,
275                                                       my_fqdn,
276                                                       &princ_s,
277                                                       &short_princ_s)) {
278                         ret = -1;
279                         goto out;
280                 }
281
282                 /* According to http://support.microsoft.com/kb/326985/en-us,
283                    certain principal names are automatically mapped to the
284                    host/... principal in the AD account.
285                    So only create these in the keytab, not in AD.  --jerry */
286
287                 if (update_ads && !strequal(srvPrinc, "cifs") &&
288                     !strequal(srvPrinc, "host")) {
289                         if (!ads_set_machine_account_spns(tmpctx,
290                                                           ads,
291                                                           srvPrinc,
292                                                           my_fqdn)) {
293                                 ret = -1;
294                                 goto out;
295                         }
296                 }
297         }
298
299         for (i = 0; enctypes[i]; i++) {
300
301                 /* add the fqdn principal to the keytab */
302                 ret = smb_krb5_kt_add_entry(context,
303                                             keytab,
304                                             kvno,
305                                             princ_s,
306                                             salt_princ_s,
307                                             enctypes[i],
308                                             password,
309                                             false,
310                                             false);
311                 if (ret) {
312                         DBG_WARNING("Failed to add entry to keytab\n");
313                         goto out;
314                 }
315
316                 /* add the short principal name if we have one */
317                 if (short_princ_s) {
318                         ret = smb_krb5_kt_add_entry(context,
319                                                     keytab,
320                                                     kvno,
321                                                     short_princ_s,
322                                                     salt_princ_s,
323                                                     enctypes[i],
324                                                     password,
325                                                     false,
326                                                     false);
327                         if (ret) {
328                                 DBG_WARNING("Failed to add short entry to keytab\n");
329                                 goto out;
330                         }
331                 }
332         }
333 out:
334         return ret;
335 }
336
337 /**********************************************************************
338  Adds a single service principal, i.e. 'host' to the system keytab
339 ***********************************************************************/
340
341 int ads_keytab_add_entry(ADS_STRUCT *ads, const char *srvPrinc, bool update_ads)
342 {
343         krb5_error_code ret = 0;
344         krb5_context context = NULL;
345         krb5_keytab keytab = NULL;
346         krb5_data password;
347         krb5_kvno kvno;
348         char *salt_princ_s = NULL;
349         char *password_s = NULL;
350         char *my_fqdn;
351         TALLOC_CTX *tmpctx = NULL;
352         char **hostnames_array = NULL;
353         size_t num_hostnames = 0;
354
355         ret = smb_krb5_init_context_common(&context);
356         if (ret) {
357                 DBG_ERR("kerberos init context failed (%s)\n",
358                         error_message(ret));
359                 return -1;
360         }
361
362         ret = ads_keytab_open(context, &keytab);
363         if (ret != 0) {
364                 goto out;
365         }
366
367         /* retrieve the password */
368         if (!secrets_init()) {
369                 DBG_WARNING("secrets_init failed\n");
370                 ret = -1;
371                 goto out;
372         }
373         password_s = secrets_fetch_machine_password(lp_workgroup(), NULL, NULL);
374         if (!password_s) {
375                 DBG_WARNING("failed to fetch machine password\n");
376                 ret = -1;
377                 goto out;
378         }
379         ZERO_STRUCT(password);
380         password.data = password_s;
381         password.length = strlen(password_s);
382
383         /* we need the dNSHostName value here */
384         tmpctx = talloc_init(__location__);
385         if (!tmpctx) {
386                 DBG_ERR("talloc_init() failed!\n");
387                 ret = -1;
388                 goto out;
389         }
390
391         my_fqdn = ads_get_dnshostname(ads, tmpctx, lp_netbios_name());
392         if (!my_fqdn) {
393                 DBG_ERR("unable to determine machine account's dns name in "
394                         "AD!\n");
395                 ret = -1;
396                 goto out;
397         }
398
399         /* make sure we have a single instance of a the computer account */
400         if (!ads_has_samaccountname(ads, tmpctx, lp_netbios_name())) {
401                 DBG_ERR("unable to determine machine account's short name in "
402                         "AD!\n");
403                 ret = -1;
404                 goto out;
405         }
406
407         kvno = (krb5_kvno)ads_get_machine_kvno(ads, lp_netbios_name());
408         if (kvno == -1) {
409                 /* -1 indicates failure, everything else is OK */
410                 DBG_WARNING("ads_get_machine_kvno failed to determine the "
411                             "system's kvno.\n");
412                 ret = -1;
413                 goto out;
414         }
415
416         salt_princ_s = kerberos_secrets_fetch_salt_princ();
417         if (salt_princ_s == NULL) {
418                 DBG_WARNING("kerberos_secrets_fetch_salt_princ() failed\n");
419                 ret = -1;
420                 goto out;
421         }
422
423         ret = add_kt_entry_etypes(context, tmpctx, ads, salt_princ_s, keytab,
424                                   kvno, srvPrinc, my_fqdn, &password,
425                                   update_ads);
426         if (ret != 0) {
427                 goto out;
428         }
429
430         if (ADS_ERR_OK(ads_get_additional_dns_hostnames(tmpctx, ads,
431                                                         lp_netbios_name(),
432                                                         &hostnames_array,
433                                                         &num_hostnames))) {
434                 size_t i;
435
436                 for (i = 0; i < num_hostnames; i++) {
437
438                         ret = add_kt_entry_etypes(context, tmpctx, ads,
439                                                   salt_princ_s, keytab,
440                                                   kvno, srvPrinc,
441                                                   hostnames_array[i],
442                                                   &password, update_ads);
443                         if (ret != 0) {
444                                 goto out;
445                         }
446                 }
447         }
448
449 out:
450         SAFE_FREE(salt_princ_s);
451         TALLOC_FREE(tmpctx);
452
453         if (keytab) {
454                 krb5_kt_close(context, keytab);
455         }
456         if (context) {
457                 krb5_free_context(context);
458         }
459         return (int)ret;
460 }
461
462 /**********************************************************************
463  Flushes all entries from the system keytab.
464 ***********************************************************************/
465
466 int ads_keytab_flush(ADS_STRUCT *ads)
467 {
468         krb5_error_code ret = 0;
469         krb5_context context = NULL;
470         krb5_keytab keytab = NULL;
471         krb5_kvno kvno;
472         ADS_STATUS aderr;
473
474         ret = smb_krb5_init_context_common(&context);
475         if (ret) {
476                 DBG_ERR("kerberos init context failed (%s)\n",
477                         error_message(ret));
478                 return ret;
479         }
480
481         ret = ads_keytab_open(context, &keytab);
482         if (ret != 0) {
483                 goto out;
484         }
485
486         kvno = (krb5_kvno)ads_get_machine_kvno(ads, lp_netbios_name());
487         if (kvno == -1) {
488                 /* -1 indicates a failure */
489                 DEBUG(1, (__location__ ": Error determining the kvno.\n"));
490                 ret = -1;
491                 goto out;
492         }
493
494         /* Seek and delete old keytab entries */
495         ret = smb_krb5_kt_seek_and_delete_old_entries(context,
496                                                       keytab,
497                                                       kvno,
498                                                       ENCTYPE_NULL,
499                                                       NULL,
500                                                       NULL,
501                                                       true,
502                                                       false);
503         if (ret) {
504                 goto out;
505         }
506
507         aderr = ads_clear_service_principal_names(ads, lp_netbios_name());
508         if (!ADS_ERR_OK(aderr)) {
509                 DEBUG(1, (__location__ ": Error while clearing service "
510                           "principal listings in LDAP.\n"));
511                 ret = -1;
512                 goto out;
513         }
514
515 out:
516         if (keytab) {
517                 krb5_kt_close(context, keytab);
518         }
519         if (context) {
520                 krb5_free_context(context);
521         }
522         return ret;
523 }
524
525 /**********************************************************************
526  Adds all the required service principals to the system keytab.
527 ***********************************************************************/
528
529 int ads_keytab_create_default(ADS_STRUCT *ads)
530 {
531         krb5_error_code ret = 0;
532         krb5_context context = NULL;
533         krb5_keytab keytab = NULL;
534         krb5_kt_cursor cursor = {0};
535         krb5_keytab_entry kt_entry = {0};
536         krb5_kvno kvno;
537         size_t found = 0;
538         char *sam_account_name, *upn;
539         char **oldEntries = NULL, *princ_s[26];
540         TALLOC_CTX *frame;
541         char *machine_name;
542         char **spn_array;
543         size_t num_spns;
544         size_t i;
545         bool ok = false;
546         ADS_STATUS status;
547
548         ZERO_STRUCT(kt_entry);
549         ZERO_STRUCT(cursor);
550
551         frame = talloc_stackframe();
552         if (frame == NULL) {
553                 ret = -1;
554                 goto done;
555         }
556
557         status = ads_get_service_principal_names(frame,
558                                                  ads,
559                                                  lp_netbios_name(),
560                                                  &spn_array,
561                                                  &num_spns);
562         if (!ADS_ERR_OK(status)) {
563                 ret = -1;
564                 goto done;
565         }
566
567         for (i = 0; i < num_spns; i++) {
568                 char *srv_princ;
569                 char *p;
570
571                 srv_princ = strlower_talloc(frame, spn_array[i]);
572                 if (srv_princ == NULL) {
573                         ret = -1;
574                         goto done;
575                 }
576
577                 p = strchr_m(srv_princ, '/');
578                 if (p == NULL) {
579                         continue;
580                 }
581                 p[0] = '\0';
582
583                 /* Add the SPNs found on the DC */
584                 ret = ads_keytab_add_entry(ads, srv_princ, false);
585                 if (ret != 0) {
586                         DEBUG(1, ("ads_keytab_add_entry failed while "
587                                   "adding '%s' principal.\n",
588                                   spn_array[i]));
589                         goto done;
590                 }
591         }
592
593 #if 0   /* don't create the CIFS/... keytab entries since no one except smbd
594            really needs them and we will fall back to verifying against
595            secrets.tdb */
596
597         ret = ads_keytab_add_entry(ads, "cifs", false));
598         if (ret != 0 ) {
599                 DEBUG(1, (__location__ ": ads_keytab_add_entry failed while "
600                           "adding 'cifs'.\n"));
601                 return ret;
602         }
603 #endif
604
605         memset(princ_s, '\0', sizeof(princ_s));
606
607         ret = smb_krb5_init_context_common(&context);
608         if (ret) {
609                 DBG_ERR("kerberos init context failed (%s)\n",
610                         error_message(ret));
611                 goto done;
612         }
613
614         machine_name = talloc_strdup(frame, lp_netbios_name());
615         if (!machine_name) {
616                 ret = -1;
617                 goto done;
618         }
619
620         /* now add the userPrincipalName and sAMAccountName entries */
621         ok = ads_has_samaccountname(ads, frame, machine_name);
622         if (!ok) {
623                 DEBUG(0, (__location__ ": unable to determine machine "
624                           "account's name in AD!\n"));
625                 ret = -1;
626                 goto done;
627         }
628
629         /*
630          * append '$' to netbios name so 'ads_keytab_add_entry' recognises
631          * it as a machine account rather than a service or Windows SPN.
632          */
633         sam_account_name = talloc_asprintf(frame, "%s$",machine_name);
634         if (sam_account_name == NULL) {
635                 ret = -1;
636                 goto done;
637         }
638         /* upper case the sAMAccountName to make it easier for apps to
639            know what case to use in the keytab file */
640         if (!strupper_m(sam_account_name)) {
641                 ret = -1;
642                 goto done;
643         }
644
645         ret = ads_keytab_add_entry(ads, sam_account_name, false);
646         if (ret != 0) {
647                 DEBUG(1, (__location__ ": ads_keytab_add_entry() failed "
648                           "while adding sAMAccountName (%s)\n",
649                           sam_account_name));
650                 goto done;
651         }
652
653         /* remember that not every machine account will have a upn */
654         upn = ads_get_upn(ads, frame, machine_name);
655         if (upn) {
656                 ret = ads_keytab_add_entry(ads, upn, false);
657                 if (ret != 0) {
658                         DEBUG(1, (__location__ ": ads_keytab_add_entry() "
659                                   "failed while adding UPN (%s)\n", upn));
660                         goto done;
661                 }
662         }
663
664         /* Now loop through the keytab and update any other existing entries */
665         kvno = (krb5_kvno)ads_get_machine_kvno(ads, machine_name);
666         if (kvno == (krb5_kvno)-1) {
667                 DEBUG(1, (__location__ ": ads_get_machine_kvno() failed to "
668                           "determine the system's kvno.\n"));
669                 goto done;
670         }
671
672         DEBUG(3, (__location__ ": Searching for keytab entries to preserve "
673                   "and update.\n"));
674
675         ret = ads_keytab_open(context, &keytab);
676         if (ret != 0) {
677                 goto done;
678         }
679
680         ret = krb5_kt_start_seq_get(context, keytab, &cursor);
681         if (ret != KRB5_KT_END && ret != ENOENT ) {
682                 while ((ret = krb5_kt_next_entry(context, keytab,
683                                                  &kt_entry, &cursor)) == 0) {
684                         smb_krb5_kt_free_entry(context, &kt_entry);
685                         ZERO_STRUCT(kt_entry);
686                         found++;
687                 }
688         }
689         krb5_kt_end_seq_get(context, keytab, &cursor);
690         ZERO_STRUCT(cursor);
691
692         /*
693          * Hmmm. There is no "rewind" function for the keytab. This means we
694          * have a race condition where someone else could add entries after
695          * we've counted them. Re-open asap to minimise the race. JRA.
696          */
697         DEBUG(3, (__location__ ": Found %zd entries in the keytab.\n", found));
698         if (!found) {
699                 goto done;
700         }
701
702         oldEntries = talloc_zero_array(frame, char *, found + 1);
703         if (!oldEntries) {
704                 DEBUG(1, (__location__ ": Failed to allocate space to store "
705                           "the old keytab entries (talloc failed?).\n"));
706                 ret = -1;
707                 goto done;
708         }
709
710         ret = krb5_kt_start_seq_get(context, keytab, &cursor);
711         if (ret == KRB5_KT_END || ret == ENOENT) {
712                 krb5_kt_end_seq_get(context, keytab, &cursor);
713                 ZERO_STRUCT(cursor);
714                 goto done;
715         }
716
717         while (krb5_kt_next_entry(context, keytab, &kt_entry, &cursor) == 0) {
718                 if (kt_entry.vno != kvno) {
719                         char *ktprinc = NULL;
720                         char *p;
721
722                         /* This returns a malloc'ed string in ktprinc. */
723                         ret = smb_krb5_unparse_name(oldEntries, context,
724                                                     kt_entry.principal,
725                                                     &ktprinc);
726                         if (ret) {
727                                 DEBUG(1, (__location__
728                                          ": smb_krb5_unparse_name failed "
729                                          "(%s)\n", error_message(ret)));
730                                 goto done;
731                         }
732                         /*
733                          * From looking at the krb5 source they don't seem to
734                          * take locale or mb strings into account.
735                          * Maybe this is because they assume utf8 ?
736                          * In this case we may need to convert from utf8 to
737                          * mb charset here ? JRA.
738                          */
739                         p = strchr_m(ktprinc, '@');
740                         if (p) {
741                                 *p = '\0';
742                         }
743
744                         p = strchr_m(ktprinc, '/');
745                         if (p) {
746                                 *p = '\0';
747                         }
748                         for (i = 0; i < found; i++) {
749                                 if (!oldEntries[i]) {
750                                         oldEntries[i] = ktprinc;
751                                         break;
752                                 }
753                                 if (!strcmp(oldEntries[i], ktprinc)) {
754                                         TALLOC_FREE(ktprinc);
755                                         break;
756                                 }
757                         }
758                         if (i == found) {
759                                 TALLOC_FREE(ktprinc);
760                         }
761                 }
762                 smb_krb5_kt_free_entry(context, &kt_entry);
763                 ZERO_STRUCT(kt_entry);
764         }
765         krb5_kt_end_seq_get(context, keytab, &cursor);
766         ZERO_STRUCT(cursor);
767
768         ret = 0;
769         for (i = 0; oldEntries[i]; i++) {
770                 ret |= ads_keytab_add_entry(ads, oldEntries[i], false);
771                 TALLOC_FREE(oldEntries[i]);
772         }
773
774 done:
775         TALLOC_FREE(oldEntries);
776         TALLOC_FREE(frame);
777
778         if (context) {
779                 if (!all_zero((uint8_t *)&kt_entry, sizeof(kt_entry))) {
780                         smb_krb5_kt_free_entry(context, &kt_entry);
781                 }
782                 if (!all_zero((uint8_t *)&cursor, sizeof(cursor)) && keytab) {
783                         krb5_kt_end_seq_get(context, keytab, &cursor);
784                 }
785                 if (keytab) {
786                         krb5_kt_close(context, keytab);
787                 }
788                 krb5_free_context(context);
789         }
790         return ret;
791 }
792
793 #endif /* HAVE_ADS */
794
795 /**********************************************************************
796  List system keytab.
797 ***********************************************************************/
798
799 int ads_keytab_list(const char *keytab_name)
800 {
801         krb5_error_code ret = 0;
802         krb5_context context = NULL;
803         krb5_keytab keytab = NULL;
804         krb5_kt_cursor cursor;
805         krb5_keytab_entry kt_entry;
806
807         ZERO_STRUCT(kt_entry);
808         ZERO_STRUCT(cursor);
809
810         ret = smb_krb5_init_context_common(&context);
811         if (ret) {
812                 DBG_ERR("kerberos init context failed (%s)\n",
813                         error_message(ret));
814                 return ret;
815         }
816
817         if (keytab_name == NULL) {
818 #ifdef HAVE_ADS
819                 ret = ads_keytab_open(context, &keytab);
820 #else
821                 ret = ENOENT;
822 #endif
823         } else {
824                 ret = smb_krb5_kt_open(context, keytab_name, False, &keytab);
825         }
826         if (ret) {
827                 DEBUG(1, ("smb_krb5_kt_open failed (%s)\n",
828                           error_message(ret)));
829                 goto out;
830         }
831
832         ret = krb5_kt_start_seq_get(context, keytab, &cursor);
833         if (ret) {
834                 ZERO_STRUCT(cursor);
835                 goto out;
836         }
837
838         printf("Vno  Type                                        Principal\n");
839
840         while (krb5_kt_next_entry(context, keytab, &kt_entry, &cursor) == 0) {
841
842                 char *princ_s = NULL;
843                 char *etype_s = NULL;
844                 krb5_enctype enctype = 0;
845
846                 ret = smb_krb5_unparse_name(talloc_tos(), context,
847                                             kt_entry.principal, &princ_s);
848                 if (ret) {
849                         goto out;
850                 }
851
852                 enctype = smb_krb5_kt_get_enctype_from_entry(&kt_entry);
853
854                 ret = smb_krb5_enctype_to_string(context, enctype, &etype_s);
855                 if (ret &&
856                     (asprintf(&etype_s, "UNKNOWN: %d", enctype) == -1)) {
857                         TALLOC_FREE(princ_s);
858                         goto out;
859                 }
860
861                 printf("%3d  %-43s %s\n", kt_entry.vno, etype_s, princ_s);
862
863                 TALLOC_FREE(princ_s);
864                 SAFE_FREE(etype_s);
865
866                 ret = smb_krb5_kt_free_entry(context, &kt_entry);
867                 if (ret) {
868                         goto out;
869                 }
870         }
871
872         ret = krb5_kt_end_seq_get(context, keytab, &cursor);
873         if (ret) {
874                 goto out;
875         }
876
877         /* Ensure we don't double free. */
878         ZERO_STRUCT(kt_entry);
879         ZERO_STRUCT(cursor);
880 out:
881
882         if (!all_zero((uint8_t *)&kt_entry, sizeof(kt_entry))) {
883                 smb_krb5_kt_free_entry(context, &kt_entry);
884         }
885         if (!all_zero((uint8_t *)&cursor, sizeof(cursor)) && keytab) {
886                 krb5_kt_end_seq_get(context, keytab, &cursor);
887         }
888
889         if (keytab) {
890                 krb5_kt_close(context, keytab);
891         }
892         if (context) {
893                 krb5_free_context(context);
894         }
895         return ret;
896 }
897
898 #endif /* HAVE_KRB5 */