git.samba.org
/
samba.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
60c0a2b
)
smbd: Fix CID 1438245 Dereference before null check
author
Volker Lendecke
<vl@samba.org>
Tue, 7 Aug 2018 20:50:52 +0000
(22:50 +0200)
committer
Jeremy Allison
<jra@samba.org>
Wed, 8 Aug 2018 18:22:05 +0000
(20:22 +0200)
Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/smbd/nttrans.c
patch
|
blob
|
history
diff --git
a/source3/smbd/nttrans.c
b/source3/smbd/nttrans.c
index bad904b9eb8ab86db765470b2ed99d52e947a09a..68470766f77914620ac4dc660099d9625508eed0 100644
(file)
--- a/
source3/smbd/nttrans.c
+++ b/
source3/smbd/nttrans.c
@@
-2459,7
+2459,7
@@
static enum ndr_err_code extract_sids_from_buf(TALLOC_CTX *mem_ctx,
}
}
*sids = talloc_zero_array(mem_ctx, struct dom_sid, i);
- if (
!sids
) {
+ if (
*sids == NULL
) {
DBG_ERR("OOM\n");
err = NDR_ERR_ALLOC;
goto done;