Implemented a setup_logging() function that takes two keywords:

interactive and logfilename.  These can be used to send Samba DEBUG()
output to stdout or to a logfile which makes automated testing much
funkier.

Also added get_debuglevel() and set_debuglevel() functions.

Make open_pipe_creds() accept None as a anonymous credential.

diff --git a/source/python/py_spoolss.c b/source/python/py_spoolss.c
index b3087deef79a6c32528db43ddc23886ed25c48d0..ead54febda2dbb08778b0d9addb669eda2b21778 100644 (file)
--- a/source/python/py_spoolss.c
+++ b/source/python/py_spoolss.c
@@ -48,7 +48,7 @@ struct cli_state *open_pipe_creds(char *system_name, PyObject *creds,
        ZERO_STRUCT(nt_creds);
        nt_creds.pwd.null_pwd = True;
 
-       if (creds) {
+       if (creds && PyDict_Size(creds) > 0) {
                char *username, *password, *domain;
                PyObject *username_obj, *password_obj, *domain_obj;
 
@@ -187,6 +187,15 @@ Return the printer driver directory for a given architecture.  The
 architecture defaults to \"Windows NT x86\".
 "},
 
+       /* Other stuff - this should really go into a samba config module
+          but for the moment let's leave it here. */
+
+       { "setup_logging", py_setup_logging, METH_VARARGS | METH_KEYWORDS, 
+         "" },
+
+       { "get_debuglevel", get_debuglevel, METH_VARARGS, "" },
+       { "set_debuglevel", set_debuglevel, METH_VARARGS, "" },
+
        { NULL }
 };