libcli: Use "all_zero" where appropriate
authorVolker Lendecke <vl@samba.org>
Sat, 31 Dec 2016 12:45:51 +0000 (12:45 +0000)
committerRalph Boehme <slow@samba.org>
Tue, 3 Jan 2017 15:04:28 +0000 (16:04 +0100)
... Saves a few bytes of footprint

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>
libcli/smb/smbXcli_base.c

index e24090dbc2d776bacc756aab079a6d78c3a9488c..a7b24f014977021fd9711ea8a3301624dc2f5264 100644 (file)
@@ -3851,13 +3851,9 @@ static NTSTATUS smb2cli_conn_dispatch_incoming(struct smbXcli_conn *conn,
                                }
                        }
                        if (signing_key) {
-                               int cmp;
-                               static const uint8_t zeros[16];
-
-                               cmp = memcmp(inhdr+SMB2_HDR_SIGNATURE,
-                                            zeros,
-                                            16);
-                               if (cmp == 0) {
+                               bool zero;
+                               zero = all_zero(inhdr+SMB2_HDR_SIGNATURE, 16);
+                               if (zero) {
                                        state->smb2.signing_skipped = true;
                                        signing_key = NULL;
                                }