samba-tool: Removed attribute name from Command class
authorGiampaolo Lauria <lauria2@yahoo.com>
Thu, 28 Jul 2011 18:21:40 +0000 (14:21 -0400)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 9 Sep 2011 05:24:00 +0000 (15:24 +1000)
Removed name as it is not used anywhere
Moved all the attributes on top of the class declaration

Signed-off-by: Amitay Isaacs <amitay@gmail.com>
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
source4/scripting/python/samba/netcmd/__init__.py

index f76fb8abbdc3607493ff2b5ff380a7a061e15dbf..9636a3a05f6e768e4cfad7ce63a8f93a9097b5e4 100644 (file)
@@ -32,24 +32,27 @@ class Option(optparse.Option):
 
 class Command(object):
     """A samba-tool command."""
-
+   
     def _get_description(self):
         return self.__doc__.splitlines()[0].rstrip("\n")
 
-    def _get_name(self):
-        name = self.__class__.__name__
-        if name.startswith("cmd_"):
-            return name[4:]
-        return name
+    description = property(_get_description)
 
-    name = property(_get_name)
+    # synopsis must be defined in all subclasses in order to provide the command usage
+    synopsis = ""
+    takes_args = []
+    takes_options = []
+    takes_optiongroups = {
+        "sambaopts": options.SambaOptions,
+        "credopts": options.CredentialsOptions,
+        "versionopts": options.VersionOptions,
+        }
+    outf = sys.stdout
 
     def usage(self, *args):
         parser, _ = self._create_parser()
         parser.print_usage()
 
-    description = property(_get_description)
-
     def show_command_error(self, e):
         '''display a command error'''
         if isinstance(e, CommandError):
@@ -84,18 +87,6 @@ class Command(object):
             traceback.print_tb(etraceback)
         sys.exit(1)
 
-    outf = sys.stdout
-
-    # synopsis must be defined in all subclasses in order to provide the command usage
-    synopsis = ""
-    takes_args = []
-    takes_options = []
-    takes_optiongroups = {
-        "sambaopts": options.SambaOptions,
-        "credopts": options.CredentialsOptions,
-        "versionopts": options.VersionOptions,
-        }
-
     def _create_parser(self):
         parser = optparse.OptionParser(self.synopsis)
         parser.add_options(self.takes_options)