s3: libsmb: Cleanup - ensure we initialize all stack variables to 'safe' values when...

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Noel Power <npower@samba.org>

diff --git a/source3/libads/ldap.c b/source3/libads/ldap.c
index 2fc9b2009b633a3044cc33b3bf7a385174448569..1925220515eeb2154775d7cd05bcb2fc3dce61b0 100755 (executable)
--- a/source3/libads/ldap.c
+++ b/source3/libads/ldap.c
@@ -383,8 +383,9 @@ static NTSTATUS cldap_ping_list(ADS_STRUCT *ads,const char *domain,
 static NTSTATUS resolve_and_ping_netbios(ADS_STRUCT *ads,
                                         const char *domain, const char *realm)
 {
-       int count, i;
-       struct ip_service *ip_list;
+       size_t i;
+       size_t count = 0;
+       struct ip_service *ip_list = NULL;
        NTSTATUS status;
 
        DEBUG(6, ("resolve_and_ping_netbios: (cldap) looking for domain '%s'\n",
@@ -430,7 +431,7 @@ static NTSTATUS resolve_and_ping_netbios(ADS_STRUCT *ads,
 static NTSTATUS resolve_and_ping_dns(ADS_STRUCT *ads, const char *sitename,
                                     const char *realm)
 {
-       int count;
+       size_t count = 0;
        struct ip_service *ip_list = NULL;
        NTSTATUS status;
 

diff --git a/source3/libsmb/namequery_dc.c b/source3/libsmb/namequery_dc.c
index 77a7ce30e351d3515fb9a79527f42ef96ed6cf4e..96b5f565773971675ea4b1a1773a0ff8c4bbd978 100644 (file)
--- a/source3/libsmb/namequery_dc.c
+++ b/source3/libsmb/namequery_dc.c
@@ -165,8 +165,9 @@ static bool rpc_dc_name(const char *domain,
                        struct sockaddr_storage *ss_out)
 {
        struct ip_service *ip_list = NULL;
+       size_t count = 0;
        struct sockaddr_storage dc_ss;
-       int count, i;
+       size_t i;
        NTSTATUS result;
        char addr[INET6_ADDRSTRLEN];
 

diff --git a/source3/utils/net_lookup.c b/source3/utils/net_lookup.c
index 777ac38dee9ab2a53851412e3df960b269a3227c..82dbdc4526781c9d047dd7a84da62855aee8f2ba 100644 (file)
--- a/source3/utils/net_lookup.c
+++ b/source3/utils/net_lookup.c
@@ -188,7 +188,8 @@ static int net_lookup_dc(struct net_context *c, int argc, const char **argv)
        char *pdc_str = NULL;
        const char *domain = NULL;
        char *sitename = NULL;
-       int count, i;
+       size_t count = 0;
+       size_t i;
        char addr[INET6_ADDRSTRLEN];
        bool sec_ads = (lp_security() == SEC_ADS);