r16587: Fix Klocwork #1987. Memleak on reusing x_dbf.

Jeremy.

diff --git a/source/client/client.c b/source/client/client.c
index 0a695436f572434d55835f3fce79ab013fcc087d..3c2d7afe2d65d1804402b8dd6e9100f645ba6098 100644 (file)
--- a/source/client/client.c
+++ b/source/client/client.c
@@ -3464,6 +3464,9 @@ static int do_message_op(void)
                        }
                        break;
                case 'E':
+                       if (dbf) {
+                               x_fclose(dbf);
+                       }
                        dbf = x_stderr;
                        display_set_stderr();
                        break;

diff --git a/source/client/smbctool.c b/source/client/smbctool.c
index 3233ee495546f0350b7faefabfead569eb941c79..fd385ee68176baca8810cbce5e18d1ec8f8ec8a0 100644 (file)
--- a/source/client/smbctool.c
+++ b/source/client/smbctool.c
@@ -3605,6 +3605,9 @@ static int do_message_op(void)
                        }
                        break;
                case 'E':
+                       if (dbf) {
+                               x_fclose(dbf);
+                       }
                        dbf = x_stderr;
                        display_set_stderr();
                        break;