tests/samba-tool: test --help consistency
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 27 Jun 2019 04:57:22 +0000 (16:57 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Fri, 5 Jul 2019 01:05:20 +0000 (01:05 +0000)
Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/tests/samba_tool/help.py

index db70f6173555d5902d216902345d10384bd641ec..669895041ea596dfb5bcea7d812c39654ad89a29 100644 (file)
 import re
 from samba.tests.samba_tool.base import SambaToolCmdTest
 from samba.tests import BlackboxProcessError
+from samba.tests import check_help_consistency
 from samba.compat import get_string
 
+
 class HelpTestCase(SambaToolCmdTest):
     """Tests for samba-tool help and --help
 
@@ -65,6 +67,12 @@ class HelpTestCase(SambaToolCmdTest):
                 output2 = get_string(output2)
                 self.assertEqual(output, output2)
 
+                err = check_help_consistency(output,
+                                             options_start='Options:',
+                                             options_end='Available subcommands:')
+                if err is not None:
+                    self.fail("consistency error with %s:\n%s" % (line, err))
+
             if not new_commands:
                 break