s3:winbind: Add sanity check when closing fd
authorAndreas Schneider <asn@samba.org>
Wed, 16 May 2018 09:59:09 +0000 (11:59 +0200)
committerAndreas Schneider <asn@cryptomilk.org>
Thu, 17 May 2018 15:30:08 +0000 (17:30 +0200)
Found by Coverity.

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
source3/winbindd/winbindd_cm.c

index 9c2773d5d670e0f165e0f376617cdd8a0f4a0084..52b4c2c689fc480d7a5c848c6f9e55c69c861c6a 100644 (file)
@@ -1738,8 +1738,10 @@ static bool find_new_dc(TALLOC_CTX *mem_ctx,
        TALLOC_FREE(addrs);
        num_addrs = 0;
 
-       close(*fd);
-       *fd = -1;
+       if (*fd != -1) {
+               close(*fd);
+               *fd = -1;
+       }
 
        goto again;
 }