source3 torture: don't segfault if filename query fails
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Thu, 9 Jul 2015 02:17:50 +0000 (14:17 +1200)
committerJeremy Allison <jra@samba.org>
Thu, 30 Jul 2015 23:55:27 +0000 (01:55 +0200)
If the query return status is not OK, the query answer pointer could
be uninitialised.

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Simo Sorce <idra@samba.org>
source3/torture/torture.c

index bfd04f4e8470ef80087ff640ffcb16cd62bec649..e0be44e8e56b4782488ecf580b1f5c4d9fc190a0 100644 (file)
@@ -3264,8 +3264,7 @@ static bool run_trans2test(int dummy)
                printf("ERROR: qfilename failed (%s)\n", nt_errstr(status));
                correct = False;
        }
-
-       if (strcmp(pname, fname)) {
+       else if (strcmp(pname, fname)) {
                printf("qfilename gave different name? [%s] [%s]\n",
                       fname, pname);
                correct = False;