Fix overflow in vfs_recycle module (and hopefully also bug #291)

(This used to be commit 8625f0e015481a79b0a7dedb77c60ce7b2cb7b84)

diff --git a/source3/modules/vfs_recycle.c b/source3/modules/vfs_recycle.c
index e725daedba43067010cffa982fa1149ebde1e703..c0b331b8621accb390aed60f23e087c53e586413 100644 (file)
--- a/source3/modules/vfs_recycle.c
+++ b/source3/modules/vfs_recycle.c
@@ -455,7 +455,8 @@ static int recycle_unlink(vfs_handle_struct *handle, connection_struct *conn, co
        /* rename file we move to recycle bin */
        i = 1;
        while (recycle_file_exist(handle, final_name)) {
-               snprintf(final_name, PATH_MAX -1, "%s/Copy #%d of %s", temp_name, i++, base);
+               SAFE_FREE(final_name);
+               asprintf(&final_name, "%s/Copy #%d of %s", temp_name, i++, base);
        }
 
        DEBUG(10, ("recycle: Moving %s to %s\n", file_name, final_name));