tests: Remove redundant credentials from auth_log tests
authorTim Beale <timbeale@catalyst.net.nz>
Mon, 28 Jan 2019 01:11:09 +0000 (14:11 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Mon, 4 Mar 2019 21:41:16 +0000 (21:41 +0000)
The LDB connection in these tests is to the direct sam.ldb file on disk,
so the credentials are not actually needed (and in fact, weren't event
initialized correctly). These tests always need to run on the DC itself
(i.e. :local testenv) because they use ncalrpc connections.

Signed-off-by: Tim Beale <timbeale@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
python/samba/tests/auth_log_netlogon.py
python/samba/tests/auth_log_netlogon_bad_creds.py
python/samba/tests/auth_log_samlogon.py

index 83ffd33c1a64142e2f04192e0f0241255df75a47..36920eeef34e659652b423e1639b1d1e4beadc65 100644 (file)
@@ -47,12 +47,9 @@ class AuthLogTestsNetLogon(samba.tests.auth_log_base.AuthLogTestBase):
     def setUp(self):
         super(AuthLogTestsNetLogon, self).setUp()
         self.lp = samba.tests.env_loadparm()
-        self.creds = Credentials()
-
         self.session = system_session()
         self.ldb = SamDB(
             session_info=self.session,
-            credentials=self.creds,
             lp=self.lp)
 
         self.domain = os.environ["DOMAIN"]
index 3b699bb6505463ad2a729bb0448664a8990a8597..bd8b497cd886f936a119650faaad60aff0140e79 100644 (file)
@@ -49,12 +49,9 @@ class AuthLogTestsNetLogonBadCreds(samba.tests.auth_log_base.AuthLogTestBase):
     def setUp(self):
         super(AuthLogTestsNetLogonBadCreds, self).setUp()
         self.lp = samba.tests.env_loadparm()
-        self.creds = Credentials()
-
         self.session = system_session()
         self.ldb = SamDB(
             session_info=self.session,
-            credentials=self.creds,
             lp=self.lp)
 
         self.domain = os.environ["DOMAIN"]
index eeb64df41eb86f11faaed099b00be189fecc2372..4959543937e00c4978a37f8332c829adf5016b3a 100644 (file)
@@ -47,12 +47,9 @@ class AuthLogTestsSamLogon(samba.tests.auth_log_base.AuthLogTestBase):
     def setUp(self):
         super(AuthLogTestsSamLogon, self).setUp()
         self.lp = samba.tests.env_loadparm()
-        self.creds = Credentials()
-
         self.session = system_session()
         self.ldb = SamDB(
             session_info=self.session,
-            credentials=self.creds,
             lp=self.lp)
 
         self.domain = os.environ["DOMAIN"]