Back-port from vl.

Author: Volker Lendecke <vl@samba.org>
Date:   Mon Feb 11 18:36:06 2008 +0100

    Add a missing return

    If I'm not completely blind, we should return here. Not doing it here seems not
    to be a major flaw, as far as I can see we're only missing the error code. This
    might account for some of the very unhelpful NT_STATUS_UNSUCCESSFUL error
    messages people see during joins.

    All with stake in Samba client, please check!

diff --git a/source/libsmb/cliconnect.c b/source/libsmb/cliconnect.c
index 2f6606fafa5a3c3e2eb346496b571aba65378db2..42e0b63511741e5b6a9aa8cee31b00833fdf49bb 100644 (file)
--- a/source/libsmb/cliconnect.c
+++ b/source/libsmb/cliconnect.c
@@ -630,7 +630,7 @@ static ADS_STATUS cli_session_setup_kerberos(struct cli_state *cli, const char *
        if (!cli_session_setup_blob(cli, negTokenTarg, session_key_krb5)) {
                data_blob_free(&negTokenTarg);
                data_blob_free(&session_key_krb5);
-               ADS_ERROR_NT(cli_nt_error(cli));
+               return ADS_ERROR_NT(cli_nt_error(cli));
        }
 
        cli_set_session_key(cli, session_key_krb5);