s3:winbindd: consistently use TALLOC_FREE(conn->foo_pipe) is we create a new connection
authorStefan Metzmacher <metze@samba.org>
Thu, 25 Mar 2010 14:17:07 +0000 (15:17 +0100)
committerKarolin Seeger <kseeger@samba.org>
Tue, 30 Mar 2010 08:33:42 +0000 (10:33 +0200)
metze
(cherry picked from commit 4f391fedac7111683d13f2d79fee7c0dbc27f86e)
(cherry picked from commit c462e54142c00fdd81c2847d16a75119b1cc89fc)

source3/winbindd/winbindd_cm.c

index 62307d805fc6286827d8228ac991c6c2a180e2ed..96ad9f2c915f5de1d207a38e2031e4226ffccf72 100644 (file)
@@ -2021,6 +2021,7 @@ NTSTATUS cm_connect_sam(struct winbindd_domain *domain, TALLOC_CTX *mem_ctx,
                goto done;
        }
 
+       TALLOC_FREE(conn->samr_pipe);
 
        /*
         * No SAMR pipe yet. Attempt to get an NTLMSSP SPNEGO authenticated
@@ -2248,6 +2249,8 @@ NTSTATUS cm_connect_lsa(struct winbindd_domain *domain, TALLOC_CTX *mem_ctx,
                goto done;
        }
 
+       TALLOC_FREE(conn->lsa_pipe);
+
        if ((conn->cli->user_name[0] == '\0') ||
            (conn->cli->domain[0] == '\0') || 
            (conn->cli->password == NULL || conn->cli->password[0] == '\0')) {
@@ -2380,6 +2383,8 @@ NTSTATUS cm_connect_netlogon(struct winbindd_domain *domain,
                return NT_STATUS_OK;
        }
 
+       TALLOC_FREE(conn->netlogon_pipe);
+
        result = cli_rpc_pipe_open_noauth(conn->cli,
                                          &ndr_table_netlogon.syntax_id,
                                          &netlogon_pipe);