CVE-2023-3961:s3: smbd: Remove the SMB_ASSERT() that crashes on bad pipenames.

We correctly handle this and just return ENOENT (NT_STATUS_OBJECT_NAME_NOT_FOUND).

Remove knowfail.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15422

Signed-off-by: Jeremy Allison <jra@samba.org>

diff --git a/selftest/knownfail.d/badpipename b/selftest/knownfail.d/badpipename
deleted file mode 100644 (file)
index e69715f..0000000
--- a/selftest/knownfail.d/badpipename
+++ /dev/null
@@ -1 +0,0 @@
-^samba3.smbtorture_s3.smb2.SMB2-INVALID-PIPENAME.smbtorture\(fileserver\)

diff --git a/source3/rpc_client/local_np.c b/source3/rpc_client/local_np.c
index 95228d5d801d03d7815a8bc3a86aedab7f0ab88c..791ded99a470ab0eea3125c8563e91fcccb76523 100644 (file)
--- a/source3/rpc_client/local_np.c
+++ b/source3/rpc_client/local_np.c
@@ -551,11 +551,6 @@ struct tevent_req *local_np_connect_send(
        {
                DBG_DEBUG("attempt to connect to invalid pipe pathname %s\n",
                        lower_case_pipename);
-               /*
-                * For now, panic the server until we have
-                * the test code in place.
-                */
-               SMB_ASSERT(false);
                tevent_req_error(req, ENOENT);
                return tevent_req_post(req, ev);
        }