Fix Coverity ID 744

This was marked as a resource leak. This change makes the code a bit clearer
that we always free error_string.
(cherry picked from commit b03d45e6783e2706bd5d9c98a88ac07933e3adeb)

diff --git a/source/utils/ntlm_auth.c b/source/utils/ntlm_auth.c
index 2c62bd5c88fca7e4edc35c84bd278a27baad1bfa..8a9ac42329a333e50bc6fda5496881a040217b1d 100644 (file)
--- a/source/utils/ntlm_auth.c
+++ b/source/utils/ntlm_auth.c
@@ -1816,7 +1816,6 @@ static void manage_ntlm_server_1_request(struct ntlm_auth_state *state,
 
                                x_fprintf(x_stdout, "Authenticated: No\n");
                                x_fprintf(x_stdout, "Authentication-Error: %s\n.\n", error_string);
-                               SAFE_FREE(error_string);
                        } else {
                                static char zeros[16];
                                char *hex_lm_key;
@@ -1844,6 +1843,7 @@ static void manage_ntlm_server_1_request(struct ntlm_auth_state *state,
                                        TALLOC_FREE(hex_user_session_key);
                                }
                        }
+                       SAFE_FREE(error_string);
                }
                /* clear out the state */
                challenge = data_blob_null;