Even if the 'device type' is always an ascii string, use push_string to get

it out onto the wire.  Avoids valgrind warnings because the fstrcpy() causes
part of the wire buffer to be 'marked'.

Andrew Bartlett

diff --git a/source/libsmb/cliconnect.c b/source/libsmb/cliconnect.c
index 2aeac7273e200364498d55a767553e82c042d84f..f466b665ebd7d80432587e6b6f238a8ebce9531c 100644 (file)
--- a/source/libsmb/cliconnect.c
+++ b/source/libsmb/cliconnect.c
@@ -910,7 +910,7 @@ BOOL cli_send_tconX(struct cli_state *cli,
        memcpy(p,pword,passlen);
        p += passlen;
        p += clistr_push(cli, p, fullshare, -1, STR_TERMINATE |STR_UPPER);
-       fstrcpy(p, dev); p += strlen(dev)+1;
+       p += clistr_push(cli, p, dev, -1, STR_TERMINATE |STR_UPPER | STR_ASCII);
 
        cli_setup_bcc(cli, p);