s3:libsmb: only pass const sockaddr_storage to cli_full_connection()
authorStefan Metzmacher <metze@samba.org>
Fri, 22 Jul 2011 11:03:19 +0000 (13:03 +0200)
committerStefan Metzmacher <metze@samba.org>
Fri, 22 Jul 2011 15:06:08 +0000 (17:06 +0200)
No direct or indirect caller needs this to be set.

metze

source3/libsmb/cliconnect.c
source3/libsmb/proto.h

index 13e6877024d5897e21211eee64cb61fc44919da7..7b6da776f783fa7e6f1d6b9a65d5acc5b886f6df 100644 (file)
@@ -2947,7 +2947,7 @@ NTSTATUS cli_start_connection(struct cli_state **output_cli,
 NTSTATUS cli_full_connection(struct cli_state **output_cli, 
                             const char *my_name, 
                             const char *dest_host, 
-                            struct sockaddr_storage *dest_ss, int port,
+                            const struct sockaddr_storage *dest_ss, int port,
                             const char *service, const char *service_type,
                             const char *user, const char *domain, 
                             const char *password, int flags,
@@ -2971,10 +2971,6 @@ NTSTATUS cli_full_connection(struct cli_state **output_cli,
                return nt_status;
        }
 
-       if (dest_ss != NULL) {
-               *dest_ss = *cli_state_remote_sockaddr(cli);;
-       }
-
        cli->use_oplocks = ((flags & CLI_FULL_CONNECTION_OPLOCKS) != 0);
        cli->use_level_II_oplocks =
                ((flags & CLI_FULL_CONNECTION_LEVEL_II_OPLOCKS) != 0);
index 916e161d8ee66b61199319ae2bc0d8b67e3803f6..9e60fe9a9466315363a65d0082bb6fc906a995f4 100644 (file)
@@ -87,7 +87,7 @@ NTSTATUS cli_start_connection(struct cli_state **output_cli,
 NTSTATUS cli_full_connection(struct cli_state **output_cli,
                             const char *my_name,
                             const char *dest_host,
-                            struct sockaddr_storage *dest_ss, int port,
+                            const struct sockaddr_storage *dest_ss, int port,
                             const char *service, const char *service_type,
                             const char *user, const char *domain,
                             const char *password, int flags,