s3: smbd: srvstr_push() was changed to never return -1, so don't check for that as...

Bug 10775 - smbd crashes when accessing garbage filenames

https://bugzilla.samba.org/show_bug.cgi?id=10775

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: David Disseldorp <ddiss@samba.org>

diff --git a/source3/smbd/srvstr.c b/source3/smbd/srvstr.c
index c069dd4a5ecb1fec0dca400eaabd5a754e8d3dd7..648c69fbb7b35826555bde0b7259b0de61278530 100644 (file)
--- a/source3/smbd/srvstr.c
+++ b/source3/smbd/srvstr.c
@@ -65,7 +65,7 @@ ssize_t message_push_string(uint8 **outbuf, const char *str, int flags)
        result = srvstr_push((char *)tmp, SVAL(tmp, smb_flg2),
                             tmp + buf_size, str, grow_size, flags);
 
-       if (result == (size_t)-1) {
+       if (result == 0) {
                DEBUG(0, ("srvstr_push failed\n"));
                return -1;
        }