registry: Don't leave dangling transactions
authorVolker Lendecke <vl@samba.org>
Wed, 8 Oct 2014 13:39:28 +0000 (15:39 +0200)
committerKarolin Seeger <kseeger@samba.org>
Thu, 9 Oct 2014 19:23:06 +0000 (21:23 +0200)
When a createkey fails due to access denied, we need to do a
transaction_cancel. Otherwise the lock on the db will stay around.

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Guenther Deschner <gd@samba.org>
Bug: https://bugzilla.samba.org/show_bug.cgi?id=10860

source3/registry/reg_api.c

index ca990e22f85d5ab040ffd4e7c21a002ce64f0a69..cb8576e1767c7a1c44880ac949e128920f11c27a 100644 (file)
@@ -634,7 +634,7 @@ WERROR reg_createkey(TALLOC_CTX *ctx, struct registry_key *parent,
                                 key->token))
        {
                err = WERR_ACCESS_DENIED;
-               goto done;
+               goto trans_done;
        }
 
        /*