s4 torture: Change RAW-SFILEINFO-END-OF-FILE to check for share modes by default
authorTim Prouty <tprouty@samba.org>
Wed, 25 Nov 2009 22:40:54 +0000 (14:40 -0800)
committerTim Prouty <tprouty@samba.org>
Tue, 1 Dec 2009 19:12:51 +0000 (11:12 -0800)
Since the windows behavior appears to be a bug, only check for
the windows-style share mode bug if target=<windows variant> is
specified

source4/torture/raw/setfileinfo.c

index 0aa1f38c832265e4f772cb280ca3141c730be2b9..95fb9d7e060ef66519012e3ad8202d0df1ff1f36 100644 (file)
@@ -772,17 +772,15 @@ torture_raw_sfileinfo_eof(struct torture_context *tctx, struct smbcli_state *cli
         * Looks like a windows bug:
         * http://lists.samba.org/archive/cifs-protocol/2009-November/001130.html
         */
-       if (torture_setting_bool(tctx, "samba3", false) ||
-           torture_setting_bool(tctx, "samba4", false) ||
-           torture_setting_bool(tctx, "onefs", false)) {
+       if (TARGET_IS_W2K8(tctx) || TARGET_IS_WIN7(tctx)) {
+               /* It succeeds! This is just weird! */
+               torture_assert_ntstatus_equal_goto(tctx, status, NT_STATUS_OK, ret,
+                   done, "Status should be OK");
+       } else {
                torture_assert_ntstatus_equal_goto(tctx, status,
                    NT_STATUS_SHARING_VIOLATION, ret, done, "Status should be "
                    "SHARING_VIOLATION");
                goto done;
-       } else {
-               /* It succeeds! This is just weird! */
-               torture_assert_ntstatus_equal_goto(tctx, status, NT_STATUS_OK, ret,
-                   done, "Status should be OK");
        }
 
        /* Verify that the file was actually extended to 100. */