s3:libads: Add missing newlines to logging messages
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Mon, 7 Aug 2023 04:36:27 +0000 (16:36 +1200)
committerAndrew Bartlett <abartlet@samba.org>
Tue, 8 Aug 2023 04:39:38 +0000 (04:39 +0000)
Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
source3/libads/kerberos_keytab.c
source3/libads/krb5_setpw.c
source3/libads/ldap.c

index 13b102a5aa6fb5c92da2be56139df4b3c001b9a8..41397a1d2a22a5095e257ff7919277d973f18ebf 100644 (file)
@@ -53,7 +53,7 @@ static krb5_error_code ads_keytab_open(krb5_context context,
                                           keytab_str,
                                           sizeof(keytab_str) - 2);
                if (ret != 0) {
-                       DBG_WARNING("Failed to get default keytab name");
+                       DBG_WARNING("Failed to get default keytab name\n");
                        goto out;
                }
                keytab_name = keytab_str;
index 8f638dcdb8eddd2f4f5c2dcdcee83e737e8998ea..dda8857b217bee45e63fff842a913e419193aa9f 100644 (file)
@@ -262,7 +262,7 @@ static ADS_STATUS ads_krb5_chg_password(const char *kdc_host,
 
        if (ret) {
                if (ret == KRB5KRB_AP_ERR_BAD_INTEGRITY) {
-                       DEBUG(1,("Password incorrect while getting initial ticket"));
+                       DEBUG(1,("Password incorrect while getting initial ticket\n"));
                } else {
                        DEBUG(1,("krb5_get_init_creds_password failed (%s)\n", error_message(ret)));
                }
index 2853e15dfd38f43f6c08a2dd7c21558a85de7c00..f24c3e982edb71f77d23dd2110e2a8a9aaf62e53 100644 (file)
@@ -1146,7 +1146,7 @@ static char **ads_pull_strvals(TALLOC_CTX *ctx, const char **in_vals)
                if (!pull_utf8_talloc(ctx, &values[i], in_vals[i],
                                      &converted_size)) {
                        DEBUG(0,("ads_pull_strvals: pull_utf8_talloc failed: "
-                                "%s", strerror(errno)));
+                                "%s\n", strerror(errno)));
                }
        }
        return values;
@@ -1520,7 +1520,7 @@ ADS_STATUS ads_do_search_all_fn(ADS_STRUCT *ads, const char *bind_path,
 
        *res = NULL;
        if (!(ctx = talloc_init("ads_do_search"))) {
-               DEBUG(1,("ads_do_search: talloc_init() failed!"));
+               DEBUG(1,("ads_do_search: talloc_init() failed!\n"));
                return ADS_ERROR(LDAP_NO_MEMORY);
        }
 
@@ -1530,7 +1530,7 @@ ADS_STATUS ads_do_search_all_fn(ADS_STRUCT *ads, const char *bind_path,
        if (!push_utf8_talloc(ctx, &utf8_expr, expr, &converted_size) ||
            !push_utf8_talloc(ctx, &utf8_path, bind_path, &converted_size))
        {
-               DEBUG(1,("ads_do_search: push_utf8_talloc() failed!"));
+               DEBUG(1,("ads_do_search: push_utf8_talloc() failed!\n"));
                rc = LDAP_NO_MEMORY;
                goto done;
        }
@@ -1542,7 +1542,7 @@ ADS_STATUS ads_do_search_all_fn(ADS_STRUCT *ads, const char *bind_path,
                /* if (!(search_attrs = ads_push_strvals(ctx, attrs)))  */
                if (!(search_attrs = str_list_copy(talloc_tos(), attrs)))
                {
-                       DEBUG(1,("ads_do_search: str_list_copy() failed!"));
+                       DEBUG(1,("ads_do_search: str_list_copy() failed!\n"));
                        rc = LDAP_NO_MEMORY;
                        goto done;
                }
@@ -1914,7 +1914,7 @@ ADS_STATUS ads_gen_add(ADS_STRUCT *ads, const char *new_dn, ADS_MODLIST mods)
        DBG_INFO("AD LDAP: Adding %s\n", new_dn);
 
        if (!push_utf8_talloc(talloc_tos(), &utf8_dn, new_dn, &converted_size)) {
-               DEBUG(1, ("ads_gen_add: push_utf8_talloc failed!"));
+               DEBUG(1, ("ads_gen_add: push_utf8_talloc failed!\n"));
                return ADS_ERROR_NT(NT_STATUS_NO_MEMORY);
        }
 
@@ -1941,7 +1941,7 @@ ADS_STATUS ads_del_dn(ADS_STRUCT *ads, char *del_dn)
        char *utf8_dn = NULL;
        size_t converted_size;
        if (!push_utf8_talloc(talloc_tos(), &utf8_dn, del_dn, &converted_size)) {
-               DEBUG(1, ("ads_del_dn: push_utf8_talloc failed!"));
+               DEBUG(1, ("ads_del_dn: push_utf8_talloc failed!\n"));
                return ADS_ERROR_NT(NT_STATUS_NO_MEMORY);
        }
 
@@ -2976,7 +2976,7 @@ static bool ads_dump_field(ADS_STRUCT *ads, char *field, void **values, void *da
                                              &converted_size))
                        {
                                DEBUG(0,("ads_process_results: "
-                                        "pull_utf8_talloc failed: %s",
+                                        "pull_utf8_talloc failed: %s\n",
                                         strerror(errno)));
                        }