tdbtool: fix off-by-one error in argument length. (bug #2344)
authorMichael Adam <obnox@samba.org>
Tue, 8 Jul 2008 13:33:36 +0000 (15:33 +0200)
committerMichael Adam <obnox@samba.org>
Tue, 8 Jul 2008 14:05:03 +0000 (16:05 +0200)
This prevented all commands operating on keys (all non-traverse commands)
in tdbtool to fail with a "fetch failed" or "delete failed" message.

It seems that it fixes bug #2344 ...

Apparently this bug was introduced with 94e53472666ed in 2005.
Either nobody is using tdbtool or else tdb_find() has become
more strict about the key legth in the meantime. :-)

Michael
(cherry picked from commit fafb8ad2b81b9a46cf8259bedc1dca5023b06115)

source/lib/tdb/tools/tdbtool.c

index d104ccd7c44994e9d0f8ba138cbf4584343983dc..500e441c6a1c6036788a4ef2c0f004a42c2e76de 100644 (file)
@@ -598,7 +598,7 @@ static char *convert_string(char *instring, size_t *sizep)
        }
        length++;
     }
-    *sizep = length;
+    *sizep = length + 1;
     return instring;
 }