s3-nmbd: fix memleak in create_listen_fdset().
authorGünther Deschner <gd@samba.org>
Thu, 4 Aug 2011 15:28:05 +0000 (17:28 +0200)
committerKarolin Seeger <kseeger@samba.org>
Wed, 28 Sep 2011 18:12:01 +0000 (20:12 +0200)
Guenther

The last 2 patches address bug #8491 (fix some coverity issues).

source3/nmbd/nmbd_packets.c

index e53eebb0067cf003ef4d8e9b412a2399764c7f7d..51c9acc473f8df930cd6d6fc7bbe6273f235cd7c 100644 (file)
@@ -1715,6 +1715,7 @@ only use %d.\n", count, FD_SETSIZE));
        if (ClientNMB < 0 || ClientNMB >= FD_SETSIZE) {
                errno = EBADF;
                SAFE_FREE(pset);
+               SAFE_FREE(sock_array);
                return True;
        }
 
@@ -1752,6 +1753,7 @@ only use %d.\n", count, FD_SETSIZE));
        if (ClientDGRAM < 0 || ClientDGRAM >= FD_SETSIZE) {
                errno = EBADF;
                SAFE_FREE(pset);
+               SAFE_FREE(sock_array);
                return True;
        }
        FD_SET(ClientDGRAM,pset);