CVE-2016-0771: dnsserver: don't force UTF-8 for TXT
authorGarming Sam <garming@catalyst.net.nz>
Wed, 27 Jan 2016 23:36:43 +0000 (12:36 +1300)
committerKarolin Seeger <kseeger@samba.org>
Wed, 24 Feb 2016 10:43:59 +0000 (11:43 +0100)
While using a charset is not entirely logical, it allows testing of non
UTF-8 data (like inserting 0xFF into the TXT string).

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11128
BUG: https://bugzilla.samba.org/show_bug.cgi?id=11686

Signed-off-by: Garming Sam <garming@catalyst.net.nz>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
librpc/idl/dnsserver.idl

index 506d72ef7696062a07a6401f548c31f8c0f131f6..d567ec9e38e448c3b56d5bee971b909c6751807b 100644 (file)
@@ -73,7 +73,7 @@ import "misc.idl", "dnsp.idl";
 
        typedef [public,gensize] struct {
                [value(strlen(str))] uint8 len;
-               [charset(UTF8)] uint8 str[len];
+               [charset(UNIX)] uint8 str[len];
        }
        DNS_RPC_NAME;