Fix a few uninitialized variable warnings

I know those warnings are bogus, but both Coverity and gcc don't get it.

diff --git a/source3/smbd/smb2_break.c b/source3/smbd/smb2_break.c
index 25952fdf0d9f03c0c42b33f9a074cd718234c5f9..ba02dad62f75bd1839f583de9328c6fdec86a78e 100644 (file)
--- a/source3/smbd/smb2_break.c
+++ b/source3/smbd/smb2_break.c
@@ -92,7 +92,7 @@ static void smbd_smb2_request_oplock_break_done(struct tevent_req *subreq)
        int i = req->current_idx;
        uint64_t in_file_id_persistent;
        uint64_t in_file_id_volatile;
-       uint8_t out_oplock_level;
+       uint8_t out_oplock_level = 0;
        DATA_BLOB outbody;
        NTSTATUS status;
        NTSTATUS error; /* transport error */

diff --git a/source3/smbd/smb2_create.c b/source3/smbd/smb2_create.c
index b455f82d80c1835406c09ea5cf97b5c82a422bc8..511e448ac623d41decb9c3692f39770fb72735e6 100644 (file)
--- a/source3/smbd/smb2_create.c
+++ b/source3/smbd/smb2_create.c
@@ -141,16 +141,16 @@ static void smbd_smb2_request_create_done(struct tevent_req *subreq)
        uint8_t *outhdr;
        DATA_BLOB outbody;
        DATA_BLOB outdyn;
-       uint8_t out_oplock_level;
-       uint32_t out_create_action;
-       NTTIME out_creation_time;
-       NTTIME out_last_access_time;
-       NTTIME out_last_write_time;
-       NTTIME out_change_time;
-       uint64_t out_allocation_size;
-       uint64_t out_end_of_file;
-       uint32_t out_file_attributes;
-       uint64_t out_file_id_volatile;
+       uint8_t out_oplock_level = 0;
+       uint32_t out_create_action = 0;
+       NTTIME out_creation_time = 0;
+       NTTIME out_last_access_time = 0;
+       NTTIME out_last_write_time = 0;
+       NTTIME out_change_time = 0;
+       uint64_t out_allocation_size = 0;
+       uint64_t out_end_of_file = 0;
+       uint32_t out_file_attributes = 0;
+       uint64_t out_file_id_volatile = 0;
        NTSTATUS status;
        NTSTATUS error; /* transport error */
 

diff --git a/source3/smbd/smb2_find.c b/source3/smbd/smb2_find.c
index 55ea1c5a9fea7fefc3f8e74f68f5f0b58debfd59..89ba54c7e144912a93d376a0db597ac1fdd10172 100644 (file)
--- a/source3/smbd/smb2_find.c
+++ b/source3/smbd/smb2_find.c
@@ -137,7 +137,7 @@ static void smbd_smb2_request_find_done(struct tevent_req *subreq)
        DATA_BLOB outbody;
        DATA_BLOB outdyn;
        uint16_t out_output_buffer_offset;
-       DATA_BLOB out_output_buffer;
+       DATA_BLOB out_output_buffer = data_blob_null;
        NTSTATUS status;
        NTSTATUS error; /* transport error */
 

diff --git a/source3/smbd/smb2_getinfo.c b/source3/smbd/smb2_getinfo.c
index 5a6e3d7ecbf40088864e917db9591f4e757ad16c..b3cf8922172112e11946037331d6ff83f9de542d 100644 (file)
--- a/source3/smbd/smb2_getinfo.c
+++ b/source3/smbd/smb2_getinfo.c
@@ -130,7 +130,7 @@ static void smbd_smb2_request_getinfo_done(struct tevent_req *subreq)
        DATA_BLOB outbody;
        DATA_BLOB outdyn;
        uint16_t out_output_buffer_offset;
-       DATA_BLOB out_output_buffer;
+       DATA_BLOB out_output_buffer = data_blob_null;
        NTSTATUS status;
        NTSTATUS error; /* transport error */
 

diff --git a/source3/smbd/smb2_ioctl.c b/source3/smbd/smb2_ioctl.c
index 85da92e6c0063ba8bc3df5ff5db11c0ccb37e015..e1e26f1c598738eff38b4554d6a0bcba26f8eb9c 100644 (file)
--- a/source3/smbd/smb2_ioctl.c
+++ b/source3/smbd/smb2_ioctl.c
@@ -126,7 +126,7 @@ static void smbd_smb2_request_ioctl_done(struct tevent_req *subreq)
        uint64_t in_file_id_volatile;
        uint32_t out_input_offset;
        uint32_t out_output_offset;
-       DATA_BLOB out_output_buffer;
+       DATA_BLOB out_output_buffer = data_blob_null;
        NTSTATUS status;
        NTSTATUS error; /* transport error */
 

diff --git a/source3/smbd/smb2_negprot.c b/source3/smbd/smb2_negprot.c
index b312a7fa47b3d67518f5beb3541cf21de0e667ea..a60ea63b0094f1169d21b1350c7249c806fa8946 100644 (file)
--- a/source3/smbd/smb2_negprot.c
+++ b/source3/smbd/smb2_negprot.c
@@ -76,7 +76,7 @@ NTSTATUS smbd_smb2_request_process_negprot(struct smbd_smb2_request *req)
        size_t c;
        uint16_t security_mode;
        uint16_t dialect_count;
-       uint16_t dialect;
+       uint16_t dialect = 0;
        uint32_t capabilities;
 
 /* TODO: drop the connection with INVALI_PARAMETER */

diff --git a/source3/smbd/smb2_notify.c b/source3/smbd/smb2_notify.c
index f6d83aeeed921b2b6ef55c1dc64aa516cf66b660..4b9cbc495b56a377648125231b74d38867bc9c73 100644 (file)
--- a/source3/smbd/smb2_notify.c
+++ b/source3/smbd/smb2_notify.c
@@ -108,7 +108,7 @@ static void smbd_smb2_request_notify_done(struct tevent_req *subreq)
        DATA_BLOB outbody;
        DATA_BLOB outdyn;
        uint16_t out_output_buffer_offset;
-       DATA_BLOB out_output_buffer;
+       DATA_BLOB out_output_buffer = data_blob_null;
        NTSTATUS status;
        NTSTATUS error; /* transport error */
 

diff --git a/source3/smbd/smb2_read.c b/source3/smbd/smb2_read.c
index 42993511ec56fb01e4b497aac8dcb67b9678dfb8..c0521253d31311cd4bb684065236775d889edbb6 100644 (file)
--- a/source3/smbd/smb2_read.c
+++ b/source3/smbd/smb2_read.c
@@ -117,8 +117,8 @@ static void smbd_smb2_request_read_done(struct tevent_req *subreq)
        DATA_BLOB outbody;
        DATA_BLOB outdyn;
        uint8_t out_data_offset;
-       DATA_BLOB out_data_buffer;
-       uint32_t out_data_remaining;
+       DATA_BLOB out_data_buffer = data_blob_null;
+       uint32_t out_data_remaining = 0;
        NTSTATUS status;
        NTSTATUS error; /* transport error */
 

diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c
index 204e57d8601b5da0c66c7d48d8f2c0ef7bdd9fc2..2ae2ed29f7ff954ff2461eb0ebdfbab6b9003457 100644 (file)
--- a/source3/smbd/smb2_server.c
+++ b/source3/smbd/smb2_server.c
@@ -1523,7 +1523,7 @@ static void smbd_smb2_request_incoming(struct tevent_req *subreq)
        struct smbd_server_connection *conn = tevent_req_callback_data(subreq,
                                              struct smbd_server_connection);
        NTSTATUS status;
-       struct smbd_smb2_request *req;
+       struct smbd_smb2_request *req = NULL;
 
        status = smbd_smb2_request_read_recv(subreq, conn, &req);
        TALLOC_FREE(subreq);

diff --git a/source3/smbd/smb2_write.c b/source3/smbd/smb2_write.c
index f1606be62354fd9d967af73b1c10972bf7b42424..9f26f333c138352a182bb564f20b7d71084b0263 100644 (file)
--- a/source3/smbd/smb2_write.c
+++ b/source3/smbd/smb2_write.c
@@ -124,7 +124,7 @@ static void smbd_smb2_request_write_done(struct tevent_req *subreq)
        uint8_t *outhdr;
        DATA_BLOB outbody;
        DATA_BLOB outdyn;
-       uint32_t out_count;
+       uint32_t out_count = 0;
        NTSTATUS status;
        NTSTATUS error; /* transport error */